* [PATCH v2] Staging: iio: accel: Fixed NULL comparison style
@ 2015-12-13 13:43 Bhaktipriya Shridhar
2015-12-13 13:56 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Bhaktipriya Shridhar @ 2015-12-13 13:43 UTC (permalink / raw)
To: jic23, knaack.h, lars, pmeerw, gregkh, ciorneiioana,
cristina.moraru09, dan.carpenter, josselin.costanzi,
bhaktipriya96
Cc: linux-iio, devel, linux-kernel
The variable u8 **rx_p, is a pointer-to-pointer and hence the check should
be "if (!*rx_p)" and not "if (!rx_p)".
In the earlier version, checkpatch.pl gave the following check, which was
buggy:
CHECK: Comparison to NULL could be written "!rx_p"
+ if (*rx_p == NULL) {
Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
Changes in v2:
-Replaced "if (!rx_p)" with "if (!*rx_p)"
drivers/staging/iio/accel/sca3000_ring.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/iio/accel/sca3000_ring.c b/drivers/staging/iio/accel/sca3000_ring.c
index 5339b10..1920dc60 100644
--- a/drivers/staging/iio/accel/sca3000_ring.c
+++ b/drivers/staging/iio/accel/sca3000_ring.c
@@ -48,7 +48,7 @@ static int sca3000_read_data(struct sca3000_state *st,
}
};
*rx_p = kmalloc(len, GFP_KERNEL);
- if (!rx_p) {
+ if (!*rx_p) {
ret = -ENOMEM;
goto error_ret;
}
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] Staging: iio: accel: Fixed NULL comparison style
2015-12-13 13:43 [PATCH v2] Staging: iio: accel: Fixed NULL comparison style Bhaktipriya Shridhar
@ 2015-12-13 13:56 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2015-12-13 13:56 UTC (permalink / raw)
To: Bhaktipriya Shridhar
Cc: jic23, knaack.h, lars, pmeerw, gregkh, ciorneiioana,
cristina.moraru09, josselin.costanzi, linux-iio, devel,
linux-kernel
You have to resend it to apply on the original code, we are not going to
apply the first version of this patch. In other words it is:
- if (*rx_p == NULL) {
+ if (!*rxp) {
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-12-13 13:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-13 13:43 [PATCH v2] Staging: iio: accel: Fixed NULL comparison style Bhaktipriya Shridhar
2015-12-13 13:56 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).