* [GIT PULL 0/9] perf/core improvements and fixes
@ 2015-12-11 14:22 Arnaldo Carvalho de Melo
2015-12-11 14:22 ` [PATCH 1/9] perf top: Do not convert address for perf_top__record_precise_ip() Arnaldo Carvalho de Melo
` (9 more replies)
0 siblings, 10 replies; 42+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-12-11 14:22 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Alexei Starovoitov, Brendan Gregg, David Ahern, David S . Miller,
Jiri Olsa, Masami Hiramatsu, Namhyung Kim, Peter Zijlstra,
pi3orama, Wang Nan, Zefan Li, Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit e7a7865cc0da306542db0b9205cb0a467f59e33d:
perf symbols: Fix dso__load_sym to put dso (2015-12-10 16:29:32 -0300)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
for you to fetch changes up to 93b0ba3c60da89043ce2b9f601cd2b3da408903b:
perf tools: Clear struct machine during machine__init() (2015-12-11 09:32:41 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
User visible:
- Fix 'perf top' annotation in --stdio (Namhyung Kim)
- Support hw breakpoint events (mem:0xAddress) in the default output mode in
'perf script' (Wang Nan)
Infrastructure:
- Do not hold the hists lock while emitting one specific warning (Namhyung Kim)
- Fetch map names from correct strtab, worked so far because llvm/clang
uses just one string table (Wang Nan)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Namhyung Kim (4):
perf top: Do not convert address for perf_top__record_precise_ip()
perf top: Access hists->lock only if needed
perf top: Fix annotation on --stdio
perf top: Cleanup condition in perf_top__record_precise_ip()
Wang Nan (5):
tools lib bpf: Check return value of strdup when reading map names
tools lib bpf: Fetch map names from correct strtab
perf data: Add u32_hex data type
perf script: Add support for PERF_TYPE_BREAKPOINT
perf tools: Clear struct machine during machine__init()
tools/lib/bpf/libbpf.c | 24 +++++++++++++-----
tools/perf/builtin-script.c | 14 +++++++++++
tools/perf/builtin-top.c | 52 +++++++++++++++++----------------------
tools/perf/util/data-convert-bt.c | 2 ++
tools/perf/util/machine.c | 1 +
5 files changed, 57 insertions(+), 36 deletions(-)
^ permalink raw reply [flat|nested] 42+ messages in thread
* [PATCH 1/9] perf top: Do not convert address for perf_top__record_precise_ip()
2015-12-11 14:22 [GIT PULL 0/9] perf/core improvements and fixes Arnaldo Carvalho de Melo
@ 2015-12-11 14:22 ` Arnaldo Carvalho de Melo
2015-12-11 14:22 ` [PATCH 2/9] perf top: Access hists->lock only if needed Arnaldo Carvalho de Melo
` (8 subsequent siblings)
9 siblings, 0 replies; 42+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-12-11 14:22 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Namhyung Kim, David Ahern, Jiri Olsa,
Peter Zijlstra, Arnaldo Carvalho de Melo
From: Namhyung Kim <namhyung@kernel.org>
We call map->unmap_ip() before the function and call map->map_ip()
inside the function. This is meaningless and look strange since only
one of the two checks 'map'. Let's use al->addr directly.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1449802616-16170-1-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-top.c | 12 ++----------
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
index 785aa2dd8f0b..3b0978e5578a 100644
--- a/tools/perf/builtin-top.c
+++ b/tools/perf/builtin-top.c
@@ -189,8 +189,6 @@ static void perf_top__record_precise_ip(struct perf_top *top,
if (pthread_mutex_trylock(¬es->lock))
return;
- ip = he->ms.map->map_ip(he->ms.map, ip);
-
if (ui__has_annotation())
err = hist_entry__inc_addr_samples(he, counter, ip);
@@ -687,14 +685,8 @@ static int hist_iter__top_callback(struct hist_entry_iter *iter,
struct hist_entry *he = iter->he;
struct perf_evsel *evsel = iter->evsel;
- if (sort__has_sym && single) {
- u64 ip = al->addr;
-
- if (al->map)
- ip = al->map->unmap_ip(al->map, ip);
-
- perf_top__record_precise_ip(top, he, evsel->idx, ip);
- }
+ if (sort__has_sym && single)
+ perf_top__record_precise_ip(top, he, evsel->idx, al->addr);
hist__account_cycles(iter->sample->branch_stack, al, iter->sample,
!(top->record_opts.branch_stack & PERF_SAMPLE_BRANCH_ANY));
--
2.1.0
^ permalink raw reply related [flat|nested] 42+ messages in thread
* [PATCH 2/9] perf top: Access hists->lock only if needed
2015-12-11 14:22 [GIT PULL 0/9] perf/core improvements and fixes Arnaldo Carvalho de Melo
2015-12-11 14:22 ` [PATCH 1/9] perf top: Do not convert address for perf_top__record_precise_ip() Arnaldo Carvalho de Melo
@ 2015-12-11 14:22 ` Arnaldo Carvalho de Melo
2015-12-11 14:22 ` [PATCH 3/9] perf top: Fix annotation on --stdio Arnaldo Carvalho de Melo
` (7 subsequent siblings)
9 siblings, 0 replies; 42+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-12-11 14:22 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Namhyung Kim, David Ahern, Jiri Olsa,
Peter Zijlstra, Arnaldo Carvalho de Melo
From: Namhyung Kim <namhyung@kernel.org>
The perf_top__record_precise_ip() releases and regrabs the
he->hists->lock because it can sleep if there's an error. But it should
be done conditionally as it slows down the fast path.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1449802616-16170-2-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-top.c | 28 +++++++++++++++-------------
1 file changed, 15 insertions(+), 13 deletions(-)
diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
index 3b0978e5578a..586798acf7db 100644
--- a/tools/perf/builtin-top.c
+++ b/tools/perf/builtin-top.c
@@ -194,21 +194,23 @@ static void perf_top__record_precise_ip(struct perf_top *top,
pthread_mutex_unlock(¬es->lock);
- /*
- * This function is now called with he->hists->lock held.
- * Release it before going to sleep.
- */
- pthread_mutex_unlock(&he->hists->lock);
+ if (unlikely(err)) {
+ /*
+ * This function is now called with he->hists->lock held.
+ * Release it before going to sleep.
+ */
+ pthread_mutex_unlock(&he->hists->lock);
+
+ if (err == -ERANGE && !he->ms.map->erange_warned)
+ ui__warn_map_erange(he->ms.map, sym, ip);
+ else if (err == -ENOMEM) {
+ pr_err("Not enough memory for annotating '%s' symbol!\n",
+ sym->name);
+ sleep(1);
+ }
- if (err == -ERANGE && !he->ms.map->erange_warned)
- ui__warn_map_erange(he->ms.map, sym, ip);
- else if (err == -ENOMEM) {
- pr_err("Not enough memory for annotating '%s' symbol!\n",
- sym->name);
- sleep(1);
+ pthread_mutex_lock(&he->hists->lock);
}
-
- pthread_mutex_lock(&he->hists->lock);
}
static void perf_top__show_details(struct perf_top *top)
--
2.1.0
^ permalink raw reply related [flat|nested] 42+ messages in thread
* [PATCH 3/9] perf top: Fix annotation on --stdio
2015-12-11 14:22 [GIT PULL 0/9] perf/core improvements and fixes Arnaldo Carvalho de Melo
2015-12-11 14:22 ` [PATCH 1/9] perf top: Do not convert address for perf_top__record_precise_ip() Arnaldo Carvalho de Melo
2015-12-11 14:22 ` [PATCH 2/9] perf top: Access hists->lock only if needed Arnaldo Carvalho de Melo
@ 2015-12-11 14:22 ` Arnaldo Carvalho de Melo
2015-12-11 14:22 ` [PATCH 4/9] perf top: Cleanup condition in perf_top__record_precise_ip() Arnaldo Carvalho de Melo
` (6 subsequent siblings)
9 siblings, 0 replies; 42+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-12-11 14:22 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Namhyung Kim, David Ahern, Jiri Olsa,
Peter Zijlstra, Arnaldo Carvalho de Melo
From: Namhyung Kim <namhyung@kernel.org>
The ui__has_annotation() inside perf_top__record_precise_ip() should be
removed since it returns true only for TUI (and when sort key has
symbol). However the 'perf top --stdio' also supports annotation for a
symbol which was specified by 's' key action.
Actually it already does the necessary checks before calling the
function. So it's ok to get rid of the check here.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1449802616-16170-3-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-top.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
index 586798acf7db..f447e5531f8b 100644
--- a/tools/perf/builtin-top.c
+++ b/tools/perf/builtin-top.c
@@ -189,8 +189,7 @@ static void perf_top__record_precise_ip(struct perf_top *top,
if (pthread_mutex_trylock(¬es->lock))
return;
- if (ui__has_annotation())
- err = hist_entry__inc_addr_samples(he, counter, ip);
+ err = hist_entry__inc_addr_samples(he, counter, ip);
pthread_mutex_unlock(¬es->lock);
--
2.1.0
^ permalink raw reply related [flat|nested] 42+ messages in thread
* [PATCH 4/9] perf top: Cleanup condition in perf_top__record_precise_ip()
2015-12-11 14:22 [GIT PULL 0/9] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (2 preceding siblings ...)
2015-12-11 14:22 ` [PATCH 3/9] perf top: Fix annotation on --stdio Arnaldo Carvalho de Melo
@ 2015-12-11 14:22 ` Arnaldo Carvalho de Melo
2015-12-11 14:22 ` [PATCH 5/9] tools lib bpf: Check return value of strdup when reading map names Arnaldo Carvalho de Melo
` (5 subsequent siblings)
9 siblings, 0 replies; 42+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-12-11 14:22 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Namhyung Kim, David Ahern, Jiri Olsa,
Peter Zijlstra, Arnaldo Carvalho de Melo
From: Namhyung Kim <namhyung@kernel.org>
The 'he' cannot be NULL since it's caller hist_iter__top_callback() is
called only if iter->he is not NULL (see hist_entry_iter__add). So
setting 'sym' before the condition to simplify the code.
Also make it clearer that the top->symbol_filter_entry check is only
meaningful on stdio mode (i.e. when use_browser is 0).
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1449802616-16170-4-git-send-email-namhyung@kernel.org
[ Complete the simplification replacing one more he->ms.sym with sym ]
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-top.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
index f447e5531f8b..92fe963e43c4 100644
--- a/tools/perf/builtin-top.c
+++ b/tools/perf/builtin-top.c
@@ -175,15 +175,14 @@ static void perf_top__record_precise_ip(struct perf_top *top,
int counter, u64 ip)
{
struct annotation *notes;
- struct symbol *sym;
+ struct symbol *sym = he->ms.sym;
int err = 0;
- if (he == NULL || he->ms.sym == NULL ||
- ((top->sym_filter_entry == NULL ||
- top->sym_filter_entry->ms.sym != he->ms.sym) && use_browser != 1))
+ if (sym == NULL || (use_browser == 0 &&
+ (top->sym_filter_entry == NULL ||
+ top->sym_filter_entry->ms.sym != sym)))
return;
- sym = he->ms.sym;
notes = symbol__annotation(sym);
if (pthread_mutex_trylock(¬es->lock))
--
2.1.0
^ permalink raw reply related [flat|nested] 42+ messages in thread
* [PATCH 5/9] tools lib bpf: Check return value of strdup when reading map names
2015-12-11 14:22 [GIT PULL 0/9] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (3 preceding siblings ...)
2015-12-11 14:22 ` [PATCH 4/9] perf top: Cleanup condition in perf_top__record_precise_ip() Arnaldo Carvalho de Melo
@ 2015-12-11 14:22 ` Arnaldo Carvalho de Melo
2015-12-11 14:22 ` [PATCH 6/9] tools lib bpf: Fetch map names from correct strtab Arnaldo Carvalho de Melo
` (4 subsequent siblings)
9 siblings, 0 replies; 42+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-12-11 14:22 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Wang Nan, Zefan Li, pi3orama, Arnaldo Carvalho de Melo
From: Wang Nan <wangnan0@huawei.com>
Commit 561bbccac72d08babafaa33fd7fa9100ec4c9fb6 ("tools lib bpf:
Extract and collect map names from BPF object file") forgets checking
return value of strdup(). This patch fixes it. It also checks names
pointer before strcmp() for safety.
Signed-off-by: Wang Nan <wangnan0@huawei.com>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Cc: Zefan Li <lizefan@huawei.com>
Cc: pi3orama@163.com
Fixes: 561bbccac72d ("tools lib bpf: Extract and collect map names from BPF object file")
Link: http://lkml.kernel.org/r/1449541544-67621-2-git-send-email-wangnan0@huawei.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/lib/bpf/libbpf.c | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
index a298614ad091..16485ab05fc1 100644
--- a/tools/lib/bpf/libbpf.c
+++ b/tools/lib/bpf/libbpf.c
@@ -527,14 +527,14 @@ bpf_object__init_maps(struct bpf_object *obj, void *data,
return 0;
}
-static void
+static int
bpf_object__init_maps_name(struct bpf_object *obj, int maps_shndx)
{
int i;
Elf_Data *symbols = obj->efile.symbols;
if (!symbols || maps_shndx < 0)
- return;
+ return -EINVAL;
for (i = 0; i < symbols->d_size / sizeof(GElf_Sym); i++) {
GElf_Sym sym;
@@ -556,9 +556,14 @@ bpf_object__init_maps_name(struct bpf_object *obj, int maps_shndx)
continue;
}
obj->maps[map_idx].name = strdup(map_name);
+ if (!obj->maps[map_idx].name) {
+ pr_warning("failed to alloc map name\n");
+ return -ENOMEM;
+ }
pr_debug("map %zu is \"%s\"\n", map_idx,
obj->maps[map_idx].name);
}
+ return 0;
}
static int bpf_object__elf_collect(struct bpf_object *obj)
@@ -663,7 +668,7 @@ static int bpf_object__elf_collect(struct bpf_object *obj)
}
if (maps_shndx >= 0)
- bpf_object__init_maps_name(obj, maps_shndx);
+ err = bpf_object__init_maps_name(obj, maps_shndx);
out:
return err;
}
@@ -1372,7 +1377,7 @@ bpf_object__get_map_by_name(struct bpf_object *obj, const char *name)
struct bpf_map *pos;
bpf_map__for_each(pos, obj) {
- if (strcmp(pos->name, name) == 0)
+ if (pos->name && !strcmp(pos->name, name))
return pos;
}
return NULL;
--
2.1.0
^ permalink raw reply related [flat|nested] 42+ messages in thread
* [PATCH 6/9] tools lib bpf: Fetch map names from correct strtab
2015-12-11 14:22 [GIT PULL 0/9] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (4 preceding siblings ...)
2015-12-11 14:22 ` [PATCH 5/9] tools lib bpf: Check return value of strdup when reading map names Arnaldo Carvalho de Melo
@ 2015-12-11 14:22 ` Arnaldo Carvalho de Melo
2015-12-11 14:22 ` [PATCH 7/9] perf data: Add u32_hex data type Arnaldo Carvalho de Melo
` (3 subsequent siblings)
9 siblings, 0 replies; 42+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-12-11 14:22 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Wang Nan, Zefan Li, pi3orama, Arnaldo Carvalho de Melo
From: Wang Nan <wangnan0@huawei.com>
Namhyung Kim pointed out a potential problem in original code that it
fetches names of maps from section header string table, which is used
to store section names.
Original code doesn't cause error because of a LLVM behavior that, it
combines shstrtab into strtab. For example:
$ echo 'int func() {return 0;}' | x86_64-oe-linux-clang -x c -o temp.o -c -
$ readelf -h ./temp.o
ELF Header:
Magic: 7f 45 4c 46 02 01 01 03 00 00 00 00 00 00 00 00
...
Section header string table index: 1
$ readelf -S ./temp.o
There are 10 section headers, starting at offset 0x288:
Section Headers:
[Nr] Name Type Address Offset
Size EntSize Flags Link Info Align
[ 0] NULL 0000000000000000 00000000
0000000000000000 0000000000000000 0 0 0
[ 1] .strtab STRTAB 0000000000000000 00000230
0000000000000051 0000000000000000 0 0 1
...
$ readelf -p .strtab ./temp.o
String dump of section '.strtab':
[ 1] .text
[ 7] .comment
[ 10] .bss
[ 15] .note.GNU-stack
[ 25] .rela.eh_frame
[ 34] func
[ 39] .strtab
[ 41] .symtab
[ 49] .data
[ 4f] -
$ readelf -p .shstrtab ./temp.o
readelf: Warning: Section '.shstrtab' was not dumped because it does not exist!
Where, 'section header string table index' points to '.strtab', and
symbol names are also stored there.
However, in case of gcc:
$ echo 'int func() {return 0;}' | gcc -x c -o temp.o -c -
$ readelf -p .shstrtab ./temp.o
String dump of section '.shstrtab':
[ 1] .symtab
[ 9] .strtab
[ 11] .shstrtab
[ 1b] .text
[ 21] .data
[ 27] .bss
[ 2c] .comment
[ 35] .note.GNU-stack
[ 45] .rela.eh_frame
$ readelf -p .strtab ./temp.o
String dump of section '.strtab':
[ 1] func
They are separated sections.
Although original code doesn't cause error, we'd better use canonical
method for fetching symbol names to avoid potential behavior changing.
This patch learns from readelf's code, fetches string from sh_link
of .symbol section.
Signed-off-by: Wang Nan <wangnan0@huawei.com>
Reported-and-Acked-by: Namhyung Kim <namhyung@kernel.org>
Cc: Zefan Li <lizefan@huawei.com>
Cc: pi3orama@163.com
Link: http://lkml.kernel.org/r/1449541544-67621-3-git-send-email-wangnan0@huawei.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/lib/bpf/libbpf.c | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
index 16485ab05fc1..8334a5a9d5d7 100644
--- a/tools/lib/bpf/libbpf.c
+++ b/tools/lib/bpf/libbpf.c
@@ -195,6 +195,7 @@ struct bpf_object {
Elf *elf;
GElf_Ehdr ehdr;
Elf_Data *symbols;
+ size_t strtabidx;
struct {
GElf_Shdr shdr;
Elf_Data *data;
@@ -547,7 +548,7 @@ bpf_object__init_maps_name(struct bpf_object *obj, int maps_shndx)
continue;
map_name = elf_strptr(obj->efile.elf,
- obj->efile.ehdr.e_shstrndx,
+ obj->efile.strtabidx,
sym.st_name);
map_idx = sym.st_value / sizeof(struct bpf_map_def);
if (map_idx >= obj->nr_maps) {
@@ -630,8 +631,10 @@ static int bpf_object__elf_collect(struct bpf_object *obj)
pr_warning("bpf: multiple SYMTAB in %s\n",
obj->path);
err = -LIBBPF_ERRNO__FORMAT;
- } else
+ } else {
obj->efile.symbols = data;
+ obj->efile.strtabidx = sh.sh_link;
+ }
} else if ((sh.sh_type == SHT_PROGBITS) &&
(sh.sh_flags & SHF_EXECINSTR) &&
(data->d_size > 0)) {
@@ -667,6 +670,10 @@ static int bpf_object__elf_collect(struct bpf_object *obj)
goto out;
}
+ if (!obj->efile.strtabidx || obj->efile.strtabidx >= idx) {
+ pr_warning("Corrupted ELF file: index of strtab invalid\n");
+ return LIBBPF_ERRNO__FORMAT;
+ }
if (maps_shndx >= 0)
err = bpf_object__init_maps_name(obj, maps_shndx);
out:
--
2.1.0
^ permalink raw reply related [flat|nested] 42+ messages in thread
* [PATCH 7/9] perf data: Add u32_hex data type
2015-12-11 14:22 [GIT PULL 0/9] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (5 preceding siblings ...)
2015-12-11 14:22 ` [PATCH 6/9] tools lib bpf: Fetch map names from correct strtab Arnaldo Carvalho de Melo
@ 2015-12-11 14:22 ` Arnaldo Carvalho de Melo
2015-12-11 14:22 ` [PATCH 8/9] perf script: Add support for PERF_TYPE_BREAKPOINT Arnaldo Carvalho de Melo
` (2 subsequent siblings)
9 siblings, 0 replies; 42+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-12-11 14:22 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Wang Nan, David S. Miller, Alexei Starovoitov,
Brendan Gregg, Jiri Olsa, Masami Hiramatsu, Namhyung Kim,
Zefan Li, pi3orama, Arnaldo Carvalho de Melo
From: Wang Nan <wangnan0@huawei.com>
Add hexadecimal u32 to base data type, which is useful for raw output
because raw data is u32 aligned.
Signed-off-by: Wang Nan <wangnan0@huawei.com>
Cc: David S. Miller <davem@davemloft.net>
Cc: Alexei Starovoitov <ast@kernel.org>
Cc: Brendan Gregg <brendan.d.gregg@gmail.com>
Cc: David S. Miller <davem@davemloft.net>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Zefan Li <lizefan@huawei.com>
Cc: pi3orama@163.com
Link: http://lkml.kernel.org/r/1449541544-67621-12-git-send-email-wangnan0@huawei.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/data-convert-bt.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/perf/util/data-convert-bt.c b/tools/perf/util/data-convert-bt.c
index 5bfc1198ab46..34cd1e4039d3 100644
--- a/tools/perf/util/data-convert-bt.c
+++ b/tools/perf/util/data-convert-bt.c
@@ -63,6 +63,7 @@ struct ctf_writer {
struct bt_ctf_field_type *s32;
struct bt_ctf_field_type *u32;
struct bt_ctf_field_type *string;
+ struct bt_ctf_field_type *u32_hex;
struct bt_ctf_field_type *u64_hex;
};
struct bt_ctf_field_type *array[6];
@@ -982,6 +983,7 @@ do { \
CREATE_INT_TYPE(cw->data.u64, 64, false, false);
CREATE_INT_TYPE(cw->data.s32, 32, true, false);
CREATE_INT_TYPE(cw->data.u32, 32, false, false);
+ CREATE_INT_TYPE(cw->data.u32_hex, 32, false, true);
CREATE_INT_TYPE(cw->data.u64_hex, 64, false, true);
cw->data.string = bt_ctf_field_type_string_create();
--
2.1.0
^ permalink raw reply related [flat|nested] 42+ messages in thread
* [PATCH 8/9] perf script: Add support for PERF_TYPE_BREAKPOINT
2015-12-11 14:22 [GIT PULL 0/9] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (6 preceding siblings ...)
2015-12-11 14:22 ` [PATCH 7/9] perf data: Add u32_hex data type Arnaldo Carvalho de Melo
@ 2015-12-11 14:22 ` Arnaldo Carvalho de Melo
2015-12-11 14:22 ` [PATCH 9/9] perf tools: Clear struct machine during machine__init() Arnaldo Carvalho de Melo
2015-12-14 8:32 ` [GIT PULL 0/9] perf/core improvements and fixes Ingo Molnar
9 siblings, 0 replies; 42+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-12-11 14:22 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Wang Nan, Adrian Hunter, David S. Miller,
Jiri Olsa, Namhyung Kim, Zefan Li, pi3orama,
Arnaldo Carvalho de Melo
From: Wang Nan <wangnan0@huawei.com>
Useful for getting stack traces for hardware breakpoint events.
Test result:
Before this patch:
# ~/perf record -g -e mem:0x600980 ./sample
[ perf record: Woken up 1 times to write data ]
[ perf record: Captured and wrote 0.011 MB perf.data (12 samples) ]
# ~/perf script
# ~/perf script -F comm,tid,pid,time,event,ip,sym,dso
sample 22520/22520 97457.836294: mem:0x600980:
5a4ad8 __clear_user (/lib/modules/4.3.0-rc4+/build/vmlinux)
...
3f41ba sys_execve (/lib/modules/4.3.0-rc4+/build/vmlinux)
979395 return_from_execve (/lib/modules/4.3.0-rc4+/build/vmlinux)
7f1b59719cf7 [unknown] ([unknown])
sample 22520/22520 97457.836648: mem:0x600980:
532 main (/home/w00229757/DataBreakpoints/sample)
21bd5 __libc_start_main (/tmp/oxygen_root-root/lib64/libc-2.18.so)
...
After this patch:
# ~/perf script
sample 22520 97457.836294: mem:0x600980:
5a4ad8 __clear_user (/lib/modules/4.3.0-rc4+/build/vmlinux)
...
3f41ba sys_execve (/lib/modules/4.3.0-rc4+/build/vmlinux)
979395 return_from_execve (/lib/modules/4.3.0-rc4+/build/vmlinux)
7f1b59719cf7 [unknown] ([unknown])
sample 22520 97457.836648: mem:0x600980:
532 main (/home/w00229757/DataBreakpoints/sample)
21bd5 __libc_start_main (/tmp/oxygen_root-root/lib64/libc-2.18.so)
Committer note:
So, further testing, lets do it for a kernel global variable,
tcp_hashinfo:
# grep -w tcp_hashinfo /proc/kallsyms
ffffffff8202fc00 B tcp_hashinfo
#
Note: allow specifying mem:tcp_hashinfo:
# perf record -g -e mem:0xffffffff81c65ac0 -a
^C[ perf record: Woken up 1 times to write data ]
[ perf record: Captured and wrote 0.790 MB perf.data ]
#
# perf evlist
mem:0xffffffff8202fc00
# perf evlist -v
mem:0xffffffff8202fc00: type: 5, size: 112, { sample_period, sample_freq }: 1, sample_type: IP|TID|TIME|CALLCHAIN|CPU, disabled: 1, inherit: 1, mmap: 1, comm: 1, task: 1, sample_id_all: 1, exclude_guest: 1, mmap2: 1, comm_exec: 1, bp_type: 3, { bp_addr, config1 }: 0xffffffff8202fc00, { bp_len, config2 }: 0x4
#
Then, after this patch:
# perf script
swapper 0 [000] 171036.986988: mem:0xffffffff8202fc00:
8a0fb5 __inet_lookup_established (/lib/modules/4.3.0+/build/vmlinux)
8bc09d tcp_v4_early_demux (/lib/modules/4.3.0+/build/vmlinux)
896def ip_rcv_finish (/lib/modules/4.3.0+/build/vmlinux)
8976c2 ip_rcv (/lib/modules/4.3.0+/build/vmlinux)
855eba __netif_receive_skb_core (/lib/modules/4.3.0+/build/vmlinux)
8565d8 __netif_receive_skb (/lib/modules/4.3.0+/build/vmlinux)
8572a8 process_backlog (/lib/modules/4.3.0+/build/vmlinux)
856b11 net_rx_action (/lib/modules/4.3.0+/build/vmlinux)
2a284b __do_softirq (/lib/modules/4.3.0+/build/vmlinux)
2a2ba3 irq_exit (/lib/modules/4.3.0+/build/vmlinux)
96b7a4 do_IRQ (/lib/modules/4.3.0+/build/vmlinux)
969807 ret_from_intr (/lib/modules/4.3.0+/build/vmlinux)
804c27 cpuidle_enter (/lib/modules/4.3.0+/build/vmlinux)
2ded22 call_cpuidle (/lib/modules/4.3.0+/build/vmlinux)
2defb6 cpu_startup_entry (/lib/modules/4.3.0+/build/vmlinux)
95d5bc rest_init (/lib/modules/4.3.0+/build/vmlinux)
1163ffa start_kernel ([kernel.vmlinux].init.text)
11634d7 x86_64_start_reservations ([kernel.vmlinux].init.text)
1163623 x86_64_start_kernel ([kernel.vmlinux].init.text)
Signed-off-by: Wang Nan <wangnan0@huawei.com>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David S. Miller <davem@davemloft.net>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Zefan Li <lizefan@huawei.com>
Cc: pi3orama@163.com
Link: http://lkml.kernel.org/r/1449541544-67621-16-git-send-email-wangnan0@huawei.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-script.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
index 3c3f8d0e3064..d259e9aa3a71 100644
--- a/tools/perf/builtin-script.c
+++ b/tools/perf/builtin-script.c
@@ -130,6 +130,18 @@ static struct {
.invalid_fields = PERF_OUTPUT_TRACE,
},
+
+ [PERF_TYPE_BREAKPOINT] = {
+ .user_set = false,
+
+ .fields = PERF_OUTPUT_COMM | PERF_OUTPUT_TID |
+ PERF_OUTPUT_CPU | PERF_OUTPUT_TIME |
+ PERF_OUTPUT_EVNAME | PERF_OUTPUT_IP |
+ PERF_OUTPUT_SYM | PERF_OUTPUT_DSO |
+ PERF_OUTPUT_PERIOD,
+
+ .invalid_fields = PERF_OUTPUT_TRACE,
+ },
};
static bool output_set_by_user(void)
@@ -1129,6 +1141,8 @@ static int parse_output_fields(const struct option *opt __maybe_unused,
type = PERF_TYPE_TRACEPOINT;
else if (!strcmp(str, "raw"))
type = PERF_TYPE_RAW;
+ else if (!strcmp(str, "break"))
+ type = PERF_TYPE_BREAKPOINT;
else {
fprintf(stderr, "Invalid event type in field string.\n");
rc = -EINVAL;
--
2.1.0
^ permalink raw reply related [flat|nested] 42+ messages in thread
* [PATCH 9/9] perf tools: Clear struct machine during machine__init()
2015-12-11 14:22 [GIT PULL 0/9] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (7 preceding siblings ...)
2015-12-11 14:22 ` [PATCH 8/9] perf script: Add support for PERF_TYPE_BREAKPOINT Arnaldo Carvalho de Melo
@ 2015-12-11 14:22 ` Arnaldo Carvalho de Melo
2015-12-14 8:32 ` [GIT PULL 0/9] perf/core improvements and fixes Ingo Molnar
9 siblings, 0 replies; 42+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-12-11 14:22 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Wang Nan, Jiri Olsa, Namhyung Kim, Zefan Li,
pi3orama, Arnaldo Carvalho de Melo
From: Wang Nan <wangnan0@huawei.com>
There are so many test cases use stack allocated 'struct machine'.
Including:
test__hists_link
test__hists_filter
test__mmap_thread_lookup
test__thread_mg_share
test__hists_output
test__hists_cumulate
Also, in non-test code (for example, machine__new_host()) there are
code use 'malloc()' to alloc struct machine.
These are dangerous operations, cause some tests fail or hung in
machines__exit(). For example, in
machines__exit ->
machine__destroy_kernel_maps ->
map_groups__remove ->
maps__remove ->
pthread_rwlock_wrlock
a incorrectly initialized lock causes unintended behavior.
This patch memset(0) that structure in machine__init() to ensure all
fields in 'struct machine' are initialized to zero.
Signed-off-by: Wang Nan <wangnan0@huawei.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Zefan Li <lizefan@huawei.com>
Cc: pi3orama@163.com
Link: http://lkml.kernel.org/r/1449541544-67621-17-git-send-email-wangnan0@huawei.com
[ Use memset, see 'man bzero' ]
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/machine.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c
index f5882b8c8db9..1407d5107480 100644
--- a/tools/perf/util/machine.c
+++ b/tools/perf/util/machine.c
@@ -25,6 +25,7 @@ static void dsos__init(struct dsos *dsos)
int machine__init(struct machine *machine, const char *root_dir, pid_t pid)
{
+ memset(machine, 0, sizeof(*machine));
map_groups__init(&machine->kmaps, machine);
RB_CLEAR_NODE(&machine->rb_node);
dsos__init(&machine->dsos);
--
2.1.0
^ permalink raw reply related [flat|nested] 42+ messages in thread
* Re: [GIT PULL 0/9] perf/core improvements and fixes
2015-12-11 14:22 [GIT PULL 0/9] perf/core improvements and fixes Arnaldo Carvalho de Melo
` (8 preceding siblings ...)
2015-12-11 14:22 ` [PATCH 9/9] perf tools: Clear struct machine during machine__init() Arnaldo Carvalho de Melo
@ 2015-12-14 8:32 ` Ingo Molnar
9 siblings, 0 replies; 42+ messages in thread
From: Ingo Molnar @ 2015-12-14 8:32 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Adrian Hunter, Alexei Starovoitov, Brendan Gregg,
David Ahern, David S . Miller, Jiri Olsa, Masami Hiramatsu,
Namhyung Kim, Peter Zijlstra, pi3orama, Wang Nan, Zefan Li,
Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> The following changes since commit e7a7865cc0da306542db0b9205cb0a467f59e33d:
>
> perf symbols: Fix dso__load_sym to put dso (2015-12-10 16:29:32 -0300)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
>
> for you to fetch changes up to 93b0ba3c60da89043ce2b9f601cd2b3da408903b:
>
> perf tools: Clear struct machine during machine__init() (2015-12-11 09:32:41 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> User visible:
>
> - Fix 'perf top' annotation in --stdio (Namhyung Kim)
>
> - Support hw breakpoint events (mem:0xAddress) in the default output mode in
> 'perf script' (Wang Nan)
>
> Infrastructure:
>
> - Do not hold the hists lock while emitting one specific warning (Namhyung Kim)
>
> - Fetch map names from correct strtab, worked so far because llvm/clang
> uses just one string table (Wang Nan)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Namhyung Kim (4):
> perf top: Do not convert address for perf_top__record_precise_ip()
> perf top: Access hists->lock only if needed
> perf top: Fix annotation on --stdio
> perf top: Cleanup condition in perf_top__record_precise_ip()
>
> Wang Nan (5):
> tools lib bpf: Check return value of strdup when reading map names
> tools lib bpf: Fetch map names from correct strtab
> perf data: Add u32_hex data type
> perf script: Add support for PERF_TYPE_BREAKPOINT
> perf tools: Clear struct machine during machine__init()
>
> tools/lib/bpf/libbpf.c | 24 +++++++++++++-----
> tools/perf/builtin-script.c | 14 +++++++++++
> tools/perf/builtin-top.c | 52 +++++++++++++++++----------------------
> tools/perf/util/data-convert-bt.c | 2 ++
> tools/perf/util/machine.c | 1 +
> 5 files changed, 57 insertions(+), 36 deletions(-)
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 42+ messages in thread
* [GIT PULL 0/9] perf/core improvements and fixes
@ 2017-04-01 2:10 Arnaldo Carvalho de Melo
2017-04-01 10:44 ` Ingo Molnar
0 siblings, 1 reply; 42+ messages in thread
From: Arnaldo Carvalho de Melo @ 2017-04-01 2:10 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Alexander Shishkin, Alexis Berlemont, Al Viro, Colin King,
David Ahern, David Howells, Hemant Kumar, Jan Stancek, Jiri Olsa,
Kan Liang, kernel-janitors, Krister Johansen,
Luis Claudio Gonçalves, Masami Hiramatsu, Michael Ellerman,
Namhyung Kim, Naveen N . Rao, Peter Zijlstra, Ravi Bangoria,
Wang Nan, Yao Jin, Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
Test results at the end of this message, as usual.
The following changes since commit 3906a13a6b4e78fbc0def03a808f091f0dff1b44:
Merge tag 'perf-core-for-mingo-4.12-20170327' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2017-03-28 07:44:43 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-4.12-20170331
for you to fetch changes up to fd5cead23f54697310bd565aa2a23ae5128080a0:
perf trace: Beautify statx syscall 'flag' and 'mask' arguments (2017-03-31 14:42:31 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
New features:
- Beautify the statx syscall arguments in 'perf trace' (Arnaldo Carvalho de Melo)
e.g.:
System wide strace like session:
# trace -e statx
16612.967 ( 0.028 ms): statx/4562 statx(dfd: CWD, filename: /tmp/statx, flags: SYMLINK_NOFOLLOW, mask: TYPE|MODE|NLINK|UID|GID|ATIME|MTIME|CTIME|INO|SIZE|BLOCKS|BTIME, buffer: 0x7ffef195d660) = 0
36050.891 ( 0.007 ms): statx/4576 statx(dfd: CWD, filename: /etc/passwd, flags: SYMLINK_NOFOLLOW|STATX_DONT_SYNC, mask: BTIME, buffer: 0x7ffda9bf50f0) = 0
^C#
User visible:
- Handle unpaired raw_syscalls:sys_exit events in 'perf trace', i.e. we
shouldn't try to calculate duration or print the timestamp for a missing
matching raw_syscalls:sys_enter (Arnaldo Carvalho de Melo)
- Do not print "cycles: 0" in perf report LBR lines in platforms not
supporting 'cycles', such as Intel's Broadwell (Jin Yao)
- Handle missing $HOME env var (Jiri Olsa)
- Map 8-bit registers (al, bl, etc), not supported in uprobes_events, to
the next best thing (ax, bx, etc) supported (Ravi Bangoria)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (4):
perf tools: Remove support for command aliases
perf trace: Handle unpaired raw_syscalls:sys_exit event
tools include uapi: Grab copies of stat.h and fcntl.h
perf trace: Beautify statx syscall 'flag' and 'mask' arguments
Colin Ian King (1):
perf utils: Fix spelling mistake: "Invalud" -> "Invalid"
Jin Yao (1):
perf report: Drop cycles 0 for LBR print
Jiri Olsa (1):
perf tools: Do not fail in case of empty HOME env variable
Ravi Bangoria (2):
perf/sdt/x86: Add renaming logic for (missing) 8 bit registers
perf/sdt/x86: Move OP parser to tools/perf/arch/x86/
tools/include/linux/types.h | 1 +
tools/include/uapi/linux/fcntl.h | 72 +++++++++
tools/include/uapi/linux/stat.h | 176 ++++++++++++++++++++
tools/perf/Build | 1 +
tools/perf/MANIFEST | 2 +
tools/perf/arch/x86/entry/syscalls/syscall_64.tbl | 1 +
tools/perf/arch/x86/util/perf_regs.c | 187 ++++++++++++++++++----
tools/perf/builtin-help.c | 13 --
tools/perf/builtin-trace.c | 57 ++++---
tools/perf/check-headers.sh | 2 +
tools/perf/perf.c | 97 +----------
tools/perf/trace/beauty/Build | 1 +
tools/perf/trace/beauty/beauty.h | 24 +++
tools/perf/trace/beauty/statx.c | 72 +++++++++
tools/perf/util/Build | 1 -
tools/perf/util/alias.c | 78 ---------
tools/perf/util/cache.h | 1 -
tools/perf/util/callchain.c | 111 ++++++++-----
tools/perf/util/config.c | 54 ++++---
tools/perf/util/help-unknown-cmd.c | 8 +-
tools/perf/util/hist.c | 2 +-
tools/perf/util/perf_regs.c | 6 +-
tools/perf/util/perf_regs.h | 11 +-
tools/perf/util/probe-file.c | 132 +++++----------
24 files changed, 707 insertions(+), 403 deletions(-)
create mode 100644 tools/include/uapi/linux/fcntl.h
create mode 100644 tools/include/uapi/linux/stat.h
create mode 100644 tools/perf/trace/beauty/Build
create mode 100644 tools/perf/trace/beauty/beauty.h
create mode 100644 tools/perf/trace/beauty/statx.c
delete mode 100644 tools/perf/util/alias.c
Test results:
The first ones are container (docker) based builds of tools/perf with and
without libelf support, objtool where it is supported and samples/bpf/, ditto.
Where clang is available, it is also used to build perf with/without libelf.
For this specific pull request the samples/bpf/ was disabled, as 'make headers_install'
is failing with the following error, in this case in fedora:rawhide:
INSTALL usr/include/uapi/ (0 file)
/git/linux/scripts/Makefile.headersinst:62: *** Missing generated UAPI file ./arch/x86/include/generated/uapi/asm/unistd_32.h. Stop.
make[1]: *** [/git/linux/Makefile:1151: headers_install] Error 2
make[1]: Leaving directory '/tmp/build/linux'
make: *** [Makefile:152: sub-make] Error 2
make: Leaving directory '/git/linux'
I'll investigate later, perf and objtool builds just fine, with clang and gcc.
Several are cross builds, the ones with -x-ARCH, and the android one, and those
may not have all the features built, due to lack of multi-arch devel packages,
available and being used so far on just a few, like
debian:experimental-x-{arm64,mipsel}.
The 'perf test' one will perform a variety of tests exercising
tools/perf/util/, tools/lib/{bpf,traceevent,etc}, as well as run perf commands
with a variety of command line event specifications to then intercept the
sys_perf_event syscall to check that the perf_event_attr fields are set up as
expected, among a variety of other unit tests.
Then there is the 'make -C tools/perf build-test' ones, that build tools/perf/
with a variety of feature sets, exercising the build with an incomplete set of
features as well as with a complete one. It is planned to have it run on each
of the containers mentioned above, using some container orchestration
infrastructure. Get in contact if interested in helping having this in place.
# dm
1 alpine:3.4: Ok
2 alpine:3.5: Ok
3 alpine:edge: Ok
4 android-ndk:r12b-arm: Ok
5 archlinux:latest: Ok
6 centos:5: Ok
7 centos:6: Ok
8 centos:7: Ok
9 debian:7: Ok
10 debian:8: Ok
11 debian:9: Ok
12 debian:experimental: Ok
13 debian:experimental-x-arm64: Ok
14 debian:experimental-x-mips: Ok
15 debian:experimental-x-mips64: Ok
16 debian:experimental-x-mipsel: Ok
17 fedora:20: Ok
18 fedora:21: Ok
19 fedora:22: Ok
20 fedora:23: Ok
21 fedora:24: Ok
22 fedora:24-x-ARC-uClibc: Ok
23 fedora:25: Ok
24 fedora:rawhide: Ok
25 mageia:5: Ok
26 opensuse:13.2: Ok
27 opensuse:42.1: Ok
28 opensuse:tumbleweed: Ok
29 ubuntu:12.04.5: Ok
30 ubuntu:14.04.4: Ok
31 ubuntu:14.04.4-x-linaro-arm64: Ok
32 ubuntu:15.10: Ok
33 ubuntu:16.04: Ok
34 ubuntu:16.04-x-arm: Ok
35 ubuntu:16.04-x-arm64: Ok
36 ubuntu:16.04-x-powerpc: Ok
37 ubuntu:16.04-x-powerpc64: Ok
38 ubuntu:16.04-x-s390: Ok
39 ubuntu:16.10: Ok
40 ubuntu:17.04: Ok
#
# uname -a
Linux jouet 4.11.0-rc2+ #5 SMP Mon Mar 20 18:12:29 -03 2017 x86_64 x86_64 x86_64 GNU/Linux
# 'perf test tsc' already fixed by peterz in tip
# perf test
1: vmlinux symtab matches kallsyms : Ok
2: Detect openat syscall event : Ok
3: Detect openat syscall event on all cpus : Ok
4: Read samples using the mmap interface : Ok
5: Parse event definition strings : Ok
6: Simple expression parser : Ok
7: PERF_RECORD_* events & perf_sample fields : Ok
8: Parse perf pmu format : Ok
9: DSO data read : Ok
10: DSO data cache : Ok
11: DSO data reopen : Ok
12: Roundtrip evsel->name : Ok
13: Parse sched tracepoints fields : Ok
14: syscalls:sys_enter_openat event fields : Ok
15: Setup struct perf_event_attr : Ok
16: Match and link multiple hists : Ok
17: 'import perf' in python : Ok
18: Breakpoint overflow signal handler : Ok
19: Breakpoint overflow sampling : Ok
20: Number of exit events of a simple workload : Ok
21: Software clock events period values : Ok
22: Object code reading : Ok
23: Sample parsing : Ok
24: Use a dummy software event to keep tracking: Ok
25: Parse with no sample_id_all bit set : Ok
26: Filter hist entries : Ok
27: Lookup mmap thread : Ok
28: Share thread mg : Ok
29: Sort output of hist entries : Ok
30: Cumulate child hist entries : Ok
31: Track with sched_switch : Ok
32: Filter fds with revents mask in a fdarray : Ok
33: Add fd to a fdarray, making it autogrow : Ok
34: kmod_path__parse : Ok
35: Thread map : Ok
36: LLVM search and compile :
36.1: Basic BPF llvm compile : Ok
36.2: kbuild searching : Ok
36.3: Compile source for BPF prologue generation: Ok
36.4: Compile source for BPF relocation : Ok
37: Session topology : Ok
38: BPF filter :
38.1: Basic BPF filtering : Ok
38.2: BPF pinning : Ok
38.3: BPF prologue generation : Ok
38.4: BPF relocation checker : Ok
39: Synthesize thread map : Ok
40: Remove thread map : Ok
41: Synthesize cpu map : Ok
42: Synthesize stat config : Ok
43: Synthesize stat : Ok
44: Synthesize stat round : Ok
45: Synthesize attr update : Ok
46: Event times : Ok
47: Read backward ring buffer : Ok
48: Print cpu map : Ok
49: Probe SDT events : Ok
50: is_printable_array : Ok
51: Print bitmap : Ok
52: perf hooks : Ok
53: builtin clang support : Skip (not compiled in)
54: unit_number__scnprintf : Ok
55: x86 rdpmc : Ok
56: Convert perf time to TSC : FAILED!
57: DWARF unwind : Ok
58: x86 instruction decoder - new instructions : Ok
59: Intel cqm nmi context read : Skip
$ make -C tools/perf build-test
make_no_libdw_dwarf_unwind_O: make NO_LIBDW_DWARF_UNWIND=1
make_minimal_O: make NO_LIBPERL=1 NO_LIBPYTHON=1 NO_NEWT=1 NO_GTK2=1 NO_DEMANGLE=1 NO_LIBELF=1 NO_LIBUNWIND=1 NO_BACKTRACE=1 NO_LIBNUMA=1 NO_LIBAUDIT=1 NO_LIBBIONIC=1 NO_LIBDW_DWARF_UNWIND=1 NO_AUXTRACE=1 NO_LIBBPF=1 NO_LIBCRYPTO=1 NO_SDT=1 NO_JVMTI=1
make_no_gtk2_O: make NO_GTK2=1
make_no_newt_O: make NO_NEWT=1
make_debug_O: make DEBUG=1
make_no_backtrace_O: make NO_BACKTRACE=1
make_with_clangllvm_O: make LIBCLANGLLVM=1
make_tags_O: make tags
make_no_demangle_O: make NO_DEMANGLE=1
make_install_bin_O: make install-bin
make_no_libpython_O: make NO_LIBPYTHON=1
make_no_slang_O: make NO_SLANG=1
make_no_auxtrace_O: make NO_AUXTRACE=1
make_util_pmu_bison_o_O: make util/pmu-bison.o
make_no_ui_O: make NO_NEWT=1 NO_SLANG=1 NO_GTK2=1
make_no_scripts_O: make NO_LIBPYTHON=1 NO_LIBPERL=1
make_no_libbpf_O: make NO_LIBBPF=1
make_with_babeltrace_O: make LIBBABELTRACE=1
make_util_map_o_O: make util/map.o
make_static_O: make LDFLAGS=-static
make_help_O: make help
make_pure_O: make
make_perf_o_O: make perf.o
make_no_libnuma_O: make NO_LIBNUMA=1
make_no_libperl_O: make NO_LIBPERL=1
make_no_libunwind_O: make NO_LIBUNWIND=1
make_no_libbionic_O: make NO_LIBBIONIC=1
make_doc_O: make doc
make_no_libelf_O: make NO_LIBELF=1
make_clean_all_O: make clean all
make_install_prefix_O: make install prefix=/tmp/krava
make_no_libaudit_O: make NO_LIBAUDIT=1
make_install_O: make install
make_install_prefix_slash_O: make install prefix=/tmp/krava/
OK
make: Leaving directory '/home/acme/git/linux/tools/perf'
$
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [GIT PULL 0/9] perf/core improvements and fixes
2017-04-01 2:10 Arnaldo Carvalho de Melo
@ 2017-04-01 10:44 ` Ingo Molnar
0 siblings, 0 replies; 42+ messages in thread
From: Ingo Molnar @ 2017-04-01 10:44 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Adrian Hunter, Alexander Shishkin,
Alexis Berlemont, Al Viro, Colin King, David Ahern,
David Howells, Hemant Kumar, Jan Stancek, Jiri Olsa, Kan Liang,
kernel-janitors, Krister Johansen, Luis Claudio Gonçalves,
Masami Hiramatsu, Michael Ellerman, Namhyung Kim, Naveen N . Rao,
Peter Zijlstra, Ravi Bangoria, Wang Nan, Yao Jin,
Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> Test results at the end of this message, as usual.
>
> The following changes since commit 3906a13a6b4e78fbc0def03a808f091f0dff1b44:
>
> Merge tag 'perf-core-for-mingo-4.12-20170327' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2017-03-28 07:44:43 +0200)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-4.12-20170331
>
> for you to fetch changes up to fd5cead23f54697310bd565aa2a23ae5128080a0:
>
> perf trace: Beautify statx syscall 'flag' and 'mask' arguments (2017-03-31 14:42:31 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> New features:
>
> - Beautify the statx syscall arguments in 'perf trace' (Arnaldo Carvalho de Melo)
>
> e.g.:
>
> System wide strace like session:
>
> # trace -e statx
> 16612.967 ( 0.028 ms): statx/4562 statx(dfd: CWD, filename: /tmp/statx, flags: SYMLINK_NOFOLLOW, mask: TYPE|MODE|NLINK|UID|GID|ATIME|MTIME|CTIME|INO|SIZE|BLOCKS|BTIME, buffer: 0x7ffef195d660) = 0
> 36050.891 ( 0.007 ms): statx/4576 statx(dfd: CWD, filename: /etc/passwd, flags: SYMLINK_NOFOLLOW|STATX_DONT_SYNC, mask: BTIME, buffer: 0x7ffda9bf50f0) = 0
> ^C#
>
> User visible:
>
> - Handle unpaired raw_syscalls:sys_exit events in 'perf trace', i.e. we
> shouldn't try to calculate duration or print the timestamp for a missing
> matching raw_syscalls:sys_enter (Arnaldo Carvalho de Melo)
>
> - Do not print "cycles: 0" in perf report LBR lines in platforms not
> supporting 'cycles', such as Intel's Broadwell (Jin Yao)
>
> - Handle missing $HOME env var (Jiri Olsa)
>
> - Map 8-bit registers (al, bl, etc), not supported in uprobes_events, to
> the next best thing (ax, bx, etc) supported (Ravi Bangoria)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (4):
> perf tools: Remove support for command aliases
> perf trace: Handle unpaired raw_syscalls:sys_exit event
> tools include uapi: Grab copies of stat.h and fcntl.h
> perf trace: Beautify statx syscall 'flag' and 'mask' arguments
>
> Colin Ian King (1):
> perf utils: Fix spelling mistake: "Invalud" -> "Invalid"
>
> Jin Yao (1):
> perf report: Drop cycles 0 for LBR print
>
> Jiri Olsa (1):
> perf tools: Do not fail in case of empty HOME env variable
>
> Ravi Bangoria (2):
> perf/sdt/x86: Add renaming logic for (missing) 8 bit registers
> perf/sdt/x86: Move OP parser to tools/perf/arch/x86/
>
> tools/include/linux/types.h | 1 +
> tools/include/uapi/linux/fcntl.h | 72 +++++++++
> tools/include/uapi/linux/stat.h | 176 ++++++++++++++++++++
> tools/perf/Build | 1 +
> tools/perf/MANIFEST | 2 +
> tools/perf/arch/x86/entry/syscalls/syscall_64.tbl | 1 +
> tools/perf/arch/x86/util/perf_regs.c | 187 ++++++++++++++++++----
> tools/perf/builtin-help.c | 13 --
> tools/perf/builtin-trace.c | 57 ++++---
> tools/perf/check-headers.sh | 2 +
> tools/perf/perf.c | 97 +----------
> tools/perf/trace/beauty/Build | 1 +
> tools/perf/trace/beauty/beauty.h | 24 +++
> tools/perf/trace/beauty/statx.c | 72 +++++++++
> tools/perf/util/Build | 1 -
> tools/perf/util/alias.c | 78 ---------
> tools/perf/util/cache.h | 1 -
> tools/perf/util/callchain.c | 111 ++++++++-----
> tools/perf/util/config.c | 54 ++++---
> tools/perf/util/help-unknown-cmd.c | 8 +-
> tools/perf/util/hist.c | 2 +-
> tools/perf/util/perf_regs.c | 6 +-
> tools/perf/util/perf_regs.h | 11 +-
> tools/perf/util/probe-file.c | 132 +++++----------
> 24 files changed, 707 insertions(+), 403 deletions(-)
> create mode 100644 tools/include/uapi/linux/fcntl.h
> create mode 100644 tools/include/uapi/linux/stat.h
> create mode 100644 tools/perf/trace/beauty/Build
> create mode 100644 tools/perf/trace/beauty/beauty.h
> create mode 100644 tools/perf/trace/beauty/statx.c
> delete mode 100644 tools/perf/util/alias.c
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 42+ messages in thread
* [GIT PULL 0/9] perf/core improvements and fixes
@ 2015-09-23 1:57 Arnaldo Carvalho de Melo
2015-09-23 7:45 ` Ingo Molnar
0 siblings, 1 reply; 42+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-09-23 1:57 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Alexei Starovoitov, Borislav Petkov, Brendan Gregg,
Daniel Borkmann, David Ahern, Frederic Weisbecker, He Kuang,
H . Peter Anvin, Jiri Olsa, Kaixu Xia, Masami Hiramatsu,
Matt Fleming, Milian Wolff, Namhyung Kim, Paul Mackerras,
Peter Zijlstra, pi3orama, Raphael Beamonte, Stephane Eranian,
Steven Rostedt, Thomas Gleixner, Vinson Lee, Wang Nan, Zefan Li,
Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit 96f3eda67fcf2598e9d2794398e0e7ab35138ea6:
perf/x86/intel: Fix static checker warning in lbr enable (2015-09-18 09:24:57 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
for you to fetch changes up to e803cf97a4f90d31bcc2c9a1ea20fe9cdc12b2f9:
perf record: Synthesize COMM event for a command line workload (2015-09-22 22:43:12 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
User visible:
- Fix a segfault in 'perf probe' when removing uprobe events (Masami Hiramatsu)
- Synthesize COMM event for workloads started from the command line in 'perf
record' so that we can have the pid->comm mapping before we get the real
PERF_RECORD_COMM switching from perf to the workload (Namhyung Kim)
- Fix build tools/vm/ due to removal of tools/lib/api/fs/debugfs.h
(Arnaldo Carvalho de Melo)
Developer stuff:
- Fix the make tarball targets by including the recently added err.h header in
the perf MANIFEST file (Jiri Olsa)
- Don't assume that the event parser returns a non empty evlist (Wang Nan)
- Add way to disambiguate feature detection state files, needed to use
tools/build feature detection for multiple components in a single O= output
dir, which will be the case with tools/perf/ and tools/lib/bpf/
(Arnaldo Carvalho de Melo)
- Fixup FEATURE_{TESTS,DISPLAY} inversion in tools/lib/bpf/ (Arnaldo Carvalho de Melo)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (5):
tools build: Fixup feature detection display function name
tools lib bpf: Fix up FEATURE_{TESTS,DISPLAY} usage
tools build: Allow setting the feature detection user
tools lib bpf: Use FEATURE_USER to allow building in the same dir as perf
tools vm: Fix build due to removal of tools/lib/api/fs/debugfs.h
Jiri Olsa (1):
perf tools: Add include/err.h into MANIFEST
Masami Hiramatsu (1):
perf probe: Fix a segfault when removing uprobe events
Namhyung Kim (1):
perf record: Synthesize COMM event for a command line workload
Wang Nan (1):
perf tools: Don't assume that the parser returns non empty evsel list
tools/build/Makefile.feature | 9 +++++----
tools/lib/bpf/Makefile | 5 +++--
tools/perf/MANIFEST | 1 +
tools/perf/builtin-probe.c | 7 +++++--
tools/perf/builtin-record.c | 15 ++++++++++++++-
tools/perf/util/event.c | 2 +-
tools/perf/util/event.h | 5 +++++
tools/perf/util/parse-events.c | 16 ++++++++++++++++
tools/vm/page-types.c | 6 +++---
9 files changed, 53 insertions(+), 13 deletions(-)
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [GIT PULL 0/9] perf/core improvements and fixes
2015-09-23 1:57 Arnaldo Carvalho de Melo
@ 2015-09-23 7:45 ` Ingo Molnar
0 siblings, 0 replies; 42+ messages in thread
From: Ingo Molnar @ 2015-09-23 7:45 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Adrian Hunter, Alexei Starovoitov, Borislav Petkov,
Brendan Gregg, Daniel Borkmann, David Ahern, Frederic Weisbecker,
He Kuang, H . Peter Anvin, Jiri Olsa, Kaixu Xia,
Masami Hiramatsu, Matt Fleming, Milian Wolff, Namhyung Kim,
Paul Mackerras, Peter Zijlstra, pi3orama, Raphael Beamonte,
Stephane Eranian, Steven Rostedt, Thomas Gleixner, Vinson Lee,
Wang Nan, Zefan Li, Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> The following changes since commit 96f3eda67fcf2598e9d2794398e0e7ab35138ea6:
>
> perf/x86/intel: Fix static checker warning in lbr enable (2015-09-18 09:24:57 +0200)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
>
> for you to fetch changes up to e803cf97a4f90d31bcc2c9a1ea20fe9cdc12b2f9:
>
> perf record: Synthesize COMM event for a command line workload (2015-09-22 22:43:12 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> User visible:
>
> - Fix a segfault in 'perf probe' when removing uprobe events (Masami Hiramatsu)
>
> - Synthesize COMM event for workloads started from the command line in 'perf
> record' so that we can have the pid->comm mapping before we get the real
> PERF_RECORD_COMM switching from perf to the workload (Namhyung Kim)
>
> - Fix build tools/vm/ due to removal of tools/lib/api/fs/debugfs.h
> (Arnaldo Carvalho de Melo)
>
> Developer stuff:
>
> - Fix the make tarball targets by including the recently added err.h header in
> the perf MANIFEST file (Jiri Olsa)
>
> - Don't assume that the event parser returns a non empty evlist (Wang Nan)
>
> - Add way to disambiguate feature detection state files, needed to use
> tools/build feature detection for multiple components in a single O= output
> dir, which will be the case with tools/perf/ and tools/lib/bpf/
> (Arnaldo Carvalho de Melo)
>
> - Fixup FEATURE_{TESTS,DISPLAY} inversion in tools/lib/bpf/ (Arnaldo Carvalho de Melo)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (5):
> tools build: Fixup feature detection display function name
> tools lib bpf: Fix up FEATURE_{TESTS,DISPLAY} usage
> tools build: Allow setting the feature detection user
> tools lib bpf: Use FEATURE_USER to allow building in the same dir as perf
> tools vm: Fix build due to removal of tools/lib/api/fs/debugfs.h
>
> Jiri Olsa (1):
> perf tools: Add include/err.h into MANIFEST
>
> Masami Hiramatsu (1):
> perf probe: Fix a segfault when removing uprobe events
>
> Namhyung Kim (1):
> perf record: Synthesize COMM event for a command line workload
>
> Wang Nan (1):
> perf tools: Don't assume that the parser returns non empty evsel list
>
> tools/build/Makefile.feature | 9 +++++----
> tools/lib/bpf/Makefile | 5 +++--
> tools/perf/MANIFEST | 1 +
> tools/perf/builtin-probe.c | 7 +++++--
> tools/perf/builtin-record.c | 15 ++++++++++++++-
> tools/perf/util/event.c | 2 +-
> tools/perf/util/event.h | 5 +++++
> tools/perf/util/parse-events.c | 16 ++++++++++++++++
> tools/vm/page-types.c | 6 +++---
> 9 files changed, 53 insertions(+), 13 deletions(-)
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 42+ messages in thread
* [GIT PULL 0/9] perf/core improvements and fixes
@ 2015-08-21 16:10 Arnaldo Carvalho de Melo
2015-08-22 6:47 ` Ingo Molnar
0 siblings, 1 reply; 42+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-08-21 16:10 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Alexei Starovoitov, Borislav Petkov, Brendan Gregg,
Daniel Borkmann, David Ahern, Dean Nelson, Frederic Weisbecker,
He Kuang, Jiri Olsa, Kaixu Xia, Li Zhang, Masami Hiramatsu,
Namhyung Kim, Peter Zijlstra, pi3orama, Stephane Eranian,
Sukadev Bhattiprolu, Wang Nan, Zefan Li,
Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit 82819ffb42fb45197bacf3223191deca31d3eb91:
perf/x86/msr: Fix the MSR driver build (2015-08-21 08:17:01 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
for you to fetch changes up to 1c0bd0e891aaed0219010bfe79b32e1b0b82d662:
perf probe: Try to use symbol table if searching debug info failed (2015-08-21 12:57:20 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
User visible:
- Fix segfault using 'perf script --show-mmap-events', affects
only current perf/core (Adrian Hunter).
- /proc/kcore requires CAP_SYS_RAWIO message too noisy, make it
debug only (Adrian Hunter)
- Fix Intel PT timestamp handling (Adrian Hunter)
- Add Intel BTS support, with a call-graph script to show it and
PT in use in a GUI using 'perf script' python scripting with
postgresql and Qt (Adrian Hunter)
- Add checks for returned EVENT_ERROR type in libtraceevent, fixing
a bug that surfaced on arm64 systems (Dean Nelson)
- Fallback to using kallsyms when libdw fails to handle a vmlinux file,
that can happen, for instance, when perf is statically linked and
then libdw fails to load libebl_{arch}.so (Wang Nan)
Infrastructure:
- Initialize reference counts in map__clone() (Arnaldo Carvalho de Melo)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Adrian Hunter (6):
perf script: Fix segfault using --show-mmap-events
perf tools: /proc/kcore requires CAP_SYS_RAWIO message too noisy
perf tools: Fix Intel PT timestamp handling
perf tools: Add Intel BTS support
perf tools: Put itrace options into an asciidoc include
perf tools: Add example call-graph script
Arnaldo Carvalho de Melo (1):
perf tools: Initialize reference counts in map__clone()
Dean Nelson (1):
tools lib traceevent: Add checks for returned EVENT_ERROR type
Wang Nan (1):
perf probe: Try to use symbol table if searching debug info failed
tools/lib/traceevent/event-parse.c | 9 +
tools/perf/Documentation/intel-bts.txt | 86 ++
tools/perf/Documentation/itrace.txt | 22 +
tools/perf/Documentation/perf-inject.txt | 23 +-
tools/perf/Documentation/perf-report.txt | 23 +-
tools/perf/Documentation/perf-script.txt | 23 +-
tools/perf/arch/x86/util/Build | 1 +
tools/perf/arch/x86/util/auxtrace.c | 49 +-
tools/perf/arch/x86/util/intel-bts.c | 458 ++++++++++
tools/perf/arch/x86/util/pmu.c | 3 +
.../scripts/python/call-graph-from-postgresql.py | 327 ++++++++
tools/perf/scripts/python/export-to-postgresql.py | 47 ++
tools/perf/util/Build | 1 +
tools/perf/util/annotate.c | 1 +
tools/perf/util/auxtrace.c | 3 +
tools/perf/util/auxtrace.h | 1 +
tools/perf/util/evlist.c | 2 +-
tools/perf/util/intel-bts.c | 933 +++++++++++++++++++++
tools/perf/util/intel-bts.h | 43 +
tools/perf/util/intel-pt.c | 2 +-
tools/perf/util/map.c | 13 +-
tools/perf/util/pmu.c | 4 -
tools/perf/util/probe-event.c | 7 +-
tools/perf/util/symbol.c | 4 +-
24 files changed, 2004 insertions(+), 81 deletions(-)
create mode 100644 tools/perf/Documentation/intel-bts.txt
create mode 100644 tools/perf/Documentation/itrace.txt
create mode 100644 tools/perf/arch/x86/util/intel-bts.c
create mode 100644 tools/perf/scripts/python/call-graph-from-postgresql.py
create mode 100644 tools/perf/util/intel-bts.c
create mode 100644 tools/perf/util/intel-bts.h
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [GIT PULL 0/9] perf/core improvements and fixes
2015-08-21 16:10 Arnaldo Carvalho de Melo
@ 2015-08-22 6:47 ` Ingo Molnar
0 siblings, 0 replies; 42+ messages in thread
From: Ingo Molnar @ 2015-08-22 6:47 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Adrian Hunter, Alexei Starovoitov, Borislav Petkov,
Brendan Gregg, Daniel Borkmann, David Ahern, Dean Nelson,
Frederic Weisbecker, He Kuang, Jiri Olsa, Kaixu Xia, Li Zhang,
Masami Hiramatsu, Namhyung Kim, Peter Zijlstra, pi3orama,
Stephane Eranian, Sukadev Bhattiprolu, Wang Nan, Zefan Li,
Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> The following changes since commit 82819ffb42fb45197bacf3223191deca31d3eb91:
>
> perf/x86/msr: Fix the MSR driver build (2015-08-21 08:17:01 +0200)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
>
> for you to fetch changes up to 1c0bd0e891aaed0219010bfe79b32e1b0b82d662:
>
> perf probe: Try to use symbol table if searching debug info failed (2015-08-21 12:57:20 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> User visible:
>
> - Fix segfault using 'perf script --show-mmap-events', affects
> only current perf/core (Adrian Hunter).
>
> - /proc/kcore requires CAP_SYS_RAWIO message too noisy, make it
> debug only (Adrian Hunter)
>
> - Fix Intel PT timestamp handling (Adrian Hunter)
>
> - Add Intel BTS support, with a call-graph script to show it and
> PT in use in a GUI using 'perf script' python scripting with
> postgresql and Qt (Adrian Hunter)
>
> - Add checks for returned EVENT_ERROR type in libtraceevent, fixing
> a bug that surfaced on arm64 systems (Dean Nelson)
>
> - Fallback to using kallsyms when libdw fails to handle a vmlinux file,
> that can happen, for instance, when perf is statically linked and
> then libdw fails to load libebl_{arch}.so (Wang Nan)
>
> Infrastructure:
>
> - Initialize reference counts in map__clone() (Arnaldo Carvalho de Melo)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Adrian Hunter (6):
> perf script: Fix segfault using --show-mmap-events
> perf tools: /proc/kcore requires CAP_SYS_RAWIO message too noisy
> perf tools: Fix Intel PT timestamp handling
> perf tools: Add Intel BTS support
> perf tools: Put itrace options into an asciidoc include
> perf tools: Add example call-graph script
>
> Arnaldo Carvalho de Melo (1):
> perf tools: Initialize reference counts in map__clone()
>
> Dean Nelson (1):
> tools lib traceevent: Add checks for returned EVENT_ERROR type
>
> Wang Nan (1):
> perf probe: Try to use symbol table if searching debug info failed
>
> tools/lib/traceevent/event-parse.c | 9 +
> tools/perf/Documentation/intel-bts.txt | 86 ++
> tools/perf/Documentation/itrace.txt | 22 +
> tools/perf/Documentation/perf-inject.txt | 23 +-
> tools/perf/Documentation/perf-report.txt | 23 +-
> tools/perf/Documentation/perf-script.txt | 23 +-
> tools/perf/arch/x86/util/Build | 1 +
> tools/perf/arch/x86/util/auxtrace.c | 49 +-
> tools/perf/arch/x86/util/intel-bts.c | 458 ++++++++++
> tools/perf/arch/x86/util/pmu.c | 3 +
> .../scripts/python/call-graph-from-postgresql.py | 327 ++++++++
> tools/perf/scripts/python/export-to-postgresql.py | 47 ++
> tools/perf/util/Build | 1 +
> tools/perf/util/annotate.c | 1 +
> tools/perf/util/auxtrace.c | 3 +
> tools/perf/util/auxtrace.h | 1 +
> tools/perf/util/evlist.c | 2 +-
> tools/perf/util/intel-bts.c | 933 +++++++++++++++++++++
> tools/perf/util/intel-bts.h | 43 +
> tools/perf/util/intel-pt.c | 2 +-
> tools/perf/util/map.c | 13 +-
> tools/perf/util/pmu.c | 4 -
> tools/perf/util/probe-event.c | 7 +-
> tools/perf/util/symbol.c | 4 +-
> 24 files changed, 2004 insertions(+), 81 deletions(-)
> create mode 100644 tools/perf/Documentation/intel-bts.txt
> create mode 100644 tools/perf/Documentation/itrace.txt
> create mode 100644 tools/perf/arch/x86/util/intel-bts.c
> create mode 100644 tools/perf/scripts/python/call-graph-from-postgresql.py
> create mode 100644 tools/perf/util/intel-bts.c
> create mode 100644 tools/perf/util/intel-bts.h
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 42+ messages in thread
* [GIT PULL 0/9] perf/core improvements and fixes
@ 2015-08-10 20:56 Arnaldo Carvalho de Melo
2015-08-12 10:18 ` Ingo Molnar
0 siblings, 1 reply; 42+ messages in thread
From: Arnaldo Carvalho de Melo @ 2015-08-10 20:56 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Andi Kleen, Borislav Petkov, David Ahern, Frederic Weisbecker,
Jiri Olsa, Kan Liang, Namhyung Kim, Peter Zijlstra,
Stephane Eranian, Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit f1d800bf615b84ca253af372d2dac8cdef743a20:
Merge tag 'perf-ebpf-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2015-08-08 10:05:17 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
for you to fetch changes up to 4605bb55b91449a1a953a51f0334d3bc02351adb:
perf evlist: Be more specific on -F/--freq (2015-08-10 17:20:26 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
User visible:
- Introduce 'srcfile' sort key: (Andi Kleen)
# perf record -F 10000 usleep 1
# perf report --stdio --dsos '[kernel.vmlinux]' -s srcfile
<SNIP>
# Overhead Source File
26.49% copy_page_64.S
5.49% signal.c
0.51% msr.h
#
It can be combined with other fields, for instance, experiment with
'-s srcfile,symbol'.
There are some oddities in some distros and with some specific DSOs, being
investigated, so your mileage may vary.
- Update the column width for the "srcline" sort key (Arnaldo Carvalho de Melo)
- Support per-event 'freq' term: (Namhyung Kim)
$ perf record -e 'cpu/instructions,freq=1234/',cycles -c 1000 sleep 1
$ perf evlist -F
cpu/instructions,freq=1234/: sample_freq=1234
cycles: sample_period=1000
$
Infrastructure:
- Move perf_counts struct and functions into separate object (Jiri Olsa)
- Unset perf_event_attr::freq when period term is set (Jiri Olsa)
- Move callchain option parsing code to util.c (Kan Liang)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Andi Kleen (2):
perf tools: Support full source file paths for srcline
perf report: Add support for srcfile sort key
Arnaldo Carvalho de Melo (2):
perf hists: hist_entry__cmp() may use he_tmp.hists, initialize it
perf hists: Update the column width for the "srcline" sort key
Jiri Olsa (2):
perf stat: Move perf_counts struct and functions into separate object
perf tools: Unset perf_event_attr::freq when period term is set
Kan Liang (1):
perf callchain: Move option parsing code to util.c
Namhyung Kim (2):
perf record: Support per-event freq term
perf evlist: Be more specific on -F/--freq
tools/perf/Documentation/perf-record.txt | 1 +
tools/perf/Documentation/perf-report.txt | 4 ++
tools/perf/Documentation/perf-script.txt | 3 ++
tools/perf/builtin-report.c | 2 +
tools/perf/builtin-script.c | 2 +
tools/perf/builtin-stat.c | 1 +
tools/perf/util/Build | 1 +
tools/perf/util/callchain.c | 89 +------------------------------
tools/perf/util/callchain.h | 1 +
tools/perf/util/counts.c | 52 ++++++++++++++++++
tools/perf/util/counts.h | 37 +++++++++++++
tools/perf/util/evsel.c | 14 ++++-
tools/perf/util/evsel.h | 4 +-
tools/perf/util/hist.c | 9 ++++
tools/perf/util/hist.h | 1 +
tools/perf/util/parse-events.c | 6 +++
tools/perf/util/parse-events.h | 1 +
tools/perf/util/parse-events.l | 1 +
tools/perf/util/pmu.c | 2 +-
tools/perf/util/python-ext-sources | 2 +-
tools/perf/util/sort.c | 52 ++++++++++++++++++
tools/perf/util/sort.h | 2 +
tools/perf/util/srcline.c | 6 ++-
tools/perf/util/stat.c | 49 -----------------
tools/perf/util/stat.h | 30 -----------
tools/perf/util/util.c | 90 ++++++++++++++++++++++++++++++++
tools/perf/util/util.h | 3 ++
27 files changed, 292 insertions(+), 173 deletions(-)
create mode 100644 tools/perf/util/counts.c
create mode 100644 tools/perf/util/counts.h
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [GIT PULL 0/9] perf/core improvements and fixes
2015-08-10 20:56 Arnaldo Carvalho de Melo
@ 2015-08-12 10:18 ` Ingo Molnar
0 siblings, 0 replies; 42+ messages in thread
From: Ingo Molnar @ 2015-08-12 10:18 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Adrian Hunter, Andi Kleen, Borislav Petkov,
David Ahern, Frederic Weisbecker, Jiri Olsa, Kan Liang,
Namhyung Kim, Peter Zijlstra, Stephane Eranian,
Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> The following changes since commit f1d800bf615b84ca253af372d2dac8cdef743a20:
>
> Merge tag 'perf-ebpf-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2015-08-08 10:05:17 +0200)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
>
> for you to fetch changes up to 4605bb55b91449a1a953a51f0334d3bc02351adb:
>
> perf evlist: Be more specific on -F/--freq (2015-08-10 17:20:26 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> User visible:
>
> - Introduce 'srcfile' sort key: (Andi Kleen)
>
> # perf record -F 10000 usleep 1
> # perf report --stdio --dsos '[kernel.vmlinux]' -s srcfile
> <SNIP>
> # Overhead Source File
> 26.49% copy_page_64.S
> 5.49% signal.c
> 0.51% msr.h
> #
>
> It can be combined with other fields, for instance, experiment with
> '-s srcfile,symbol'.
>
> There are some oddities in some distros and with some specific DSOs, being
> investigated, so your mileage may vary.
>
> - Update the column width for the "srcline" sort key (Arnaldo Carvalho de Melo)
>
> - Support per-event 'freq' term: (Namhyung Kim)
>
> $ perf record -e 'cpu/instructions,freq=1234/',cycles -c 1000 sleep 1
> $ perf evlist -F
> cpu/instructions,freq=1234/: sample_freq=1234
> cycles: sample_period=1000
> $
>
> Infrastructure:
>
> - Move perf_counts struct and functions into separate object (Jiri Olsa)
>
> - Unset perf_event_attr::freq when period term is set (Jiri Olsa)
>
> - Move callchain option parsing code to util.c (Kan Liang)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Andi Kleen (2):
> perf tools: Support full source file paths for srcline
> perf report: Add support for srcfile sort key
>
> Arnaldo Carvalho de Melo (2):
> perf hists: hist_entry__cmp() may use he_tmp.hists, initialize it
> perf hists: Update the column width for the "srcline" sort key
>
> Jiri Olsa (2):
> perf stat: Move perf_counts struct and functions into separate object
> perf tools: Unset perf_event_attr::freq when period term is set
>
> Kan Liang (1):
> perf callchain: Move option parsing code to util.c
>
> Namhyung Kim (2):
> perf record: Support per-event freq term
> perf evlist: Be more specific on -F/--freq
>
> tools/perf/Documentation/perf-record.txt | 1 +
> tools/perf/Documentation/perf-report.txt | 4 ++
> tools/perf/Documentation/perf-script.txt | 3 ++
> tools/perf/builtin-report.c | 2 +
> tools/perf/builtin-script.c | 2 +
> tools/perf/builtin-stat.c | 1 +
> tools/perf/util/Build | 1 +
> tools/perf/util/callchain.c | 89 +------------------------------
> tools/perf/util/callchain.h | 1 +
> tools/perf/util/counts.c | 52 ++++++++++++++++++
> tools/perf/util/counts.h | 37 +++++++++++++
> tools/perf/util/evsel.c | 14 ++++-
> tools/perf/util/evsel.h | 4 +-
> tools/perf/util/hist.c | 9 ++++
> tools/perf/util/hist.h | 1 +
> tools/perf/util/parse-events.c | 6 +++
> tools/perf/util/parse-events.h | 1 +
> tools/perf/util/parse-events.l | 1 +
> tools/perf/util/pmu.c | 2 +-
> tools/perf/util/python-ext-sources | 2 +-
> tools/perf/util/sort.c | 52 ++++++++++++++++++
> tools/perf/util/sort.h | 2 +
> tools/perf/util/srcline.c | 6 ++-
> tools/perf/util/stat.c | 49 -----------------
> tools/perf/util/stat.h | 30 -----------
> tools/perf/util/util.c | 90 ++++++++++++++++++++++++++++++++
> tools/perf/util/util.h | 3 ++
> 27 files changed, 292 insertions(+), 173 deletions(-)
> create mode 100644 tools/perf/util/counts.c
> create mode 100644 tools/perf/util/counts.h
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 42+ messages in thread
* [GIT PULL 0/9] perf/core improvements and fixes
@ 2014-06-19 16:38 Jiri Olsa
0 siblings, 0 replies; 42+ messages in thread
From: Jiri Olsa @ 2014-06-19 16:38 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Corey Ashford,
David Ahern, Frederic Weisbecker, Jan Kiszka, Jiri Olsa,
Namhyung Kim, Paul Mackerras, Peter Zijlstra, Simon Que,
Steven Rostedt
hi Ingo,
please consider pulling
thanks,
jirka
The following changes since commit 4ba96195051be30160af6d5f5f83f9a055ab1f23:
Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf into perf/core (2014-06-13 08:19:06 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git tags/perf-core-for-mingo
for you to fetch changes up to 26d664a30d08002ac0a4dbd09217ea084da07bc9:
perf symbols: Get kernel start address by symbol name (2014-06-19 18:18:38 +0200)
----------------------------------------------------------------
perf/core improvements and fixes:
. Updates from trace-cmd for traceevent plugin_kvm plus args cleanup (Steven Rostedt)
. Fix kernel start address lookup in report code (Simon Que)
. Fix segfault in cumulative.callchain report (Jiri Olsa)
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
----------------------------------------------------------------
Jan Kiszka (3):
tools lib traceevent: Report unknown VMX exit reasons with code
tools lib traceevent: Factor out print_exit_reason in kvm plugin
tools lib traceevent: Fix and cleanup kvm_nested_vmexit tracepoints
Jiri Olsa (1):
perf tools: Fix segfault in cumulative.callchain report
Simon Que (1):
perf symbols: Get kernel start address by symbol name
Steven Rostedt (3):
tools lib traceevent: Fix format in plugin_kvm
tools lib traceevent: Clean up format of args in cfg80211 plugin
tools lib traceevent: Clean up format of args in jbd2 plugin
Steven Rostedt (Red Hat) (1):
tools lib traceevent: Add back in kvm plugins nested_vmexit events
tools/lib/traceevent/plugin_cfg80211.c | 3 +-
tools/lib/traceevent/plugin_jbd2.c | 6 ++--
tools/lib/traceevent/plugin_kvm.c | 64 +++++++++++++++++++++++++++++-----
tools/perf/ui/browsers/hists.c | 21 ++++++++---
tools/perf/util/machine.c | 54 ++++++++++++----------------
5 files changed, 97 insertions(+), 51 deletions(-)
^ permalink raw reply [flat|nested] 42+ messages in thread
* [GIT PULL 0/9] perf/core improvements and fixes
@ 2014-06-03 20:36 Jiri Olsa
2014-06-05 8:45 ` Ingo Molnar
0 siblings, 1 reply; 42+ messages in thread
From: Jiri Olsa @ 2014-06-03 20:36 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Adrian Hunter, Arnaldo Carvalho de Melo,
Arnaldo Carvalho de Melo, Cody P Schafer, Corey Ashford,
David Ahern, David Binderman, Dianfang Zhang, Don Zickus,
Frederic Weisbecker, Jean Delvare, Jianyu Zhan, Jiri Olsa,
Mike Galbraith, Namhyung Kim, Paul Mackerras, Peter Zijlstra,
Peter Zijlstra, Sebastian Andrzej Siewior, Stephane Eranian,
Sukadev Bhattiprolu
hi Ingo,
please consider pulling
thanks,
jirka
The following changes since commit 9b261365dd73a5014b49033327ad881708e81f33:
Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf into perf/core (2014-06-03 20:22:40 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git tags/perf-core-for-mingo
for you to fetch changes up to fc9cabeabf42d76854059e7bce81a02645e7e5ca:
perf tools: Fix 'make help' message error (2014-06-03 21:35:12 +0200)
----------------------------------------------------------------
perf/core improvements and fixes:
. Warn the user when trace command is not available (Arnaldo Carvalho de Melo)
. Add warning when disabling perl scripting support due to missing devel files (Arnaldo Carvalho de Melo)
. Consider header files outside perf directory in tags target (Sebastian Andrzej Siewior)
. Allow overriding sysfs and proc finding with env var (Cody P Schafer)
. Fix "==" into "=" in ui_browser__warning assignment (zhangdianfang)
. Factor elide bool handling in sort code (Jiri Olsa)
. Fix poll return value propagation (Jiri Olsa)
. Fix 'make help' message error (Jianyu Zhan)
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (2):
perf trace: Warn the user when not available
perf tools: Add warning when disabling perl scripting support due to missing devel files
Cody P Schafer (1):
perf tools: Allow overriding sysfs and proc finding with env var
Jianyu Zhan (1):
perf tools: Fix 'make help' message error
Jiri Olsa (3):
perf tools: Remove elide setup for SORT_MODE__MEMORY mode
perf tools: Move elide bool into perf_hpp_fmt struct
perf record: Fix poll return value propagation
Sebastian Andrzej Siewior (1):
perf tools: Consider header files outside perf directory in tags target
zhangdianfang (1):
perf tools: Fix "==" into "=" in ui_browser__warning assignment
tools/lib/api/fs/fs.c | 43 ++++++++++++++++-
tools/perf/Makefile.perf | 13 ++++--
tools/perf/builtin-record.c | 6 ++-
tools/perf/config/Makefile | 3 +-
tools/perf/perf.c | 8 +++-
tools/perf/ui/browser.c | 2 +-
tools/perf/ui/browsers/hists.c | 8 ++--
tools/perf/util/hist.h | 8 +++-
tools/perf/util/sort.c | 103 ++++++++++++++++++++++-------------------
tools/perf/util/sort.h | 2 +-
10 files changed, 132 insertions(+), 64 deletions(-)
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [GIT PULL 0/9] perf/core improvements and fixes
2014-06-03 20:36 Jiri Olsa
@ 2014-06-05 8:45 ` Ingo Molnar
0 siblings, 0 replies; 42+ messages in thread
From: Ingo Molnar @ 2014-06-05 8:45 UTC (permalink / raw)
To: Jiri Olsa
Cc: linux-kernel, Adrian Hunter, Arnaldo Carvalho de Melo,
Arnaldo Carvalho de Melo, Cody P Schafer, Corey Ashford,
David Ahern, David Binderman, Dianfang Zhang, Don Zickus,
Frederic Weisbecker, Jean Delvare, Jianyu Zhan, Mike Galbraith,
Namhyung Kim, Paul Mackerras, Peter Zijlstra, Peter Zijlstra,
Sebastian Andrzej Siewior, Stephane Eranian, Sukadev Bhattiprolu
* Jiri Olsa <jolsa@kernel.org> wrote:
> hi Ingo,
> please consider pulling
>
> thanks,
> jirka
>
>
> The following changes since commit 9b261365dd73a5014b49033327ad881708e81f33:
>
> Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf into perf/core (2014-06-03 20:22:40 +0200)
>
> are available in the git repository at:
>
>
> git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git tags/perf-core-for-mingo
>
> for you to fetch changes up to fc9cabeabf42d76854059e7bce81a02645e7e5ca:
>
> perf tools: Fix 'make help' message error (2014-06-03 21:35:12 +0200)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> . Warn the user when trace command is not available (Arnaldo Carvalho de Melo)
>
> . Add warning when disabling perl scripting support due to missing devel files (Arnaldo Carvalho de Melo)
>
> . Consider header files outside perf directory in tags target (Sebastian Andrzej Siewior)
>
> . Allow overriding sysfs and proc finding with env var (Cody P Schafer)
>
> . Fix "==" into "=" in ui_browser__warning assignment (zhangdianfang)
>
> . Factor elide bool handling in sort code (Jiri Olsa)
>
> . Fix poll return value propagation (Jiri Olsa)
>
> . Fix 'make help' message error (Jianyu Zhan)
>
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (2):
> perf trace: Warn the user when not available
> perf tools: Add warning when disabling perl scripting support due to missing devel files
>
> Cody P Schafer (1):
> perf tools: Allow overriding sysfs and proc finding with env var
>
> Jianyu Zhan (1):
> perf tools: Fix 'make help' message error
>
> Jiri Olsa (3):
> perf tools: Remove elide setup for SORT_MODE__MEMORY mode
> perf tools: Move elide bool into perf_hpp_fmt struct
> perf record: Fix poll return value propagation
>
> Sebastian Andrzej Siewior (1):
> perf tools: Consider header files outside perf directory in tags target
>
> zhangdianfang (1):
> perf tools: Fix "==" into "=" in ui_browser__warning assignment
>
> tools/lib/api/fs/fs.c | 43 ++++++++++++++++-
> tools/perf/Makefile.perf | 13 ++++--
> tools/perf/builtin-record.c | 6 ++-
> tools/perf/config/Makefile | 3 +-
> tools/perf/perf.c | 8 +++-
> tools/perf/ui/browser.c | 2 +-
> tools/perf/ui/browsers/hists.c | 8 ++--
> tools/perf/util/hist.h | 8 +++-
> tools/perf/util/sort.c | 103 ++++++++++++++++++++++-------------------
> tools/perf/util/sort.h | 2 +-
> 10 files changed, 132 insertions(+), 64 deletions(-)
Pulled, thanks a lot Jiri!
Ingo
^ permalink raw reply [flat|nested] 42+ messages in thread
* [GIT PULL 0/9] perf/core improvements and fixes
@ 2014-05-28 13:20 Jiri Olsa
0 siblings, 0 replies; 42+ messages in thread
From: Jiri Olsa @ 2014-05-28 13:20 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Adrian Hunter, Arnaldo Carvalho de Melo,
Cody P Schafer, David Ahern, Don Zickus, Frederic Weisbecker,
Javi Merino, Jiri Olsa, Mike Galbraith, Namhyung Kim,
Paul Mackerras, Peter Zijlstra, Sebastian Andrzej Siewior,
Stephane Eranian, Steven Rostedt, Sukadev Bhattiprolu
hi Ingo,
please consider pulling
thanks,
jirka
The following changes since commit e450f90e8c7d0bf70519223c1b848446ae63f313:
Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf into perf/core (2014-05-22 11:37:40 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git tags/perf-core-for-mingo
for you to fetch changes up to 34cfec19bd8496279d283498b97069d9a0f7e130:
tools lib traceevent: Added support for __get_bitmask() macro (2014-05-28 15:08:26 +0200)
----------------------------------------------------------------
perf/core improvements and fixes:
. Added support for __get_bitmask() macro to traceevent library (Steven Rostedt)
. Allow overriding sysfs and proc finding with env var (Cody P Schafer)
. Consider header files outside perf directory in tags target (Sebastian Andrzej Siewior)
. Add warning when disabling perl scripting support due to missing devel files (Arnaldo Carvalho de Melo)
. Warn the user when trace command is not available (Arnaldo Carvalho de Melo)
. Pass protection and flags bits through mmap2 interface (Peter Zijlstra)
. Update perf tool mmap2 interface with protection and flag bits (Don Zickus)
. Re-enable mmap interface (Don Zickus)
. Add mem-mode documentation to report command (Don Zickus)
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (2):
perf trace: Warn the user when not available
perf tools: Add warning when disabling perl scripting support due to missing devel files
Cody P Schafer (1):
perf tools: Allow overriding sysfs and proc finding with env var
Don Zickus (3):
Revert "perf: Disable PERF_RECORD_MMAP2 support"
perf tools: Update mmap2 interface with protection and flag bits
perf report: Add mem-mode documentation to report command
Peter Zijlstra (1):
perf: Pass protection and flags bits through mmap2 interface
Sebastian Andrzej Siewior (1):
perf tools: Consider header files outside perf directory in tags target
Steven Rostedt (Red Hat) (1):
tools lib traceevent: Added support for __get_bitmask() macro
include/uapi/linux/perf_event.h | 1 +
kernel/events/core.c | 37 ++++++-
tools/lib/api/fs/fs.c | 43 +++++++-
tools/lib/traceevent/event-parse.c | 113 +++++++++++++++++++++
tools/lib/traceevent/event-parse.h | 7 ++
tools/perf/Documentation/perf-report.txt | 22 ++++
tools/perf/Makefile.perf | 9 +-
tools/perf/config/Makefile | 1 +
tools/perf/perf.c | 8 +-
tools/perf/tests/dwarf-unwind.c | 2 +-
tools/perf/util/event.c | 59 +++++++----
tools/perf/util/event.h | 2 +
tools/perf/util/evsel.c | 1 +
tools/perf/util/machine.c | 4 +-
tools/perf/util/map.c | 4 +-
tools/perf/util/map.h | 4 +-
.../perf/util/scripting-engines/trace-event-perl.c | 1 +
.../util/scripting-engines/trace-event-python.c | 1 +
18 files changed, 286 insertions(+), 33 deletions(-)
^ permalink raw reply [flat|nested] 42+ messages in thread
* [GIT PULL 0/9] perf/core improvements and fixes
@ 2012-10-26 14:31 Arnaldo Carvalho de Melo
2012-10-26 14:54 ` Ingo Molnar
0 siblings, 1 reply; 42+ messages in thread
From: Arnaldo Carvalho de Melo @ 2012-10-26 14:31 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Andrew Vagin,
Borislav Petkov, David Howells, Frederic Weisbecker, Jiri Olsa,
Namhyung Kim, Paul Mackerras, Peter Zijlstra, Stephane Eranian,
Steven Rostedt, arnaldo.melo, Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit 8f7c1d07ade50dcdea7ec779b277e891f5c8292a:
Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2012-10-26 10:30:49 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo
for you to fetch changes up to 1f16c5754d3a4008c29f3bf67b4f1271313ba385:
perf stat: Add --pre and --post command (2012-10-26 11:22:25 -0200)
----------------------------------------------------------------
perf/core improvements:
. perf inject changes to allow showing where a task sleeps, from Andrew Vagin.
. Makefile improvements from Namhyung Kim.
. Add --pre and --post command hooks in 'stat', from Peter Zijlstra.
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Andrew Vagin (3):
perf inject: Work with files
perf inject: Merge sched_stat_* and sched_switch events
perf inject: Mark a dso if it's used
Namhyung Kim (5):
tools lib traceevent: Do not generate dependency for system header files
perf tools: Cleanup doc related targets
perf tools: Convert invocation of MAKE into SUBDIR
perf tools: Always show CHK message when doing try-cc
perf tools: Fix LIBELF_MMAP checking
Peter Zijlstra (1):
perf stat: Add --pre and --post command
tools/lib/traceevent/Makefile | 2 +-
tools/perf/Documentation/perf-inject.txt | 11 ++
tools/perf/Documentation/perf-stat.txt | 5 +
tools/perf/Makefile | 51 ++------
tools/perf/builtin-inject.c | 189 ++++++++++++++++++++++++++++--
tools/perf/builtin-stat.c | 42 ++++++-
tools/perf/config/utilities.mak | 3 +-
tools/perf/util/build-id.c | 10 +-
tools/perf/util/build-id.h | 4 +
9 files changed, 256 insertions(+), 61 deletions(-)
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [GIT PULL 0/9] perf/core improvements and fixes
2012-10-26 14:31 Arnaldo Carvalho de Melo
@ 2012-10-26 14:54 ` Ingo Molnar
2012-10-26 15:06 ` David Ahern
2012-10-26 17:05 ` Arnaldo Carvalho de Melo
0 siblings, 2 replies; 42+ messages in thread
From: Ingo Molnar @ 2012-10-26 14:54 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Andrew Vagin, Borislav Petkov, David Howells,
Frederic Weisbecker, Jiri Olsa, Namhyung Kim, Paul Mackerras,
Peter Zijlstra, Stephane Eranian, Steven Rostedt, arnaldo.melo,
Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> The following changes since commit 8f7c1d07ade50dcdea7ec779b277e891f5c8292a:
>
> Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2012-10-26 10:30:49 +0200)
>
> are available in the git repository at:
>
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo
>
> for you to fetch changes up to 1f16c5754d3a4008c29f3bf67b4f1271313ba385:
>
> perf stat: Add --pre and --post command (2012-10-26 11:22:25 -0200)
>
> ----------------------------------------------------------------
> perf/core improvements:
>
> . perf inject changes to allow showing where a task sleeps, from Andrew Vagin.
>
> . Makefile improvements from Namhyung Kim.
These are really useful: there used to be a couple of seconds of
wait time at the beginning of every perf build - these are now
nicely explained with the various CHK entries.
>
> . Add --pre and --post command hooks in 'stat', from Peter Zijlstra.
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Andrew Vagin (3):
> perf inject: Work with files
> perf inject: Merge sched_stat_* and sched_switch events
> perf inject: Mark a dso if it's used
>
> Namhyung Kim (5):
> tools lib traceevent: Do not generate dependency for system header files
> perf tools: Cleanup doc related targets
> perf tools: Convert invocation of MAKE into SUBDIR
> perf tools: Always show CHK message when doing try-cc
> perf tools: Fix LIBELF_MMAP checking
>
> Peter Zijlstra (1):
> perf stat: Add --pre and --post command
>
> tools/lib/traceevent/Makefile | 2 +-
> tools/perf/Documentation/perf-inject.txt | 11 ++
> tools/perf/Documentation/perf-stat.txt | 5 +
> tools/perf/Makefile | 51 ++------
> tools/perf/builtin-inject.c | 189 ++++++++++++++++++++++++++++--
> tools/perf/builtin-stat.c | 42 ++++++-
> tools/perf/config/utilities.mak | 3 +-
> tools/perf/util/build-id.c | 10 +-
> tools/perf/util/build-id.h | 4 +
> 9 files changed, 256 insertions(+), 61 deletions(-)
Pulled, thanks Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [GIT PULL 0/9] perf/core improvements and fixes
2012-10-26 14:54 ` Ingo Molnar
@ 2012-10-26 15:06 ` David Ahern
2012-10-26 15:31 ` Namhyung Kim
2012-10-26 17:05 ` Arnaldo Carvalho de Melo
1 sibling, 1 reply; 42+ messages in thread
From: David Ahern @ 2012-10-26 15:06 UTC (permalink / raw)
To: Ingo Molnar
Cc: Arnaldo Carvalho de Melo, linux-kernel, Andrew Vagin,
Borislav Petkov, David Howells, Frederic Weisbecker, Jiri Olsa,
Namhyung Kim, Paul Mackerras, Peter Zijlstra, Stephane Eranian,
Steven Rostedt, arnaldo.melo, Arnaldo Carvalho de Melo
On 10/26/12 8:54 AM, Ingo Molnar wrote:
>> perf/core improvements:
>>
>> . perf inject changes to allow showing where a task sleeps, from Andrew Vagin.
>>
>> . Makefile improvements from Namhyung Kim.
>
> These are really useful: there used to be a couple of seconds of
> wait time at the beginning of every perf build - these are now
> nicely explained with the various CHK entries.
PERF-VERSION-GEN and specifically the git commands are the cause of more
delay than the config checks, especially when doing the build in a VM
with the kernel source on an NFS mount.
David
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [GIT PULL 0/9] perf/core improvements and fixes
2012-10-26 15:06 ` David Ahern
@ 2012-10-26 15:31 ` Namhyung Kim
2012-10-26 15:34 ` Borislav Petkov
2012-10-27 17:12 ` stephane eranian
0 siblings, 2 replies; 42+ messages in thread
From: Namhyung Kim @ 2012-10-26 15:31 UTC (permalink / raw)
To: David Ahern
Cc: Ingo Molnar, Arnaldo Carvalho de Melo, linux-kernel,
Andrew Vagin, Borislav Petkov, David Howells,
Frederic Weisbecker, Jiri Olsa, Paul Mackerras, Peter Zijlstra,
Stephane Eranian, Steven Rostedt, arnaldo.melo,
Arnaldo Carvalho de Melo
2012-10-26 (금), 09:06 -0600, David Ahern:
> On 10/26/12 8:54 AM, Ingo Molnar wrote:
> >> perf/core improvements:
> >>
> >> . perf inject changes to allow showing where a task sleeps, from Andrew Vagin.
> >>
> >> . Makefile improvements from Namhyung Kim.
> >
> > These are really useful: there used to be a couple of seconds of
> > wait time at the beginning of every perf build - these are now
> > nicely explained with the various CHK entries.
Kudos to Jiri who did the real work!
>
> PERF-VERSION-GEN and specifically the git commands are the cause of more
> delay than the config checks, especially when doing the build in a VM
> with the kernel source on an NFS mount.
And I see a strange delay when compiling builtin-sched.o. After
building perf tools, I deleted builtin-{sched,test,script}.o to rebuild
the only since they are largest ones.
namhyung@leonhard:perf$ ls -lS *.c | head -3
-rw-r--r-- 1 namhyung namhyung 45522 2012-10-27 00:20 builtin-sched.c
-rw-r--r-- 1 namhyung namhyung 36372 2012-10-27 00:20 builtin-test.c
-rw-r--r-- 1 namhyung namhyung 35555 2012-10-27 00:20 builtin-script.c
namhyung@leonhard:perf$ rm builtin-{sched,test,script}.o
And then building each file with time command shows this:
namhyung@leonhard:perf$ time make builtin-script.o &> /dev/null
real 0m4.577s
user 0m2.755s
sys 0m1.655s
namhyung@leonhard:perf$ time make builtin-test.o &> /dev/null
real 0m4.486s
user 0m2.707s
sys 0m1.658s
namhyung@leonhard:perf$ time make builtin-sched.o &> /dev/null
real 0m16.936s
user 0m15.157s
sys 0m1.635s
You can see it easily when building perf without -j option. But I have
no idea why it takes so long..
Thanks,
Namhyung
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [GIT PULL 0/9] perf/core improvements and fixes
2012-10-26 15:31 ` Namhyung Kim
@ 2012-10-26 15:34 ` Borislav Petkov
2012-10-26 16:31 ` Arnaldo Carvalho de Melo
2012-10-27 17:12 ` stephane eranian
1 sibling, 1 reply; 42+ messages in thread
From: Borislav Petkov @ 2012-10-26 15:34 UTC (permalink / raw)
To: Namhyung Kim
Cc: David Ahern, Ingo Molnar, Arnaldo Carvalho de Melo, linux-kernel,
Andrew Vagin, Borislav Petkov, David Howells,
Frederic Weisbecker, Jiri Olsa, Paul Mackerras, Peter Zijlstra,
Stephane Eranian, Steven Rostedt, arnaldo.melo,
Arnaldo Carvalho de Melo
On Sat, Oct 27, 2012 at 12:31:42AM +0900, Namhyung Kim wrote:
> And I see a strange delay when compiling builtin-sched.o. After
> building perf tools, I deleted builtin-{sched,test,script}.o to rebuild
> the only since they are largest ones.
>
> namhyung@leonhard:perf$ ls -lS *.c | head -3
> -rw-r--r-- 1 namhyung namhyung 45522 2012-10-27 00:20 builtin-sched.c
> -rw-r--r-- 1 namhyung namhyung 36372 2012-10-27 00:20 builtin-test.c
> -rw-r--r-- 1 namhyung namhyung 35555 2012-10-27 00:20 builtin-script.c
>
> namhyung@leonhard:perf$ rm builtin-{sched,test,script}.o
>
>
> And then building each file with time command shows this:
>
> namhyung@leonhard:perf$ time make builtin-script.o &> /dev/null
>
> real 0m4.577s
> user 0m2.755s
> sys 0m1.655s
>
> namhyung@leonhard:perf$ time make builtin-test.o &> /dev/null
>
> real 0m4.486s
> user 0m2.707s
> sys 0m1.658s
>
> namhyung@leonhard:perf$ time make builtin-sched.o &> /dev/null
>
> real 0m16.936s
> user 0m15.157s
> sys 0m1.635s
>
> You can see it easily when building perf without -j option. But I have
> no idea why it takes so long..
Well, you can trace that workload with perf itself, no, and see the
hotspots.
:-)
--
Regards/Gruss,
Boris.
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [GIT PULL 0/9] perf/core improvements and fixes
2012-10-26 15:34 ` Borislav Petkov
@ 2012-10-26 16:31 ` Arnaldo Carvalho de Melo
2012-10-26 17:20 ` Borislav Petkov
0 siblings, 1 reply; 42+ messages in thread
From: Arnaldo Carvalho de Melo @ 2012-10-26 16:31 UTC (permalink / raw)
To: Borislav Petkov, Namhyung Kim, David Ahern, Ingo Molnar,
linux-kernel, Andrew Vagin, Borislav Petkov, David Howells,
Frederic Weisbecker, Jiri Olsa, Paul Mackerras, Peter Zijlstra,
Stephane Eranian, Steven Rostedt
Em Fri, Oct 26, 2012 at 05:34:32PM +0200, Borislav Petkov escreveu:
> On Sat, Oct 27, 2012 at 12:31:42AM +0900, Namhyung Kim wrote:
> > You can see it easily when building perf without -j option. But I have
> > no idea why it takes so long..
> Well, you can trace that workload with perf itself, no, and see the
> hotspots.
Right, perf'ing perf is a favourite pastime, right?
- Arnaldo
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [GIT PULL 0/9] perf/core improvements and fixes
2012-10-26 16:31 ` Arnaldo Carvalho de Melo
@ 2012-10-26 17:20 ` Borislav Petkov
2012-10-27 9:16 ` Namhyung Kim
0 siblings, 1 reply; 42+ messages in thread
From: Borislav Petkov @ 2012-10-26 17:20 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: Namhyung Kim, David Ahern, Ingo Molnar, linux-kernel,
Andrew Vagin, Borislav Petkov, David Howells,
Frederic Weisbecker, Jiri Olsa, Paul Mackerras, Peter Zijlstra,
Stephane Eranian, Steven Rostedt
On Fri, Oct 26, 2012 at 09:31:15AM -0700, Arnaldo Carvalho de Melo wrote:
> Right, perf'ing perf is a favourite pastime, right?
Sure, can I get "perfing perf" on a T-shirt please?
--
Regards/Gruss,
Boris.
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [GIT PULL 0/9] perf/core improvements and fixes
2012-10-26 17:20 ` Borislav Petkov
@ 2012-10-27 9:16 ` Namhyung Kim
2012-10-27 14:29 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 42+ messages in thread
From: Namhyung Kim @ 2012-10-27 9:16 UTC (permalink / raw)
To: Borislav Petkov
Cc: Arnaldo Carvalho de Melo, David Ahern, Ingo Molnar, linux-kernel,
Andrew Vagin, Borislav Petkov, David Howells,
Frederic Weisbecker, Jiri Olsa, Paul Mackerras, Peter Zijlstra,
Stephane Eranian, Steven Rostedt
2012-10-26 (금), 19:20 +0200, Borislav Petkov:
> On Fri, Oct 26, 2012 at 09:31:15AM -0700, Arnaldo Carvalho de Melo wrote:
> > Right, perf'ing perf is a favourite pastime, right?
>
> Sure, can I get "perfing perf" on a T-shirt please?
Well, guys, this is not perfing perf. It's about perfing make and/or
gcc. Anyway I'd also like to get a "perfing perf" T-shirt. ;)
Thanks,
Namhyung
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [GIT PULL 0/9] perf/core improvements and fixes
2012-10-27 9:16 ` Namhyung Kim
@ 2012-10-27 14:29 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 42+ messages in thread
From: Arnaldo Carvalho de Melo @ 2012-10-27 14:29 UTC (permalink / raw)
To: Namhyung Kim
Cc: Borislav Petkov, David Ahern, Ingo Molnar, linux-kernel,
Andrew Vagin, Borislav Petkov, David Howells,
Frederic Weisbecker, Jiri Olsa, Paul Mackerras, Peter Zijlstra,
Stephane Eranian, Steven Rostedt
Em Sat, Oct 27, 2012 at 06:16:31PM +0900, Namhyung Kim escreveu:
> 2012-10-26 (금), 19:20 +0200, Borislav Petkov:
> > On Fri, Oct 26, 2012 at 09:31:15AM -0700, Arnaldo Carvalho de Melo wrote:
> > > Right, perf'ing perf is a favourite pastime, right?
> >
> > Sure, can I get "perfing perf" on a T-shirt please?
>
> Well, guys, this is not perfing perf. It's about perfing make and/or
> gcc. Anyway I'd also like to get a "perfing perf" T-shirt. ;)
Well, building perf faster will allow us to perf perf faster. ;-)
- Arnaldo
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [GIT PULL 0/9] perf/core improvements and fixes
2012-10-26 15:31 ` Namhyung Kim
2012-10-26 15:34 ` Borislav Petkov
@ 2012-10-27 17:12 ` stephane eranian
1 sibling, 0 replies; 42+ messages in thread
From: stephane eranian @ 2012-10-27 17:12 UTC (permalink / raw)
To: Namhyung Kim
Cc: David Ahern, Ingo Molnar, Arnaldo Carvalho de Melo, linux-kernel,
Andrew Vagin, Borislav Petkov, David Howells,
Frederic Weisbecker, Jiri Olsa, Paul Mackerras, Peter Zijlstra,
Steven Rostedt, arnaldo.melo, Arnaldo Carvalho de Melo
On Fri, Oct 26, 2012 at 5:31 PM, Namhyung Kim <namhyung@kernel.org> wrote:
> 2012-10-26 (금), 09:06 -0600, David Ahern:
>> On 10/26/12 8:54 AM, Ingo Molnar wrote:
>> >> perf/core improvements:
>> >>
>> >> . perf inject changes to allow showing where a task sleeps, from Andrew Vagin.
>> >>
>> >> . Makefile improvements from Namhyung Kim.
>> >
>> > These are really useful: there used to be a couple of seconds of
>> > wait time at the beginning of every perf build - these are now
>> > nicely explained with the various CHK entries.
>
> Kudos to Jiri who did the real work!
>
>>
>> PERF-VERSION-GEN and specifically the git commands are the cause of more
>> delay than the config checks, especially when doing the build in a VM
>> with the kernel source on an NFS mount.
>
> And I see a strange delay when compiling builtin-sched.o. After
> building perf tools, I deleted builtin-{sched,test,script}.o to rebuild
> the only since they are largest ones.
>
Yes, I see that delay on copiling builtin-sched.c on my IVB system.
Don't know why it takes a significant number of seconds to compile
this file. It did not use to be like that a few revisions back. It takes
about 8 seconds on my OC'd IVB (> 4GHz). I don't see much code
in that file.
> namhyung@leonhard:perf$ ls -lS *.c | head -3
> -rw-r--r-- 1 namhyung namhyung 45522 2012-10-27 00:20 builtin-sched.c
> -rw-r--r-- 1 namhyung namhyung 36372 2012-10-27 00:20 builtin-test.c
> -rw-r--r-- 1 namhyung namhyung 35555 2012-10-27 00:20 builtin-script.c
>
> namhyung@leonhard:perf$ rm builtin-{sched,test,script}.o
>
>
> And then building each file with time command shows this:
>
> namhyung@leonhard:perf$ time make builtin-script.o &> /dev/null
>
> real 0m4.577s
> user 0m2.755s
> sys 0m1.655s
>
> namhyung@leonhard:perf$ time make builtin-test.o &> /dev/null
>
> real 0m4.486s
> user 0m2.707s
> sys 0m1.658s
>
> namhyung@leonhard:perf$ time make builtin-sched.o &> /dev/null
>
> real 0m16.936s
> user 0m15.157s
> sys 0m1.635s
>
> You can see it easily when building perf without -j option. But I have
> no idea why it takes so long..
>
> Thanks,
> Namhyung
>
>
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [GIT PULL 0/9] perf/core improvements and fixes
2012-10-26 14:54 ` Ingo Molnar
2012-10-26 15:06 ` David Ahern
@ 2012-10-26 17:05 ` Arnaldo Carvalho de Melo
2012-10-27 13:19 ` Ingo Molnar
1 sibling, 1 reply; 42+ messages in thread
From: Arnaldo Carvalho de Melo @ 2012-10-26 17:05 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Andrew Vagin, Borislav Petkov, David Howells,
Frederic Weisbecker, Jiri Olsa, Namhyung Kim, Paul Mackerras,
Peter Zijlstra, Stephane Eranian, Steven Rostedt
Em Fri, Oct 26, 2012 at 04:54:51PM +0200, Ingo Molnar escreveu:
> * Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
> > . Makefile improvements from Namhyung Kim.
>
> These are really useful: there used to be a couple of seconds of
> wait time at the beginning of every perf build - these are now
> nicely explained with the various CHK entries.
The optimal way, I guess, would be to have some cache file with the
results of such feature tests, that would be created and then used till
the build fails using its findings, which would trigger a new feature
check round, followed by an automatic rebuild.
That would be tricky because we would have to have an automated way of
discovering if the build failed due to missing packages or if it failed
due to some ordinary coding mistake.
- Arnaldo
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [GIT PULL 0/9] perf/core improvements and fixes
2012-10-26 17:05 ` Arnaldo Carvalho de Melo
@ 2012-10-27 13:19 ` Ingo Molnar
2012-10-30 8:18 ` Ingo Molnar
0 siblings, 1 reply; 42+ messages in thread
From: Ingo Molnar @ 2012-10-27 13:19 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Andrew Vagin, Borislav Petkov, David Howells,
Frederic Weisbecker, Jiri Olsa, Namhyung Kim, Paul Mackerras,
Peter Zijlstra, Stephane Eranian, Steven Rostedt
* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
> Em Fri, Oct 26, 2012 at 04:54:51PM +0200, Ingo Molnar escreveu:
> > * Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
> > > . Makefile improvements from Namhyung Kim.
> >
> > These are really useful: there used to be a couple of
> > seconds of wait time at the beginning of every perf build -
> > these are now nicely explained with the various CHK entries.
>
> The optimal way, I guess, would be to have some cache file
> with the results of such feature tests, that would be created
> and then used till the build fails using its findings, which
> would trigger a new feature check round, followed by an
> automatic rebuild.
>
> That would be tricky because we would have to have an
> automated way of discovering if the build failed due to
> missing packages or if it failed due to some ordinary coding
> mistake.
The feature tests aren't a big problem right now - but making it
*visible* is really useful. It also tells us which feature test
fails, etc.
Thanks,
Ingo
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [GIT PULL 0/9] perf/core improvements and fixes
2012-10-27 13:19 ` Ingo Molnar
@ 2012-10-30 8:18 ` Ingo Molnar
2012-10-30 8:21 ` Peter Zijlstra
0 siblings, 1 reply; 42+ messages in thread
From: Ingo Molnar @ 2012-10-30 8:18 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Andrew Vagin, Borislav Petkov, David Howells,
Frederic Weisbecker, Jiri Olsa, Namhyung Kim, Paul Mackerras,
Peter Zijlstra, Stephane Eranian, Steven Rostedt
* Ingo Molnar <mingo@kernel.org> wrote:
>
> * Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
>
> > Em Fri, Oct 26, 2012 at 04:54:51PM +0200, Ingo Molnar escreveu:
> > > * Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
> > > > . Makefile improvements from Namhyung Kim.
> > >
> > > These are really useful: there used to be a couple of
> > > seconds of wait time at the beginning of every perf build -
> > > these are now nicely explained with the various CHK entries.
> >
> > The optimal way, I guess, would be to have some cache file
> > with the results of such feature tests, that would be created
> > and then used till the build fails using its findings, which
> > would trigger a new feature check round, followed by an
> > automatic rebuild.
> >
> > That would be tricky because we would have to have an
> > automated way of discovering if the build failed due to
> > missing packages or if it failed due to some ordinary coding
> > mistake.
>
> The feature tests aren't a big problem right now - but making
> it *visible* is really useful. It also tells us which feature
> test fails, etc.
Btw., there's another thing that would be nice in addition to
simplifying the PERF-VERSION-GEN script: to be able to run the
CHK tests in parallel, like the object file runes.
Right now the CHK tests are serialized and they take several
seconds to build and run. A parallel make rule would reduce
that to about a second I think.
Thanks,
Ingo
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [GIT PULL 0/9] perf/core improvements and fixes
2012-10-30 8:18 ` Ingo Molnar
@ 2012-10-30 8:21 ` Peter Zijlstra
2012-10-30 9:14 ` Ingo Molnar
0 siblings, 1 reply; 42+ messages in thread
From: Peter Zijlstra @ 2012-10-30 8:21 UTC (permalink / raw)
To: Ingo Molnar
Cc: Arnaldo Carvalho de Melo, linux-kernel, Andrew Vagin,
Borislav Petkov, David Howells, Frederic Weisbecker, Jiri Olsa,
Namhyung Kim, Paul Mackerras, Stephane Eranian, Steven Rostedt
On Tue, 2012-10-30 at 09:18 +0100, Ingo Molnar wrote:
> > > The optimal way, I guess, would be to have some cache file
> > > with the results of such feature tests, that would be created
> > > and then used till the build fails using its findings, which
> > > would trigger a new feature check round, followed by an
> > > automatic rebuild.
autoconf!! ;-)
/me runs
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [GIT PULL 0/9] perf/core improvements and fixes
2012-10-30 8:21 ` Peter Zijlstra
@ 2012-10-30 9:14 ` Ingo Molnar
0 siblings, 0 replies; 42+ messages in thread
From: Ingo Molnar @ 2012-10-30 9:14 UTC (permalink / raw)
To: Peter Zijlstra
Cc: Arnaldo Carvalho de Melo, linux-kernel, Andrew Vagin,
Borislav Petkov, David Howells, Frederic Weisbecker, Jiri Olsa,
Namhyung Kim, Paul Mackerras, Stephane Eranian, Steven Rostedt
* Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:
> On Tue, 2012-10-30 at 09:18 +0100, Ingo Molnar wrote:
> > > > The optimal way, I guess, would be to have some cache file
> > > > with the results of such feature tests, that would be created
> > > > and then used till the build fails using its findings, which
> > > > would trigger a new feature check round, followed by an
> > > > automatic rebuild.
I did not write that.
I think making the feature tests parallel would be enough to
speed it all up - caching brings in a new set of problems. The
tests are mostly independent and the feature test makefile rules
could be parallelized like the object file rules.
> autoconf!! ;-)
>
> /me runs
hey, we build perf much faster than autoconf's 'configure'
script finishes running ;-)
Thanks,
Ingo
^ permalink raw reply [flat|nested] 42+ messages in thread
* [GIT PULL 0/9] perf/core improvements and fixes
@ 2012-09-08 20:36 Arnaldo Carvalho de Melo
2012-09-09 8:40 ` Ingo Molnar
0 siblings, 1 reply; 42+ messages in thread
From: Arnaldo Carvalho de Melo @ 2012-09-08 20:36 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, David Ahern,
Irina Tirdea, Irina Tirdea, Namhyung Kim, Namhyung Kim,
Paul Mackerras, Pekka Enberg, Peter Zijlstra, Srikar Dronamraju,
Steven Rostedt
From: Arnaldo Carvalho de Melo <acme@redhat.com>
Hi Ingo,
Please consider pulling,
Thanks,
- Arnaldo
The following changes since commit ef34eb4da3eb62a1511592adf7c76d74faca0b14:
Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2012-09-08 13:26:02 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo
for you to fetch changes up to 6c7f631261064762a8ba1ee34fc2b76d117ef3fa:
perf symbols: Remove BIONIC wrapper around libgen.h (2012-09-08 17:15:16 -0300)
----------------------------------------------------------------
perf/core improvements and fixes
. Don't pass const char pointers to basename, so that we can unconditionally
use libgen.h and thus avoid ifdef BIONIC lines, from David Ahern
. Fix assert/BUG_ON when NDEBUG is defined, from Irina Tirdea.
. Refactor hist formatting so that it can be reused with the GTK browser,
From Namhyung Kim
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
David Ahern (3):
perf annotate: Make a copy of filename for passing to basename
perf probe: Make a copy of exec path for passing to basename
perf symbols: Remove BIONIC wrapper around libgen.h
Irina Tirdea (1):
perf bench: fix assert when NDEBUG is defined
Namhyung Kim (5):
perf hists: Introduce perf_hpp for hist period printing
perf hists: Handle field separator properly
perf hists: Use perf_hpp__format->width to calculate the column widths
perf hists browser: Use perf_hpp__format functions
perf gtk/browser: Use perf_hpp__format functions
tools/perf/Makefile | 2 +
tools/perf/bench/sched-pipe.c | 6 +-
tools/perf/builtin-diff.c | 1 +
tools/perf/ui/browsers/hists.c | 96 ++++++--
tools/perf/ui/gtk/browser.c | 101 +++++++--
tools/perf/ui/gtk/gtk.h | 1 +
tools/perf/ui/gtk/setup.c | 1 +
tools/perf/ui/hist.c | 389 ++++++++++++++++++++++++++++++++
tools/perf/ui/setup.c | 8 +-
tools/perf/ui/stdio/hist.c | 239 ++++----------------
tools/perf/ui/tui/setup.c | 4 +
tools/perf/util/annotate.c | 9 +-
tools/perf/util/hist.c | 33 ---
tools/perf/util/hist.h | 37 +++
tools/perf/util/include/linux/kernel.h | 4 +
tools/perf/util/probe-event.c | 12 +-
tools/perf/util/symbol.h | 2 -
17 files changed, 665 insertions(+), 280 deletions(-)
create mode 100644 tools/perf/ui/hist.c
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [GIT PULL 0/9] perf/core improvements and fixes
2012-09-08 20:36 Arnaldo Carvalho de Melo
@ 2012-09-09 8:40 ` Ingo Molnar
0 siblings, 0 replies; 42+ messages in thread
From: Ingo Molnar @ 2012-09-09 8:40 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Arnaldo Carvalho de Melo, David Ahern,
Irina Tirdea, Irina Tirdea, Namhyung Kim, Namhyung Kim,
Paul Mackerras, Pekka Enberg, Peter Zijlstra, Srikar Dronamraju,
Steven Rostedt
* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
> From: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> Hi Ingo,
>
> Please consider pulling,
>
> Thanks,
>
> - Arnaldo
>
> The following changes since commit ef34eb4da3eb62a1511592adf7c76d74faca0b14:
>
> Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2012-09-08 13:26:02 +0200)
>
> are available in the git repository at:
>
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo
>
> for you to fetch changes up to 6c7f631261064762a8ba1ee34fc2b76d117ef3fa:
>
> perf symbols: Remove BIONIC wrapper around libgen.h (2012-09-08 17:15:16 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes
>
> . Don't pass const char pointers to basename, so that we can unconditionally
> use libgen.h and thus avoid ifdef BIONIC lines, from David Ahern
>
> . Fix assert/BUG_ON when NDEBUG is defined, from Irina Tirdea.
>
> . Refactor hist formatting so that it can be reused with the GTK browser,
> From Namhyung Kim
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> David Ahern (3):
> perf annotate: Make a copy of filename for passing to basename
> perf probe: Make a copy of exec path for passing to basename
> perf symbols: Remove BIONIC wrapper around libgen.h
>
> Irina Tirdea (1):
> perf bench: fix assert when NDEBUG is defined
>
> Namhyung Kim (5):
> perf hists: Introduce perf_hpp for hist period printing
> perf hists: Handle field separator properly
> perf hists: Use perf_hpp__format->width to calculate the column widths
> perf hists browser: Use perf_hpp__format functions
> perf gtk/browser: Use perf_hpp__format functions
>
> tools/perf/Makefile | 2 +
> tools/perf/bench/sched-pipe.c | 6 +-
> tools/perf/builtin-diff.c | 1 +
> tools/perf/ui/browsers/hists.c | 96 ++++++--
> tools/perf/ui/gtk/browser.c | 101 +++++++--
> tools/perf/ui/gtk/gtk.h | 1 +
> tools/perf/ui/gtk/setup.c | 1 +
> tools/perf/ui/hist.c | 389 ++++++++++++++++++++++++++++++++
> tools/perf/ui/setup.c | 8 +-
> tools/perf/ui/stdio/hist.c | 239 ++++----------------
> tools/perf/ui/tui/setup.c | 4 +
> tools/perf/util/annotate.c | 9 +-
> tools/perf/util/hist.c | 33 ---
> tools/perf/util/hist.h | 37 +++
> tools/perf/util/include/linux/kernel.h | 4 +
> tools/perf/util/probe-event.c | 12 +-
> tools/perf/util/symbol.h | 2 -
> 17 files changed, 665 insertions(+), 280 deletions(-)
> create mode 100644 tools/perf/ui/hist.c
Pulled, thanks Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 42+ messages in thread
* [GIT PULL 0/9] perf/core improvements and fixes
@ 2012-01-24 23:07 Arnaldo Carvalho de Melo
2012-01-26 11:16 ` Ingo Molnar
0 siblings, 1 reply; 42+ messages in thread
From: Arnaldo Carvalho de Melo @ 2012-01-24 23:07 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, David Ahern, David Daney,
Frederic Weisbecker, Jan Beulich, Joerg Roedel, Masami Hiramatsu,
Mike Galbraith, Namhyung Kim, Paul Mackerras, Peter Zijlstra,
Srikar Dronamraju, Stephane Eranian, arnaldo.melo
Hi Ingo,
This is a signed tag, please lemme know if everything went well.
The --uid feature works for root, we still need to sort out that
paranoia with some threads owned by a user that prevents 'perf --uid
non-root-user' to work for 'non-root-user'.
http://git.kernel.org/?p=linux/kernel/git/acme/linux.git;a=tag;h=ce9600c4c664ce7f97e8aa5e756b0b4ea5b017c7
looks ok to me, need just to improve on the commit log message, I'll get
used to it :-)
- Arnaldo
The following changes since commit 172d1b0b73256551f100fc00c69e356d047103f5:
perf tools: Fix compile error on x86_64 Ubuntu (2012-01-08 13:34:55 -0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux perf-core-for-mingo
for you to fetch changes up to f8f4b2872295dca88339ec0c403b2217b1197353:
perf tools: Fix strlen() bug in perf_event__synthesize_event_type() (2012-01-24 20:31:34 -0200)
----------------------------------------------------------------
perf/core improvements and fixes
----------------------------------------------------------------
Arnaldo Carvalho de Melo (2):
perf tools: Add fprintf methods for thread_map and cpu_map classes
perf tools: Introduce per user view
David Daney (1):
perf tools: Fix broken build by defining _GNU_SOURCE in Makefile
Jan Beulich (4):
perf bench: Make "default" memcpy() selection actually use glibc's implementation
perf bench: Also allow measuring alternative memcpy implementations
perf bench: Also allow measuring memset()
perf bench: Allow passing an iteration count to "bench mem mem{cpy,set}"
Srikar Dronamraju (1):
perf probe: Usability fixes
Stephane Eranian (1):
perf tools: Fix strlen() bug in perf_event__synthesize_event_type()
tools/perf/Documentation/perf-record.txt | 4 +
tools/perf/Documentation/perf-top.txt | 4 +
tools/perf/Makefile | 11 +-
tools/perf/bench/bench.h | 1 +
tools/perf/bench/mem-memcpy-x86-64-asm-def.h | 8 +
tools/perf/bench/mem-memcpy-x86-64-asm.S | 6 +-
tools/perf/bench/mem-memcpy.c | 11 +-
tools/perf/bench/mem-memset-arch.h | 12 +
tools/perf/bench/mem-memset-x86-64-asm-def.h | 12 +
tools/perf/bench/mem-memset-x86-64-asm.S | 6 +
tools/perf/bench/mem-memset.c | 298 ++++++++++++++++++++++++++
tools/perf/builtin-bench.c | 3 +
tools/perf/builtin-probe.c | 2 -
tools/perf/builtin-record.c | 12 +-
tools/perf/builtin-stat.c | 2 +-
tools/perf/builtin-test.c | 8 +-
tools/perf/builtin-top.c | 22 ++-
tools/perf/perf.h | 1 +
tools/perf/util/cpumap.c | 11 +
tools/perf/util/cpumap.h | 4 +
tools/perf/util/evlist.c | 6 +-
tools/perf/util/evlist.h | 2 +-
tools/perf/util/header.c | 2 +-
tools/perf/util/hist.h | 1 +
tools/perf/util/include/asm/dwarf2.h | 4 +-
tools/perf/util/probe-event.c | 8 +-
tools/perf/util/python.c | 10 +-
tools/perf/util/symbol.c | 1 -
tools/perf/util/thread_map.c | 109 +++++++++-
tools/perf/util/thread_map.h | 7 +-
tools/perf/util/top.c | 3 +
tools/perf/util/top.h | 2 +
tools/perf/util/trace-event-parse.c | 3 +-
tools/perf/util/ui/browsers/hists.c | 5 +-
tools/perf/util/ui/helpline.c | 1 -
tools/perf/util/usage.c | 39 ++++
tools/perf/util/util.h | 3 +-
37 files changed, 597 insertions(+), 47 deletions(-)
create mode 100644 tools/perf/bench/mem-memset-arch.h
create mode 100644 tools/perf/bench/mem-memset-x86-64-asm-def.h
create mode 100644 tools/perf/bench/mem-memset-x86-64-asm.S
create mode 100644 tools/perf/bench/mem-memset.c
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [GIT PULL 0/9] perf/core improvements and fixes
2012-01-24 23:07 Arnaldo Carvalho de Melo
@ 2012-01-26 11:16 ` Ingo Molnar
0 siblings, 0 replies; 42+ messages in thread
From: Ingo Molnar @ 2012-01-26 11:16 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, David Ahern, David Daney, Frederic Weisbecker,
Jan Beulich, Joerg Roedel, Masami Hiramatsu, Mike Galbraith,
Namhyung Kim, Paul Mackerras, Peter Zijlstra, Srikar Dronamraju,
Stephane Eranian, arnaldo.melo
* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
> Hi Ingo,
>
> This is a signed tag, please lemme know if everything went well.
>
> The --uid feature works for root, we still need to
> sort out that paranoia with some threads owned by a user that
> prevents 'perf --uid non-root-user' to work for
> 'non-root-user'.
Just wondering what detail causes that failure - the whole point
of --uid mingo would be to enable nonprivileged users to do
'session wide' profiling, *especially* if paranoia is high.
So what does --uid do which perf record --pid 1234 wouldnt
already do? By all means --uid ought to be a fancy way of doing
a whole bunch of perf record --pid 1234 profiling sessions, at
once.
[ Btw, we should probably alias --user to --uid as well, as that
might be the intuitive thing people would typically use? ]
> http://git.kernel.org/?p=linux/kernel/git/acme/linux.git;a=tag;h=ce9600c4c664ce7f97e8aa5e756b0b4ea5b017c7
> looks ok to me, need just to improve on the commit log message, I'll get
> used to it :-)
>
> - Arnaldo
>
> The following changes since commit 172d1b0b73256551f100fc00c69e356d047103f5:
>
> perf tools: Fix compile error on x86_64 Ubuntu (2012-01-08 13:34:55 -0200)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux perf-core-for-mingo
>
> for you to fetch changes up to f8f4b2872295dca88339ec0c403b2217b1197353:
>
> perf tools: Fix strlen() bug in perf_event__synthesize_event_type() (2012-01-24 20:31:34 -0200)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes
>
> ----------------------------------------------------------------
Anyway, pulled, thanks a lot Arnaldo!
One detail: don't we want some of these fixes cherry-picked into
perf/urgent as well?
Thanks,
Ingo
^ permalink raw reply [flat|nested] 42+ messages in thread
end of thread, other threads:[~2017-04-01 10:44 UTC | newest]
Thread overview: 42+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-11 14:22 [GIT PULL 0/9] perf/core improvements and fixes Arnaldo Carvalho de Melo
2015-12-11 14:22 ` [PATCH 1/9] perf top: Do not convert address for perf_top__record_precise_ip() Arnaldo Carvalho de Melo
2015-12-11 14:22 ` [PATCH 2/9] perf top: Access hists->lock only if needed Arnaldo Carvalho de Melo
2015-12-11 14:22 ` [PATCH 3/9] perf top: Fix annotation on --stdio Arnaldo Carvalho de Melo
2015-12-11 14:22 ` [PATCH 4/9] perf top: Cleanup condition in perf_top__record_precise_ip() Arnaldo Carvalho de Melo
2015-12-11 14:22 ` [PATCH 5/9] tools lib bpf: Check return value of strdup when reading map names Arnaldo Carvalho de Melo
2015-12-11 14:22 ` [PATCH 6/9] tools lib bpf: Fetch map names from correct strtab Arnaldo Carvalho de Melo
2015-12-11 14:22 ` [PATCH 7/9] perf data: Add u32_hex data type Arnaldo Carvalho de Melo
2015-12-11 14:22 ` [PATCH 8/9] perf script: Add support for PERF_TYPE_BREAKPOINT Arnaldo Carvalho de Melo
2015-12-11 14:22 ` [PATCH 9/9] perf tools: Clear struct machine during machine__init() Arnaldo Carvalho de Melo
2015-12-14 8:32 ` [GIT PULL 0/9] perf/core improvements and fixes Ingo Molnar
-- strict thread matches above, loose matches on Subject: below --
2017-04-01 2:10 Arnaldo Carvalho de Melo
2017-04-01 10:44 ` Ingo Molnar
2015-09-23 1:57 Arnaldo Carvalho de Melo
2015-09-23 7:45 ` Ingo Molnar
2015-08-21 16:10 Arnaldo Carvalho de Melo
2015-08-22 6:47 ` Ingo Molnar
2015-08-10 20:56 Arnaldo Carvalho de Melo
2015-08-12 10:18 ` Ingo Molnar
2014-06-19 16:38 Jiri Olsa
2014-06-03 20:36 Jiri Olsa
2014-06-05 8:45 ` Ingo Molnar
2014-05-28 13:20 Jiri Olsa
2012-10-26 14:31 Arnaldo Carvalho de Melo
2012-10-26 14:54 ` Ingo Molnar
2012-10-26 15:06 ` David Ahern
2012-10-26 15:31 ` Namhyung Kim
2012-10-26 15:34 ` Borislav Petkov
2012-10-26 16:31 ` Arnaldo Carvalho de Melo
2012-10-26 17:20 ` Borislav Petkov
2012-10-27 9:16 ` Namhyung Kim
2012-10-27 14:29 ` Arnaldo Carvalho de Melo
2012-10-27 17:12 ` stephane eranian
2012-10-26 17:05 ` Arnaldo Carvalho de Melo
2012-10-27 13:19 ` Ingo Molnar
2012-10-30 8:18 ` Ingo Molnar
2012-10-30 8:21 ` Peter Zijlstra
2012-10-30 9:14 ` Ingo Molnar
2012-09-08 20:36 Arnaldo Carvalho de Melo
2012-09-09 8:40 ` Ingo Molnar
2012-01-24 23:07 Arnaldo Carvalho de Melo
2012-01-26 11:16 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).