From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Andi Kleen <andi@firstfloor.org>,
jolsa@kernel.org, mingo@kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH] perf, tools: Disable branch flags/cycles for --callgraph lbr
Date: Mon, 14 Dec 2015 12:12:49 -0300 [thread overview]
Message-ID: <20151214151249.GG6843@kernel.org> (raw)
In-Reply-To: <20151214095538.GB27640@krava.brq.redhat.com>
Em Mon, Dec 14, 2015 at 10:55:38AM +0100, Jiri Olsa escreveu:
> On Fri, Dec 11, 2015 at 04:12:24PM -0800, Andi Kleen wrote:
> > From: Andi Kleen <ak@linux.intel.com>
> >
> > [The kernel patch needed for this is in tip now
> > (b16a5b52eb9 perf/x86: Add option to disable ...)
> > So this user tools patch to make use of it should be merged now]
> >
> > Automatically disable collecting branch flags and cycles with
> > --call-graph lbr. This allows avoiding a bunch of extra MSR
> > reads in the PMI on Skylake.
> >
> > When the kernel doesn't support the new flags they are automatically
> > cleared in the fallback code.
> >
> > v2: Switch to use branch_sample_type instead of sample_type.
> > Adjust description.
> > Fix the fallback logic.
> > Signed-off-by: Andi Kleen <ak@linux.intel.com>
>
> Acked-by: Jiri Olsa <jolsa@kernel.org>
Thanks, applied to perf/core.
- Arnaldo
next prev parent reply other threads:[~2015-12-14 15:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-12 0:12 [PATCH] perf, tools: Disable branch flags/cycles for --callgraph lbr Andi Kleen
2015-12-14 9:55 ` Jiri Olsa
2015-12-14 15:12 ` Arnaldo Carvalho de Melo [this message]
2015-12-18 8:46 ` [tip:perf/core] perf evsel: Disable branch flags/ cycles " tip-bot for Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151214151249.GG6843@kernel.org \
--to=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).