* [PATCH] dmaengine: edma: Add probe callback to edma_tptc_driver
@ 2015-12-16 13:19 Peter Ujfalusi
2015-12-18 5:33 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Peter Ujfalusi @ 2015-12-16 13:19 UTC (permalink / raw)
To: vinod.koul, nsekhar
Cc: linux-arm-kernel, linux-kernel, linux-omap, dmaengine, tony, t-kristo
Due to changes in device and platform code drivers w/o probe will fail to
load. This means that the devices for eDMA TPTCs are goign to be without
driver and omap hwmod code will turn them off after the kernel finished
loading:
[ 3.015900] platform 49800000.tptc: omap_device_late_idle: enabled but no driver. Idling
[ 3.024671] platform 49a00000.tptc: omap_device_late_idle: enabled but no driver. Idling
This will prevent eDMA to work since the TPTCs are not enabled.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Fixes: 34635b1accb9 ("dmaengine: edma: Add dummy driver skeleton for edma3-tptc")
---
Hi,
The issue surfaced with next-20151216, next-20151214 was worked fine.
Regards,
Peter
drivers/dma/edma.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c
index 2e8acde6b134..50584015e046 100644
--- a/drivers/dma/edma.c
+++ b/drivers/dma/edma.c
@@ -2425,7 +2425,13 @@ static struct platform_driver edma_driver = {
},
};
+static int edma_tptc_probe(struct platform_device *pdev)
+{
+ return 0;
+}
+
static struct platform_driver edma_tptc_driver = {
+ .probe = edma_tptc_probe,
.driver = {
.name = "edma3-tptc",
.of_match_table = edma_tptc_of_ids,
--
2.6.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dmaengine: edma: Add probe callback to edma_tptc_driver
2015-12-16 13:19 [PATCH] dmaengine: edma: Add probe callback to edma_tptc_driver Peter Ujfalusi
@ 2015-12-18 5:33 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2015-12-18 5:33 UTC (permalink / raw)
To: Peter Ujfalusi
Cc: nsekhar, linux-arm-kernel, linux-kernel, linux-omap, dmaengine,
tony, t-kristo
On Wed, Dec 16, 2015 at 03:19:05PM +0200, Peter Ujfalusi wrote:
> Due to changes in device and platform code drivers w/o probe will fail to
> load. This means that the devices for eDMA TPTCs are goign to be without
> driver and omap hwmod code will turn them off after the kernel finished
> loading:
> [ 3.015900] platform 49800000.tptc: omap_device_late_idle: enabled but no driver. Idling
> [ 3.024671] platform 49a00000.tptc: omap_device_late_idle: enabled but no driver. Idling
>
> This will prevent eDMA to work since the TPTCs are not enabled.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-12-18 5:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-16 13:19 [PATCH] dmaengine: edma: Add probe callback to edma_tptc_driver Peter Ujfalusi
2015-12-18 5:33 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).