[PATCH 1/2] devicetree: sound: add binding for WM8974 codec

[PATCH 1/2] devicetree: sound: add binding for WM8974 codec

[Mans Rullgard]

This adds a binding for the Wolfson WM8974 mono audio codec.

Signed-off-by: Mans Rullgard <mans@mansr.com>
---
The Linux driver for this device currently only supports I2C, but SPI
could easily be added if necessary, and DT bindings are supposed to be
generic.
---
 Documentation/devicetree/bindings/sound/wlf,wm8974.txt | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/sound/wlf,wm8974.txt

diff --git a/Documentation/devicetree/bindings/sound/wlf,wm8974.txt b/Documentation/devicetree/bindings/sound/wlf,wm8974.txt
new file mode 100644
index 0000000..01d3a7c
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/wlf,wm8974.txt
@@ -0,0 +1,15 @@
+WM8974 audio CODEC
+
+This device supports both I2C and SPI (configured with pin strapping
+on the board).
+
+Required properties:
+  - compatible: "wlf,wm8974"
+  - reg: the I2C address or SPI chip select number of the device
+
+Examples:
+
+codec: wm8974@1a {
+	compatible = "wlf,wm8974";
+	reg = <0x1a>;
+};
-- 
2.6.3

[PATCH 2/2] ASoC: wm8974: add devicetree support

[Mans Rullgard]

This adds devicetree support to the wm8974 codec driver.
With a DT-based kernel, there is no board-specific setting
to select the driver so allow it to be manually chosen.

Signed-off-by: Mans Rullgard <mans@mansr.com>
---
 sound/soc/codecs/Kconfig  | 3 ++-
 sound/soc/codecs/wm8974.c | 7 +++++++
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
index cfdafc4..e36b14c 100644
--- a/sound/soc/codecs/Kconfig
+++ b/sound/soc/codecs/Kconfig
@@ -838,7 +838,8 @@ config SND_SOC_WM8971
 	tristate
 
 config SND_SOC_WM8974
-	tristate
+	tristate "Wolfson Microelectronics WM8974 codec"
+	depends on I2C
 
 config SND_SOC_WM8978
 	tristate "Wolfson Microelectronics WM8978 codec"
diff --git a/sound/soc/codecs/wm8974.c b/sound/soc/codecs/wm8974.c
index 4c29bd2..c284c7b 100644
--- a/sound/soc/codecs/wm8974.c
+++ b/sound/soc/codecs/wm8974.c
@@ -632,9 +632,16 @@ static const struct i2c_device_id wm8974_i2c_id[] = {
 };
 MODULE_DEVICE_TABLE(i2c, wm8974_i2c_id);
 
+static const struct of_device_id wm8974_of_match[] = {
+       { .compatible = "wlf,wm8974", },
+       { }
+};
+MODULE_DEVICE_TABLE(of, wm8974_of_match);
+
 static struct i2c_driver wm8974_i2c_driver = {
 	.driver = {
 		.name = "wm8974",
+		.of_match_table = wm8974_of_match,
 	},
 	.probe =    wm8974_i2c_probe,
 	.remove =   wm8974_i2c_remove,
-- 
2.6.3

Re: [alsa-devel] [PATCH 2/2] ASoC: wm8974: add devicetree support

[Charles Keepax]

On Wed, Dec 16, 2015 at 01:02:55PM +0000, Mans Rullgard wrote:
> This adds devicetree support to the wm8974 codec driver.
> With a DT-based kernel, there is no board-specific setting
> to select the driver so allow it to be manually chosen.
> 
> Signed-off-by: Mans Rullgard <mans@mansr.com>
> ---

Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>

Thanks,
Charles

Re: [PATCH 2/2] ASoC: wm8974: add devicetree support

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 265 bytes --]

On Wed, Dec 16, 2015 at 01:02:55PM +0000, Mans Rullgard wrote:
> This adds devicetree support to the wm8974 codec driver.
> With a DT-based kernel, there is no board-specific setting
> to select the driver so allow it to be manually chosen.

I'm missing patch 1/1.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: [PATCH 1/2] devicetree: sound: add binding for WM8974 codec

[Måns Rullgård]

Mark,

This is the 1/1 you were missing.

Am I the only one who is annoyed by scripts/get_maintainer.pl not
returning all the addresses it should in cases like this?  Is there some
trick I'm missing?

Mans Rullgard <mans@mansr.com> writes:

> This adds a binding for the Wolfson WM8974 mono audio codec.
>
> Signed-off-by: Mans Rullgard <mans@mansr.com>
> ---
> The Linux driver for this device currently only supports I2C, but SPI
> could easily be added if necessary, and DT bindings are supposed to be
> generic.
> ---
>  Documentation/devicetree/bindings/sound/wlf,wm8974.txt | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/sound/wlf,wm8974.txt
>
> diff --git a/Documentation/devicetree/bindings/sound/wlf,wm8974.txt b/Documentation/devicetree/bindings/sound/wlf,wm8974.txt
> new file mode 100644
> index 0000000..01d3a7c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/wlf,wm8974.txt
> @@ -0,0 +1,15 @@
> +WM8974 audio CODEC
> +
> +This device supports both I2C and SPI (configured with pin strapping
> +on the board).
> +
> +Required properties:
> +  - compatible: "wlf,wm8974"
> +  - reg: the I2C address or SPI chip select number of the device
> +
> +Examples:
> +
> +codec: wm8974@1a {
> +	compatible = "wlf,wm8974";
> +	reg = <0x1a>;
> +};
> -- 
> 2.6.3
>

-- 
Måns Rullgård

Re: [PATCH 1/2] devicetree: sound: add binding for WM8974 codec

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 645 bytes --]

On Wed, Dec 16, 2015 at 01:31:30PM +0000, Måns Rullgård wrote:

> This is the 1/1 you were missing.

I need the patch in a form I can apply.

> Am I the only one who is annoyed by scripts/get_maintainer.pl not
> returning all the addresses it should in cases like this?  Is there some
> trick I'm missing?

You can't blindly rely on get_maintainers, it's prone to both false
positives (CCing too many people, especially if you enable git matching
when it often starts spamming people who are just doing global cleanups)
and false negatives (if you don't enable git matching and it misses
people who care about a specific driver).

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: [PATCH 1/2] devicetree: sound: add binding for WM8974 codec

[Måns Rullgård]

Mark Brown <broonie@kernel.org> writes:

> On Wed, Dec 16, 2015 at 01:31:30PM +0000, Måns Rullgård wrote:
>
>> This is the 1/1 you were missing.
>
> I need the patch in a form I can apply.

I assumed your email client had some way of displaying the message I
replied to.  Guess I was wrong.

>> Am I the only one who is annoyed by scripts/get_maintainer.pl not
>> returning all the addresses it should in cases like this?  Is there some
>> trick I'm missing?
>
> You can't blindly rely on get_maintainers, it's prone to both false
> positives (CCing too many people, especially if you enable git matching
> when it often starts spamming people who are just doing global cleanups)
> and false negatives (if you don't enable git matching and it misses
> people who care about a specific driver).

So in short, I'm supposed to magically divine who wants to see what.

-- 
Måns Rullgård

[PATCH] devicetree: sound: add binding for WM8974 codec

[Mans Rullgard]

This adds a binding for the Wolfson WM8974 mono audio codec.

Signed-off-by: Mans Rullgard <mans@mansr.com>
---
Sending this patch again, this time including Mark Brown.
---
 Documentation/devicetree/bindings/sound/wlf,wm8974.txt | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/sound/wlf,wm8974.txt

diff --git a/Documentation/devicetree/bindings/sound/wlf,wm8974.txt b/Documentation/devicetree/bindings/sound/wlf,wm8974.txt
new file mode 100644
index 0000000..01d3a7c
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/wlf,wm8974.txt
@@ -0,0 +1,15 @@
+WM8974 audio CODEC
+
+This device supports both I2C and SPI (configured with pin strapping
+on the board).
+
+Required properties:
+  - compatible: "wlf,wm8974"
+  - reg: the I2C address or SPI chip select number of the device
+
+Examples:
+
+codec: wm8974@1a {
+	compatible = "wlf,wm8974";
+	reg = <0x1a>;
+};
-- 
2.6.3

Re: [PATCH 1/2] devicetree: sound: add binding for WM8974 codec

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 1500 bytes --]

On Wed, Dec 16, 2015 at 01:54:20PM +0000, Måns Rullgård wrote:
> Mark Brown <broonie@kernel.org> writes:

> > I need the patch in a form I can apply.

> I assumed your email client had some way of displaying the message I
> replied to.  Guess I was wrong.

My workflow for reviewing and applying patches is based around my inbox,
as are most review flows in the kernel - things that aren't in my inbox
*might* get looked at but it's unreliable.

> > You can't blindly rely on get_maintainers, it's prone to both false
> > positives (CCing too many people, especially if you enable git matching
> > when it often starts spamming people who are just doing global cleanups)
> > and false negatives (if you don't enable git matching and it misses
> > people who care about a specific driver).

> So in short, I'm supposed to magically divine who wants to see what.

You're supposed to do like SubmittingPatches suggests make a judgement
call based on things like looking at MAINTAINERS and the people that git
shows are reviewing and applying patches or otherwise seem relevant -
it's not really something that can be fully automated (for example, it
might make sense to CC someone who worked on the specific thing you're
changing even if they don't commonly review the file as a whole).

Looking at git history will also help you ensure that the style you're
presenting your changes in (for example things like the subject line)
matches the general style people are using.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: [PATCH] devicetree: sound: add binding for WM8974 codec

[Rob Herring]

On Wed, Dec 16, 2015 at 01:55:13PM +0000, Mans Rullgard wrote:
> This adds a binding for the Wolfson WM8974 mono audio codec.
> 
> Signed-off-by: Mans Rullgard <mans@mansr.com>
> ---
> Sending this patch again, this time including Mark Brown.
> ---
>  Documentation/devicetree/bindings/sound/wlf,wm8974.txt | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/sound/wlf,wm8974.txt

This could go in i2c/trivial-devices.txt if this is it, but standalone 
is fine too.

Acked-by: Rob Herring <robh@kernel.org>

Re: [PATCH 1/2] devicetree: sound: add binding for WM8974 codec

[Rob Herring]

On Wed, Dec 16, 2015 at 01:31:30PM +0000, Måns Rullgård wrote:
> Mark,
> 
> This is the 1/1 you were missing.
> 
> Am I the only one who is annoyed by scripts/get_maintainer.pl not
> returning all the addresses it should in cases like this?  Is there some
> trick I'm missing?

Documentation/devicetree/bindings/sound/ should probably be listed with 
the ALSA maintainer entry.

Rob