* [PATCH] iommu: Update struct iommu_ops comments
@ 2016-01-19 5:28 Magnus Damm
2016-01-29 11:35 ` Joerg Roedel
0 siblings, 1 reply; 2+ messages in thread
From: Magnus Damm @ 2016-01-19 5:28 UTC (permalink / raw)
To: linux-kernel; +Cc: Magnus Damm, jroedel, will.deacon, alex.williamson
From: Magnus Damm <damm+renesas@opensource.se>
Update the comments around struct iommu_ops to match
current state and fix a few typos while at it.
Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
---
Developed on top of linux-next tag next-20160118
include/linux/iommu.h | 16 ++++++++++++----
1 file changed, 12 insertions(+), 4 deletions(-)
--- 0001/include/linux/iommu.h
+++ work/include/linux/iommu.h 2016-01-19 13:51:54.270513000 +0900
@@ -133,8 +133,9 @@ struct iommu_dm_region {
/**
* struct iommu_ops - iommu ops and capabilities
- * @domain_init: init iommu domain
- * @domain_destroy: destroy iommu domain
+ * @capable: check capability
+ * @domain_alloc: allocate iommu domain
+ * @domain_free: free iommu domain
* @attach_dev: attach device to an iommu domain
* @detach_dev: detach device from an iommu domain
* @map: map a physically contiguous memory region to an iommu domain
@@ -144,8 +145,15 @@ struct iommu_dm_region {
* @iova_to_phys: translate iova to physical address
* @add_device: add device to iommu grouping
* @remove_device: remove device from iommu grouping
+ * @device_group: find iommu group for a particular device
* @domain_get_attr: Query domain attributes
* @domain_set_attr: Change domain attributes
+ * @get_dm_regions: Request list of direct mapping requirements for a device
+ * @put_dm_regions: Free list of direct mapping requirements for a device
+ * @domain_window_enable: Configure and enable a particular window for a domain
+ * @domain_window_disable: Disable a particular window for a domain
+ * @domain_set_windows: Set the number of windows for a domain
+ * @domain_get_windows: Return the number of windows for a domain
* @of_xlate: add OF master IDs to iommu grouping
* @pgsize_bitmap: bitmap of supported page sizes
* @priv: per-instance data private to the iommu driver
@@ -182,9 +190,9 @@ struct iommu_ops {
int (*domain_window_enable)(struct iommu_domain *domain, u32 wnd_nr,
phys_addr_t paddr, u64 size, int prot);
void (*domain_window_disable)(struct iommu_domain *domain, u32 wnd_nr);
- /* Set the numer of window per domain */
+ /* Set the number of windows per domain */
int (*domain_set_windows)(struct iommu_domain *domain, u32 w_count);
- /* Get the numer of window per domain */
+ /* Get the number of windows per domain */
u32 (*domain_get_windows)(struct iommu_domain *domain);
#ifdef CONFIG_OF_IOMMU
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] iommu: Update struct iommu_ops comments
2016-01-19 5:28 [PATCH] iommu: Update struct iommu_ops comments Magnus Damm
@ 2016-01-29 11:35 ` Joerg Roedel
0 siblings, 0 replies; 2+ messages in thread
From: Joerg Roedel @ 2016-01-29 11:35 UTC (permalink / raw)
To: Magnus Damm; +Cc: linux-kernel, will.deacon, alex.williamson
On Tue, Jan 19, 2016 at 02:28:48PM +0900, Magnus Damm wrote:
> From: Magnus Damm <damm+renesas@opensource.se>
>
> Update the comments around struct iommu_ops to match
> current state and fix a few typos while at it.
>
> Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-01-29 11:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-19 5:28 [PATCH] iommu: Update struct iommu_ops comments Magnus Damm
2016-01-29 11:35 ` Joerg Roedel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).