linux-next: build warning after merge of the tty tree

linux-next: build warning after merge of the tty tree

[Stephen Rothwell]

Hi Greg,

After merging the tty tree (now in Linus' tree, sorry for not pointing
it out earlier), today's linux-next build (multi_v7_defconfig) produced
this warning:

drivers/tty/serial/amba-pl011.c:190:27: warning: 'vendor_zte' defined but not used [-Wunused-variable]
 static struct vendor_data vendor_zte = {
                           ^

Introduced by commit

  7ec758718920 ("tty: amba-pl011: add support for ZTE UART (EXPERIMENTAL)")

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

Re: linux-next: build warning after merge of the tty tree

[Greg KH]

On Thu, Jan 21, 2016 at 12:56:18PM +1100, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the tty tree (now in Linus' tree, sorry for not pointing
> it out earlier), today's linux-next build (multi_v7_defconfig) produced
> this warning:
> 
> drivers/tty/serial/amba-pl011.c:190:27: warning: 'vendor_zte' defined but not used [-Wunused-variable]
>  static struct vendor_data vendor_zte = {
>                            ^
> 
> Introduced by commit
> 
>   7ec758718920 ("tty: amba-pl011: add support for ZTE UART (EXPERIMENTAL)")

Thanks, Arnd sent me a patch for this earlier today, I'll merge it after
4.5-rc1 is out.

thanks,

greg k-h

linux-next: build warning after merge of the tty tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 369 bytes --]

Hi all,

After merging the tty tree, today's linux-next build (htmldocs) produced
this warning:

drivers/tty/tty_io.c:2271: warning: cannot understand function prototype: 'bool tty_legacy_tiocsti __read_mostly = IS_ENABLED(CONFIG_LEGACY_TIOCSTI); '

Introduced by commit

  83efeeeb3d04 ("tty: Allow TIOCSTI to be disabled")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the tty tree

[Kees Cook]

On Mon, Nov 07, 2022 at 02:34:34PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the tty tree, today's linux-next build (htmldocs) produced
> this warning:
> 
> drivers/tty/tty_io.c:2271: warning: cannot understand function prototype: 'bool tty_legacy_tiocsti __read_mostly = IS_ENABLED(CONFIG_LEGACY_TIOCSTI); '
> 
> Introduced by commit
> 
>   83efeeeb3d04 ("tty: Allow TIOCSTI to be disabled")

Whoops! Thank you for the report. I've sent a fix:
https://lore.kernel.org/lkml/20221107034631.never.637-kees@kernel.org

-Kees

-- 
Kees Cook

linux-next: build warning after merge of the tty tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 312 bytes --]

Hi all,

After merging the tty tree, today's linux-next build (htmldocs) produced
this warning:

MAINTAINERS:29709: WARNING: unknown document: ../driver-api/serial/moxa-smartio

Introduced by commit

  5b437ae9fcbb ("Documentation: tty: move moxa-smartio.rst to tty")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the tty tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 337 bytes --]

Hi all,

After merging the tty tree, today's linux-next build (htmldocs) produced
this warning:

Documentation/driver-api/index.rst:14: WARNING: toctree contains reference to nonexisting document 'driver-api/tty'

Introduced by commit

  b96cd8b05ead ("Documentation: move tty to driver-api")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the tty tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 545 bytes --]

Hi all,

On Tue, 19 Apr 2022 16:33:18 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the tty tree, today's linux-next build (htmldocs) produced
> this warning:
> 
> Documentation/driver-api/index.rst:14: WARNING: toctree contains reference to nonexisting document 'driver-api/tty'
> 
> Introduced by commit
> 
>   b96cd8b05ead ("Documentation: move tty to driver-api")

Also, this:

Documentation/driver-api/tty/index.rst: WARNING: document isn't included in any toctree

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the tty tree

[Jiri Slaby]

On 19. 04. 22, 8:35, Stephen Rothwell wrote:
> Hi all,
> 
> On Tue, 19 Apr 2022 16:33:18 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>
>> After merging the tty tree, today's linux-next build (htmldocs) produced
>> this warning:
>>
>> Documentation/driver-api/index.rst:14: WARNING: toctree contains reference to nonexisting document 'driver-api/tty'
>>
>> Introduced by commit
>>
>>    b96cd8b05ead ("Documentation: move tty to driver-api")
> 
> Also, this:
> 
> Documentation/driver-api/tty/index.rst: WARNING: document isn't included in any toctree

That looks to be the very same issue -- a bad link.

-- 
js
suse labs

Re: linux-next: build warning after merge of the tty tree

[Jiri Slaby]

Hi,

On 19. 04. 22, 8:33, Stephen Rothwell wrote:
> After merging the tty tree, today's linux-next build (htmldocs) produced
> this warning:
> 
> Documentation/driver-api/index.rst:14: WARNING: toctree contains reference to nonexisting document 'driver-api/tty'

Uh, it should be only "tty" after the move, apparently. I will look into 
it closely and will send a fix later today.

> Introduced by commit
> 
>    b96cd8b05ead ("Documentation: move tty to driver-api")

thanks,
-- 
js
suse labs

linux-next: build warning after merge of the tty tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 469 bytes --]

Hi all,

After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:

drivers/tty/serial/mvebu-uart.c: In function 'mvebu_uart_probe':
drivers/tty/serial/mvebu-uart.c:806:6: warning: unused variable 'ret' [-Wunused-variable]
  806 |  int ret, id, irq;
      |      ^~~

Introduced by commit

  b63537020db3 ("serial: mvebu-uart: simplify the return expression of mvebu_uart_probe()")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the tty tree

[miaoqinglang]

在 2020/9/29 14:01, Stephen Rothwell 写道:
> Hi all,
> 
> After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
> 
> drivers/tty/serial/mvebu-uart.c: In function 'mvebu_uart_probe':
> drivers/tty/serial/mvebu-uart.c:806:6: warning: unused variable 'ret' [-Wunused-variable]
>    806 |  int ret, id, irq;
>        |      ^~~
> 
> Introduced by commit
> 
>    b63537020db3 ("serial: mvebu-uart: simplify the return expression of mvebu_uart_probe()")
> 
Hi Greg,

Sorry about the noise for remaining the unused variable 'ret' in commit 
b63537020db3.

Should I send another patch to clean up this warning or send another v2 
patch instead?

Thanks.

Re: linux-next: build warning after merge of the tty tree

[Greg KH]

On Tue, Sep 29, 2020 at 02:41:27PM +0800, miaoqinglang wrote:
> 
> 
> 在 2020/9/29 14:01, Stephen Rothwell 写道:
> > Hi all,
> > 
> > After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
> > produced this warning:
> > 
> > drivers/tty/serial/mvebu-uart.c: In function 'mvebu_uart_probe':
> > drivers/tty/serial/mvebu-uart.c:806:6: warning: unused variable 'ret' [-Wunused-variable]
> >    806 |  int ret, id, irq;
> >        |      ^~~
> > 
> > Introduced by commit
> > 
> >    b63537020db3 ("serial: mvebu-uart: simplify the return expression of mvebu_uart_probe()")
> > 
> Hi Greg,
> 
> Sorry about the noise for remaining the unused variable 'ret' in commit
> b63537020db3.
> 
> Should I send another patch to clean up this warning or send another v2
> patch instead?

A fix-up patch would be best, as this is already in my tree.

thanks,

greg k-h

Re: linux-next: build warning after merge of the tty tree

[miaoqinglang]

在 2020/9/29 15:32, Greg KH 写道:
> On Tue, Sep 29, 2020 at 02:41:27PM +0800, miaoqinglang wrote:
>>
>>
>> 在 2020/9/29 14:01, Stephen Rothwell 写道:
>>> Hi all,
>>>
>>> After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
>>> produced this warning:
>>>
>>> drivers/tty/serial/mvebu-uart.c: In function 'mvebu_uart_probe':
>>> drivers/tty/serial/mvebu-uart.c:806:6: warning: unused variable 'ret' [-Wunused-variable]
>>>     806 |  int ret, id, irq;
>>>         |      ^~~
>>>
>>> Introduced by commit
>>>
>>>     b63537020db3 ("serial: mvebu-uart: simplify the return expression of mvebu_uart_probe()")
>>>
>> Hi Greg,
>>
>> Sorry about the noise for remaining the unused variable 'ret' in commit
>> b63537020db3.
>>
>> Should I send another patch to clean up this warning or send another v2
>> patch instead?
> 
> A fix-up patch would be best, as this is already in my tree.
> 
> thanks,
> 
> greg k-h
> .A fix-up patch has been sent.
Thanks
> 

linux-next: build warning after merge of the tty tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 639 bytes --]

Hi all,

After merging the tty tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

drivers/tty/serial/8250/8250_bcm2835aux.c: In function 'bcm2835aux_serial_probe':
drivers/tty/serial/8250/8250_bcm2835aux.c:154:3: warning: ignoring return value of 'dev_err_probe' declared with attribute 'warn_unused_result' [-Wunused-result]
  154 |   dev_err_probe(&pdev->dev, ret, "unable to register 8250 port\n");
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Introduced by commit

  ea43a60b1548 ("serial: 8250: Simplify with dev_err_probe()")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the tty tree

[Greg KH]

On Wed, Sep 09, 2020 at 03:56:54PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the tty tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> drivers/tty/serial/8250/8250_bcm2835aux.c: In function 'bcm2835aux_serial_probe':
> drivers/tty/serial/8250/8250_bcm2835aux.c:154:3: warning: ignoring return value of 'dev_err_probe' declared with attribute 'warn_unused_result' [-Wunused-result]
>   154 |   dev_err_probe(&pdev->dev, ret, "unable to register 8250 port\n");
>       |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Introduced by commit
> 
>   ea43a60b1548 ("serial: 8250: Simplify with dev_err_probe()")

Offending patch now dropped from the driver-core tree, thanks.

greg k-h

linux-next: build warning after merge of the tty tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 407 bytes --]

Hi Greg,

After merging the tty tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:

drivers/tty/serial/kgdboc.c:134:12: warning: 'kgdboc_option_setup' defined but not used [-Wunused-function]
 static int kgdboc_option_setup(char *opt)
            ^~~~~~~~~~~~~~~~~~~

Introduced by commit

  2dd453168643 ("kgdboc: Fix restrict error")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the tty tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 509 bytes --]

Hi Greg,

After merging the tty tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

drivers/tty/serial/8250/8250_exar.c: In function 'pci_xr17v35x_setup':
drivers/tty/serial/8250/8250_exar.c:380:31: warning: unused variable 'board' [-Wunused-variable]
  const struct exar8250_board *board = priv->board;
                               ^~~~~

Introduced by commit

  328c11f24b57 ("serial: 8250_exar: Remove useless has_slave member")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the tty tree

[Andy Shevchenko]

On Mon, 2018-07-23 at 15:39 +1000, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the tty tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> drivers/tty/serial/8250/8250_exar.c: In function 'pci_xr17v35x_setup':
> drivers/tty/serial/8250/8250_exar.c:380:31: warning: unused variable
> 'board' [-Wunused-variable]
>   const struct exar8250_board *board = priv->board;
>                                ^~~~~
> 
> Introduced by commit
> 
>   328c11f24b57 ("serial: 8250_exar: Remove useless has_slave member")

Oops, my fault. Usually I compile with W=1, but I somehow missed this
warning (Okay, found, I used to have it in another patch). Sorry, the
just sent patch should fix it.

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

linux-next: build warning after merge of the tty tree

[Stephen Rothwell]

Hi Greg,

After merging the tty tree, today's linux-next build
(arm_multi_v7_defconfig) produced this warning:

drivers/tty/serial/sh-sci.c:977:12: warning: 'scif_set_rtrg' defined but not used [-Wunused-function]
 static int scif_set_rtrg(struct uart_port *port, int rx_trig)
            ^

Introduced by commit

  a380ed461f66 ("serial: sh-sci: implement FIFO threshold register setting")

Forgot to add a call to this new function?

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the tty tree

[Greg KH]

On Mon, Feb 06, 2017 at 03:16:38PM +1100, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the tty tree, today's linux-next build
> (arm_multi_v7_defconfig) produced this warning:
> 
> drivers/tty/serial/sh-sci.c:977:12: warning: 'scif_set_rtrg' defined but not used [-Wunused-function]
>  static int scif_set_rtrg(struct uart_port *port, int rx_trig)
>             ^
> 
> Introduced by commit
> 
>   a380ed461f66 ("serial: sh-sci: implement FIFO threshold register setting")
> 
> Forgot to add a call to this new function?

I think this is fixed by a patch I just took into my tree, which isn't
in linux-next yet.  Right Ulrich?  Or is this still a warning with your
latest patch series?

thanks,

greg k-h

Re: linux-next: build warning after merge of the tty tree

[Ulrich Hecht]

On Mon, Feb 6, 2017 at 9:50 AM, Greg KH <greg@kroah.com> wrote:
> On Mon, Feb 06, 2017 at 03:16:38PM +1100, Stephen Rothwell wrote:
>> Hi Greg,
>>
>> After merging the tty tree, today's linux-next build
>> (arm_multi_v7_defconfig) produced this warning:
>>
>> drivers/tty/serial/sh-sci.c:977:12: warning: 'scif_set_rtrg' defined but not used [-Wunused-function]
>>  static int scif_set_rtrg(struct uart_port *port, int rx_trig)
>>             ^
>>
>> Introduced by commit
>>
>>   a380ed461f66 ("serial: sh-sci: implement FIFO threshold register setting")
>>
>> Forgot to add a call to this new function?
>
> I think this is fixed by a patch I just took into my tree, which isn't
> in linux-next yet.  Right Ulrich?

That is correct, it's called in "[PATCH v4 2/4] serial: sh-sci:
SCIFA/B RX FIFO software timeout".

CU
Uli

Re: linux-next: build warning after merge of the tty tree

[Stephen Rothwell]

Hi all,

On Mon, 6 Feb 2017 18:01:20 +0100 Ulrich Hecht <ulrich.hecht+renesas@gmail.com> wrote:
>
> On Mon, Feb 6, 2017 at 9:50 AM, Greg KH <greg@kroah.com> wrote:
> >
> > I think this is fixed by a patch I just took into my tree, which isn't
> > in linux-next yet.  Right Ulrich?  
> 
> That is correct, it's called in "[PATCH v4 2/4] serial: sh-sci:
> SCIFA/B RX FIFO software timeout".

I don't see that commit in any tree I have fetched.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the tty tree

[Greg KH]

On Tue, Feb 07, 2017 at 09:37:09AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> On Mon, 6 Feb 2017 18:01:20 +0100 Ulrich Hecht <ulrich.hecht+renesas@gmail.com> wrote:
> >
> > On Mon, Feb 6, 2017 at 9:50 AM, Greg KH <greg@kroah.com> wrote:
> > >
> > > I think this is fixed by a patch I just took into my tree, which isn't
> > > in linux-next yet.  Right Ulrich?  
> > 
> > That is correct, it's called in "[PATCH v4 2/4] serial: sh-sci:
> > SCIFA/B RX FIFO software timeout".
> 
> I don't see that commit in any tree I have fetched.

That is correct, it's in my "testing" branch that I use to stage things
in before it gets sent to the branch that you pull from.

That branch is now merged with my -next branch, so you will see this
change the next time you sync.

thanks,

greg k-h

Re: linux-next: build warning after merge of the tty tree

[Stephen Rothwell]

Hi Greg,

On Tue, 7 Feb 2017 09:37:31 +0100 Greg KH <greg@kroah.com> wrote:
>
> On Tue, Feb 07, 2017 at 09:37:09AM +1100, Stephen Rothwell wrote:
> > 
> > I don't see that commit in any tree I have fetched.  
> 
> That is correct, it's in my "testing" branch that I use to stage things
> in before it gets sent to the branch that you pull from.

What an amusing idea ;-)

> That branch is now merged with my -next branch, so you will see this
> change the next time you sync.

Thanks.

-- 
Cheers,
Stephen Rothwell

linux-next: build warning after merge of the tty tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 506 bytes --]

Hi Greg,

After merging the tty tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

drivers/tty/serial/imx.c: In function 'imx_set_termios':
drivers/tty/serial/imx.c:1301:7: warning: suggest explicit braces to avoid ambiguous 'else' [-Wparentheses]
    if (port->rs485.flags & SER_RS485_ENABLED)
       ^

Introduced by commit 17b8f2a3fdca ("serial: imx: add support for half
duplex rs485").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: linux-next: build warning after merge of the tty tree

[Uwe Kleine-König]

Hello Greg,

On Tue, Mar 10, 2015 at 04:28:16PM +1100, Stephen Rothwell wrote:
> After merging the tty tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> drivers/tty/serial/imx.c: In function 'imx_set_termios':
> drivers/tty/serial/imx.c:1301:7: warning: suggest explicit braces to avoid ambiguous 'else' [-Wparentheses]
>     if (port->rs485.flags & SER_RS485_ENABLED)
>        ^
> 
> Introduced by commit 17b8f2a3fdca ("serial: imx: add support for half
> duplex rs485").
should I send a fixed commit or do you prefer an incremental change?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Re: linux-next: build warning after merge of the tty tree

[Greg KH]

On Tue, Mar 10, 2015 at 09:23:18AM +0100, Uwe Kleine-König wrote:
> Hello Greg,
> 
> On Tue, Mar 10, 2015 at 04:28:16PM +1100, Stephen Rothwell wrote:
> > After merging the tty tree, today's linux-next build (arm
> > multi_v7_defconfig) produced this warning:
> > 
> > drivers/tty/serial/imx.c: In function 'imx_set_termios':
> > drivers/tty/serial/imx.c:1301:7: warning: suggest explicit braces to avoid ambiguous 'else' [-Wparentheses]
> >     if (port->rs485.flags & SER_RS485_ENABLED)
> >        ^
> > 
> > Introduced by commit 17b8f2a3fdca ("serial: imx: add support for half
> > duplex rs485").
> should I send a fixed commit or do you prefer an incremental change?

It's already in my tree, so I need an add-on patch.

thanks,

greg k-h

linux-next: build warning after merge of the tty tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 546 bytes --]

Hi Greg,

After merging the tty tree, today's linux-next build (powerpc
allyesconfig) produced this warning:

drivers/usb/serial/ssu100.c: In function 'ssu100_ioctl':
drivers/usb/serial/ssu100.c:448: warning: unused variable 'user_arg'
drivers/usb/serial/ssu100.c:447: warning: unused variable 'priv'

Introduced by commit 20e2e6fa50180468e4240a91f811dca3a1c30304 ("tty:
Convert the USB drivers to the new icount interface").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build warning after merge of the tty tree

[Greg KH]

On Fri, Sep 24, 2010 at 02:03:51PM +1000, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the tty tree, today's linux-next build (powerpc
> allyesconfig) produced this warning:
> 
> drivers/usb/serial/ssu100.c: In function 'ssu100_ioctl':
> drivers/usb/serial/ssu100.c:448: warning: unused variable 'user_arg'
> drivers/usb/serial/ssu100.c:447: warning: unused variable 'priv'
> 
> Introduced by commit 20e2e6fa50180468e4240a91f811dca3a1c30304 ("tty:
> Convert the USB drivers to the new icount interface").

Alan, care to fix this one up as well?

thanks,

greg k-h