From: Mark Brown <broonie@kernel.org>
To: "Lothar Waßmann" <LW@KARO-electronics.de>
Cc: "Benoît Cousson" <bcousson@baylibre.com>,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
"Kumar Gala" <galak@codeaurora.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Pawel Moll" <pawel.moll@arm.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Russell King" <linux@arm.linux.org.uk>,
"Tony Lindgren" <tony@atomide.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH 1/2] regulator: ltc3589: make IRQ optional
Date: Thu, 21 Jan 2016 11:11:15 +0000 [thread overview]
Message-ID: <20160121111115.GJ6588@sirena.org.uk> (raw)
In-Reply-To: <20160121112611.34e17cb2@ipc1.ka-ro>
[-- Attachment #1: Type: text/plain, Size: 1237 bytes --]
On Thu, Jan 21, 2016 at 11:26:11AM +0100, Lothar Waßmann wrote:
> > On Thu, Jan 21, 2016 at 08:05:24AM +0100, Lothar Waßmann wrote:
> > > > On Wed, Jan 20, 2016 at 01:29:51PM +0100, Lothar Waßmann wrote:
> > > > > This pin is used as IRQ pin for the LTC3589 PMIC on the Ka-Ro
> > > > > electronics TX48 module. Make the IRQ optional in the driver and use a
> > > > > polling routine instead if no IRQ is specified in DT.
> > > > > Otherwise the driver will continuously generate interrupts and make
> > > > > the system unusable.
> > > > How will the driver generate interrupts if there is no interrupt
> > > > physically present in the system?
> > > It's using timer interrupts to poll the LTC3589 state.
> > I know that is what your patch does, my question is why you say in your
> > commit log that "Otherwise the driver will continuously generate
> > interrupts and make the system unusable".
> Because the interrupt is level triggered and the polarity of the
> EXTINT pin is inverted, the interrupt will be constantly active when
> the IRQ pin of the LTC3589 is inactive.
So, to repeat my original question, how will that generate interrupts if
there is no interrupt physically present in the system?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-01-21 11:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 12:29 PATCH [0/2] ARM: dts: am33xx: add support for Ka-Ro electronics TX48-7020 module Lothar Waßmann
2016-01-20 12:29 ` [PATCH 1/2] regulator: ltc3589: make IRQ optional Lothar Waßmann
2016-01-20 16:42 ` Mark Brown
2016-01-21 7:05 ` Lothar Waßmann
2016-01-21 10:20 ` Mark Brown
2016-01-21 10:26 ` Lothar Waßmann
2016-01-21 11:11 ` Mark Brown [this message]
2016-01-21 11:33 ` Lothar Waßmann
2016-01-21 16:26 ` Mark Brown
2016-01-22 5:41 ` Lothar Waßmann
2016-01-22 16:26 ` Mark Brown
2016-01-25 12:37 ` Lothar Waßmann
2016-01-25 12:41 ` Mark Brown
2016-01-25 12:51 ` Lothar Waßmann
2016-01-25 13:52 ` Mark Brown
2016-01-20 17:29 ` Grygorii Strashko
2016-01-20 12:29 ` [PATCH 2/2] ARM: dts: am33xx: add support for Ka-Ro electronics TX48-7020 module Lothar Waßmann
2016-01-20 16:32 ` Robert Nelson
2016-02-12 22:07 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160121111115.GJ6588@sirena.org.uk \
--to=broonie@kernel.org \
--cc=LW@KARO-electronics.de \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).