From: "Lothar Waßmann" <LW@KARO-electronics.de>
To: Mark Brown <broonie@kernel.org>
Cc: "Benoît Cousson" <bcousson@baylibre.com>,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
"Kumar Gala" <galak@codeaurora.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Pawel Moll" <pawel.moll@arm.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Russell King" <linux@arm.linux.org.uk>,
"Tony Lindgren" <tony@atomide.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH 1/2] regulator: ltc3589: make IRQ optional
Date: Mon, 25 Jan 2016 13:37:31 +0100 [thread overview]
Message-ID: <20160125133731.72669115@ipc1.ka-ro> (raw)
In-Reply-To: <20160122162610.GZ6588@sirena.org.uk>
Hi,
On Fri, 22 Jan 2016 16:26:10 +0000 Mark Brown wrote:
> On Fri, Jan 22, 2016 at 06:41:45AM +0100, Lothar Waßmann wrote:
> > > On Thu, Jan 21, 2016 at 12:33:11PM +0100, Lothar Waßmann wrote:
>
> > > Your commit message (quoted above) claims that without this patch if no
> > > interrupt is supplied then the unsupplied interrupt will somehow be left
> > > screaming and make the system unusable. This doesn't make sense, if
> > > there is no interrupt there is nothing to scream.
>
> > "Otherwise" meant the case where the IRQ is specified in DT as is
> > currently required to get the driver loaded at all.
>
> > > So, contrary to what you've been saying, the interrupt is actually
> > > connected (and worse, connected to a NMI) but apparently not described
> > > in DT. Why is it sensible to make the driver poll (which will affect
> > > all systems using this device, even those that don't care) and not just
> > > describe the interrupt in DT so it can be handled promptly in the normal
> > > fashion? Presumably this will run into serious problems if the
> > > interrupt actually fires at runtime since the NMI will scream, it's not
> > > clear to me how the poll will manage to run successfully in that case.
>
> > Currently the driver won't even load without an IRQ specified in DT.
> > My patch makes it possible to use the driver without requiring an IRQ!
>
> You're not just making the interrupt optional, you are also implementing
> polling support. That's really unusual and there's no clear reason for
> it, your changelog seems to claim that it is needed to make the system
> work but that seems at best very surprising and would need a more
> detailed changelog.
>
> You at least need to provide an understandable changelog, though it
> seems it is more likely that there is a more sensible way of dealing
> with this.
>
Any suggestions how to handle this case in a more sensible way?
Lothar Waßmann
next prev parent reply other threads:[~2016-01-25 12:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 12:29 PATCH [0/2] ARM: dts: am33xx: add support for Ka-Ro electronics TX48-7020 module Lothar Waßmann
2016-01-20 12:29 ` [PATCH 1/2] regulator: ltc3589: make IRQ optional Lothar Waßmann
2016-01-20 16:42 ` Mark Brown
2016-01-21 7:05 ` Lothar Waßmann
2016-01-21 10:20 ` Mark Brown
2016-01-21 10:26 ` Lothar Waßmann
2016-01-21 11:11 ` Mark Brown
2016-01-21 11:33 ` Lothar Waßmann
2016-01-21 16:26 ` Mark Brown
2016-01-22 5:41 ` Lothar Waßmann
2016-01-22 16:26 ` Mark Brown
2016-01-25 12:37 ` Lothar Waßmann [this message]
2016-01-25 12:41 ` Mark Brown
2016-01-25 12:51 ` Lothar Waßmann
2016-01-25 13:52 ` Mark Brown
2016-01-20 17:29 ` Grygorii Strashko
2016-01-20 12:29 ` [PATCH 2/2] ARM: dts: am33xx: add support for Ka-Ro electronics TX48-7020 module Lothar Waßmann
2016-01-20 16:32 ` Robert Nelson
2016-02-12 22:07 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160125133731.72669115@ipc1.ka-ro \
--to=lw@karo-electronics.de \
--cc=bcousson@baylibre.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).