* [PATCH] ARM: dts: omap3-n900: Allow gpio keys to be disabled
@ 2016-01-10 17:46 Ivaylo Dimitrov
2016-01-21 7:58 ` Ivaylo Dimitrov
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Ivaylo Dimitrov @ 2016-01-10 17:46 UTC (permalink / raw)
To: tony
Cc: bcousson, robh+dt, pawel.moll, linux, linux-omap, devicetree,
linux-arm-kernel, linux-kernel, Ivaylo Dimitrov
Add linux,can-disable; to all gpios exported from gpio-keys driver, so
userspace can disable them
Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
---
arch/arm/boot/dts/omap3-n900.dts | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts
index 8ea924c..b58e8a0 100644
--- a/arch/arm/boot/dts/omap3-n900.dts
+++ b/arch/arm/boot/dts/omap3-n900.dts
@@ -68,6 +68,7 @@
linux,input-type = <EV_SW>;
linux,code = <SW_CAMERA_LENS_COVER>;
gpio-key,wakeup;
+ linux,can-disable;
};
camera_focus {
@@ -75,6 +76,7 @@
gpios = <&gpio3 4 GPIO_ACTIVE_LOW>; /* 68 */
linux,code = <KEY_CAMERA_FOCUS>;
gpio-key,wakeup;
+ linux,can-disable;
};
camera_capture {
@@ -82,6 +84,7 @@
gpios = <&gpio3 5 GPIO_ACTIVE_LOW>; /* 69 */
linux,code = <KEY_CAMERA>;
gpio-key,wakeup;
+ linux,can-disable;
};
lock_button {
@@ -89,6 +92,7 @@
gpios = <&gpio4 17 GPIO_ACTIVE_LOW>; /* 113 */
linux,code = <KEY_SCREENLOCK>;
gpio-key,wakeup;
+ linux,can-disable;
};
keypad_slide {
@@ -97,6 +101,7 @@
linux,input-type = <EV_SW>;
linux,code = <SW_KEYPAD_SLIDE>;
gpio-key,wakeup;
+ linux,can-disable;
};
proximity_sensor {
@@ -104,6 +109,7 @@
gpios = <&gpio3 25 GPIO_ACTIVE_HIGH>; /* 89 */
linux,input-type = <EV_SW>;
linux,code = <SW_FRONT_PROXIMITY>;
+ linux,can-disable;
};
};
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] ARM: dts: omap3-n900: Allow gpio keys to be disabled
2016-01-10 17:46 [PATCH] ARM: dts: omap3-n900: Allow gpio keys to be disabled Ivaylo Dimitrov
@ 2016-01-21 7:58 ` Ivaylo Dimitrov
2016-01-27 23:47 ` Sebastian Reichel
2016-02-12 21:53 ` Tony Lindgren
2 siblings, 0 replies; 8+ messages in thread
From: Ivaylo Dimitrov @ 2016-01-21 7:58 UTC (permalink / raw)
To: tony
Cc: bcousson, robh+dt, pawel.moll, linux, linux-omap, devicetree,
linux-arm-kernel, linux-kernel
Ping
On 10.01.2016 19:46, Ivaylo Dimitrov wrote:
> Add linux,can-disable; to all gpios exported from gpio-keys driver, so
> userspace can disable them
>
> Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
> ---
> arch/arm/boot/dts/omap3-n900.dts | 6 ++++++
> 1 file changed, 6 insertions(+)
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: dts: omap3-n900: Allow gpio keys to be disabled
2016-01-10 17:46 [PATCH] ARM: dts: omap3-n900: Allow gpio keys to be disabled Ivaylo Dimitrov
2016-01-21 7:58 ` Ivaylo Dimitrov
@ 2016-01-27 23:47 ` Sebastian Reichel
2016-02-12 21:53 ` Tony Lindgren
2 siblings, 0 replies; 8+ messages in thread
From: Sebastian Reichel @ 2016-01-27 23:47 UTC (permalink / raw)
To: Ivaylo Dimitrov
Cc: tony, bcousson, robh+dt, pawel.moll, linux, linux-omap,
devicetree, linux-arm-kernel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 309 bytes --]
Hi,
On Sun, Jan 10, 2016 at 07:46:30PM +0200, Ivaylo Dimitrov wrote:
> Add linux,can-disable; to all gpios exported from gpio-keys driver, so
> userspace can disable them
>
> Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
Acked-By: Sebastian Reichel <sre@kernel.org>
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: dts: omap3-n900: Allow gpio keys to be disabled
2016-01-10 17:46 [PATCH] ARM: dts: omap3-n900: Allow gpio keys to be disabled Ivaylo Dimitrov
2016-01-21 7:58 ` Ivaylo Dimitrov
2016-01-27 23:47 ` Sebastian Reichel
@ 2016-02-12 21:53 ` Tony Lindgren
2016-02-21 17:49 ` Ivaylo Dimitrov
2016-02-22 14:42 ` Ivaylo Dimitrov
2 siblings, 2 replies; 8+ messages in thread
From: Tony Lindgren @ 2016-02-12 21:53 UTC (permalink / raw)
To: Ivaylo Dimitrov
Cc: bcousson, robh+dt, pawel.moll, linux, linux-omap, devicetree,
linux-arm-kernel, linux-kernel
* Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> [160110 09:47]:
> Add linux,can-disable; to all gpios exported from gpio-keys driver, so
> userspace can disable them
...
> --- a/arch/arm/boot/dts/omap3-n900.dts
> +++ b/arch/arm/boot/dts/omap3-n900.dts
> @@ -68,6 +68,7 @@
> linux,input-type = <EV_SW>;
> linux,code = <SW_CAMERA_LENS_COVER>;
> gpio-key,wakeup;
> + linux,can-disable;
> };
>
> camera_focus {
Looks like this no longer applies because of linux,can-disable
to wakeup-source changes. Can you please update against v4.5-rc
series and repost?
Thanks,
Tony
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] ARM: dts: omap3-n900: Allow gpio keys to be disabled
2016-02-12 21:53 ` Tony Lindgren
@ 2016-02-21 17:49 ` Ivaylo Dimitrov
2016-02-21 19:18 ` Sebastian Reichel
2016-02-22 14:42 ` Ivaylo Dimitrov
1 sibling, 1 reply; 8+ messages in thread
From: Ivaylo Dimitrov @ 2016-02-21 17:49 UTC (permalink / raw)
To: Tony Lindgren
Cc: bcousson, robh+dt, pawel.moll, linux, linux-omap, devicetree,
linux-arm-kernel, linux-kernel
On 12.02.2016 23:53, Tony Lindgren wrote:
>
> Looks like this no longer applies because of linux,can-disable
> to wakeup-source changes. Can you please update against v4.5-rc
> series and repost?
Could you elaborate on that? As I don't really understand what needs to
be updated and what are "wakeup-source changes".
Thanks,
Ivo
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: dts: omap3-n900: Allow gpio keys to be disabled
2016-02-21 17:49 ` Ivaylo Dimitrov
@ 2016-02-21 19:18 ` Sebastian Reichel
0 siblings, 0 replies; 8+ messages in thread
From: Sebastian Reichel @ 2016-02-21 19:18 UTC (permalink / raw)
To: Ivaylo Dimitrov
Cc: Tony Lindgren, bcousson, robh+dt, pawel.moll, linux, linux-omap,
devicetree, linux-arm-kernel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 644 bytes --]
Hi Ivo,
On Sun, Feb 21, 2016 at 07:49:30PM +0200, Ivaylo Dimitrov wrote:
> On 12.02.2016 23:53, Tony Lindgren wrote:
> >Looks like this no longer applies because of linux,can-disable
> >to wakeup-source changes. Can you please update against v4.5-rc
> >series and repost?
>
> Could you elaborate on that? As I don't really understand what needs to be
> updated and what are "wakeup-source changes".
Due to changes in the kernel source (each gpio key in omap3-n900.dts
gained a "wakeup-source" property) the patch can no longer be applied
using "git am". Just rebase your patch to current 4.5-rc and resend it.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ARM: dts: omap3-n900: Allow gpio keys to be disabled
2016-02-12 21:53 ` Tony Lindgren
2016-02-21 17:49 ` Ivaylo Dimitrov
@ 2016-02-22 14:42 ` Ivaylo Dimitrov
2016-02-22 17:57 ` Tony Lindgren
1 sibling, 1 reply; 8+ messages in thread
From: Ivaylo Dimitrov @ 2016-02-22 14:42 UTC (permalink / raw)
To: tony
Cc: bcousson, robh+dt, pawel.moll, linux, linux-omap, devicetree,
linux-arm-kernel, linux-kernel, Ivaylo Dimitrov
Add linux,can-disable; to all gpios exported from gpio-keys driver, so
userspace can disable them
Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
---
arch/arm/boot/dts/omap3-n900.dts | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts
index 74d8f7eb..f01a151 100644
--- a/arch/arm/boot/dts/omap3-n900.dts
+++ b/arch/arm/boot/dts/omap3-n900.dts
@@ -68,6 +68,7 @@
linux,input-type = <5>; /* EV_SW */
linux,code = <0x09>; /* SW_CAMERA_LENS_COVER */
wakeup-source;
+ linux,can-disable;
};
camera_focus {
@@ -75,6 +76,7 @@
gpios = <&gpio3 4 GPIO_ACTIVE_LOW>; /* 68 */
linux,code = <0x210>; /* KEY_CAMERA_FOCUS */
wakeup-source;
+ linux,can-disable;
};
camera_capture {
@@ -82,6 +84,7 @@
gpios = <&gpio3 5 GPIO_ACTIVE_LOW>; /* 69 */
linux,code = <0xd4>; /* KEY_CAMERA */
wakeup-source;
+ linux,can-disable;
};
lock_button {
@@ -89,6 +92,7 @@
gpios = <&gpio4 17 GPIO_ACTIVE_LOW>; /* 113 */
linux,code = <0x98>; /* KEY_SCREENLOCK */
wakeup-source;
+ linux,can-disable;
};
keypad_slide {
@@ -97,6 +101,7 @@
linux,input-type = <5>; /* EV_SW */
linux,code = <0x0a>; /* SW_KEYPAD_SLIDE */
wakeup-source;
+ linux,can-disable;
};
proximity_sensor {
@@ -104,6 +109,7 @@
gpios = <&gpio3 25 GPIO_ACTIVE_HIGH>; /* 89 */
linux,input-type = <5>; /* EV_SW */
linux,code = <0x0b>; /* SW_FRONT_PROXIMITY */
+ linux,can-disable;
};
};
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] ARM: dts: omap3-n900: Allow gpio keys to be disabled
2016-02-22 14:42 ` Ivaylo Dimitrov
@ 2016-02-22 17:57 ` Tony Lindgren
0 siblings, 0 replies; 8+ messages in thread
From: Tony Lindgren @ 2016-02-22 17:57 UTC (permalink / raw)
To: Ivaylo Dimitrov
Cc: bcousson, robh+dt, pawel.moll, linux, linux-omap, devicetree,
linux-arm-kernel, linux-kernel
* Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> [160222 06:43]:
> Add linux,can-disable; to all gpios exported from gpio-keys driver, so
> userspace can disable them
Thanks applying into omap-for-v4.6/dt.
Tony
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-02-22 17:57 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-10 17:46 [PATCH] ARM: dts: omap3-n900: Allow gpio keys to be disabled Ivaylo Dimitrov
2016-01-21 7:58 ` Ivaylo Dimitrov
2016-01-27 23:47 ` Sebastian Reichel
2016-02-12 21:53 ` Tony Lindgren
2016-02-21 17:49 ` Ivaylo Dimitrov
2016-02-21 19:18 ` Sebastian Reichel
2016-02-22 14:42 ` Ivaylo Dimitrov
2016-02-22 17:57 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).