* [PATCH] dts/ls1021a: add the DTS for QSPI support
@ 2016-01-28 8:33 Yuan Yao
2016-02-02 7:49 ` Shawn Guo
0 siblings, 1 reply; 3+ messages in thread
From: Yuan Yao @ 2016-01-28 8:33 UTC (permalink / raw)
To: shawnguo
Cc: robh+dt, mark.rutland, linux-arm-kernel, linux-kernel,
devicetree, Yuan Yao
From: Yuan Yao <yao.yuan@nxp.com>
Signed-off-by: Yuan Yao <yao.yuan@nxp.com>
---
Add in v1:
Can merge, but the function depend on the patch:
https://patchwork.kernel.org/patch/8118251/
mtd: spi-nor: fsl-quadspi: add support for ls1021a
LS1021a also support Freescale Quad SPI controller.
Add fsl-quadspi support for ls1021a chip and make SPI_FSL_QUADSPI
selectable for LS1021A SOC hardwares.
---
arch/arm/boot/dts/ls1021a.dtsi | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi
index 9430a99..c764fa5 100644
--- a/arch/arm/boot/dts/ls1021a.dtsi
+++ b/arch/arm/boot/dts/ls1021a.dtsi
@@ -252,6 +252,21 @@
status = "disabled";
};
+ qspi: quadspi@1550000 {
+ compatible = "fsl,ls1021a-qspi";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0x0 0x1550000 0x0 0x10000>,
+ <0x0 0x40000000 0x0 0x4000000>;
+ reg-names = "QuadSPI", "QuadSPI-memory";
+ interrupts = <GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH>;
+ clock-names = "qspi_en", "qspi";
+ clocks = <&platform_clk 1>, <&platform_clk 1>;
+ big-endian;
+ amba-base = <0x40000000>;
+ status = "disabled";
+ };
+
i2c0: i2c@2180000 {
compatible = "fsl,vf610-i2c";
#address-cells = <1>;
--
2.1.0.27.g96db324
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dts/ls1021a: add the DTS for QSPI support
2016-01-28 8:33 [PATCH] dts/ls1021a: add the DTS for QSPI support Yuan Yao
@ 2016-02-02 7:49 ` Shawn Guo
2016-02-02 11:10 ` Yao Yuan
0 siblings, 1 reply; 3+ messages in thread
From: Shawn Guo @ 2016-02-02 7:49 UTC (permalink / raw)
To: Yuan Yao
Cc: mark.rutland, devicetree, linux-kernel, robh+dt, Yuan Yao,
linux-arm-kernel
On Thu, Jan 28, 2016 at 04:33:26PM +0800, Yuan Yao wrote:
> From: Yuan Yao <yao.yuan@nxp.com>
>
> Signed-off-by: Yuan Yao <yao.yuan@nxp.com>
> ---
> Add in v1:
> Can merge, but the function depend on the patch:
> https://patchwork.kernel.org/patch/8118251/
Please send me dts patch only after the driver part gets applied.
>
> mtd: spi-nor: fsl-quadspi: add support for ls1021a
>
> LS1021a also support Freescale Quad SPI controller.
> Add fsl-quadspi support for ls1021a chip and make SPI_FSL_QUADSPI
> selectable for LS1021A SOC hardwares.
>
> ---
> arch/arm/boot/dts/ls1021a.dtsi | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi
> index 9430a99..c764fa5 100644
> --- a/arch/arm/boot/dts/ls1021a.dtsi
> +++ b/arch/arm/boot/dts/ls1021a.dtsi
> @@ -252,6 +252,21 @@
> status = "disabled";
> };
>
> + qspi: quadspi@1550000 {
> + compatible = "fsl,ls1021a-qspi";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0x0 0x1550000 0x0 0x10000>,
> + <0x0 0x40000000 0x0 0x4000000>;
> + reg-names = "QuadSPI", "QuadSPI-memory";
> + interrupts = <GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH>;
> + clock-names = "qspi_en", "qspi";
> + clocks = <&platform_clk 1>, <&platform_clk 1>;
> + big-endian;
> + amba-base = <0x40000000>;
What is this property? I cannot find it in any bindings doc. Is it
added by your patches on driver code?
Shawn
> + status = "disabled";
> + };
> +
> i2c0: i2c@2180000 {
> compatible = "fsl,vf610-i2c";
> #address-cells = <1>;
> --
> 2.1.0.27.g96db324
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] dts/ls1021a: add the DTS for QSPI support
2016-02-02 7:49 ` Shawn Guo
@ 2016-02-02 11:10 ` Yao Yuan
0 siblings, 0 replies; 3+ messages in thread
From: Yao Yuan @ 2016-02-02 11:10 UTC (permalink / raw)
To: Shawn Guo, Yuan Yao
Cc: mark.rutland, devicetree, linux-kernel, robh+dt, linux-arm-kernel
On Tue, Feb 02, 2016 at 03:49PM, Shawn Guo wrote:
> On Thu, Jan 28, 2016 at 04:33:26PM +0800, Yuan Yao wrote:
> > From: Yuan Yao <yao.yuan@nxp.com>
> >
> > Signed-off-by: Yuan Yao <yao.yuan@nxp.com>
> > ---
> > Add in v1:
> > Can merge, but the function depend on the patch:
> > https://patchwork.kernel.org/patch/8118251/
>
> Please send me dts patch only after the driver part gets applied.
Ok, I will resend the patch after the driver part gets applied.
I just only want to speed up my upstream.
>
> >
> > mtd: spi-nor: fsl-quadspi: add support for ls1021a
> >
> > LS1021a also support Freescale Quad SPI controller.
> > Add fsl-quadspi support for ls1021a chip and make SPI_FSL_QUADSPI
> > selectable for LS1021A SOC hardwares.
> >
> > ---
> > arch/arm/boot/dts/ls1021a.dtsi | 15 +++++++++++++++
> > 1 file changed, 15 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/ls1021a.dtsi
> > b/arch/arm/boot/dts/ls1021a.dtsi index 9430a99..c764fa5 100644
> > --- a/arch/arm/boot/dts/ls1021a.dtsi
> > +++ b/arch/arm/boot/dts/ls1021a.dtsi
> > @@ -252,6 +252,21 @@
> > status = "disabled";
> > };
> >
> > + qspi: quadspi@1550000 {
> > + compatible = "fsl,ls1021a-qspi";
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + reg = <0x0 0x1550000 0x0 0x10000>,
> > + <0x0 0x40000000 0x0 0x4000000>;
> > + reg-names = "QuadSPI", "QuadSPI-memory";
> > + interrupts = <GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH>;
> > + clock-names = "qspi_en", "qspi";
> > + clocks = <&platform_clk 1>, <&platform_clk 1>;
> > + big-endian;
> > + amba-base = <0x40000000>;
>
> What is this property? I cannot find it in any bindings doc. Is it added by your
> patches on driver code?
Sorry, it's the legacy property, after the latest discussion we will remove this property.
So I will remove it in the next version.
Thanks for your review.
Yuan Yao.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-02 11:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-28 8:33 [PATCH] dts/ls1021a: add the DTS for QSPI support Yuan Yao
2016-02-02 7:49 ` Shawn Guo
2016-02-02 11:10 ` Yao Yuan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).