* [PATCH] [media] media: Kconfig: add dependency of HAS_DMA @ 2015-12-30 13:26 Sudip Mukherjee 2016-01-11 12:53 ` Sudip Mukherjee 2016-01-23 13:55 ` Geert Uytterhoeven 0 siblings, 2 replies; 9+ messages in thread From: Sudip Mukherjee @ 2015-12-30 13:26 UTC (permalink / raw) To: Mauro Carvalho Chehab Cc: linux-kernel, linux-media, Andrew Morton, Sudip Mukherjee The build of m32r allmodconfig fails with the error: drivers/media/v4l2-core/videobuf2-dma-contig.c:484:2: error: implicit declaration of function 'dma_get_cache_alignment' The build of videobuf2-dma-contig.c depends on HAS_DMA and it is correctly mentioned in the Kconfig but the symbol VIDEO_STI_BDISP also selects VIDEOBUF2_DMA_CONTIG, so it is trying to compile videobuf2-dma-contig.c even though HAS_DMA is not defined. Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> --- drivers/media/platform/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig index 5263594..8b89ebe1 100644 --- a/drivers/media/platform/Kconfig +++ b/drivers/media/platform/Kconfig @@ -215,6 +215,7 @@ config VIDEO_SAMSUNG_EXYNOS_GSC config VIDEO_STI_BDISP tristate "STMicroelectronics BDISP 2D blitter driver" depends on VIDEO_DEV && VIDEO_V4L2 + depends on HAS_DMA depends on ARCH_STI || COMPILE_TEST select VIDEOBUF2_DMA_CONTIG select V4L2_MEM2MEM_DEV -- 1.9.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] [media] media: Kconfig: add dependency of HAS_DMA 2015-12-30 13:26 [PATCH] [media] media: Kconfig: add dependency of HAS_DMA Sudip Mukherjee @ 2016-01-11 12:53 ` Sudip Mukherjee 2016-01-12 14:10 ` Sakari Ailus 2016-01-23 13:55 ` Geert Uytterhoeven 1 sibling, 1 reply; 9+ messages in thread From: Sudip Mukherjee @ 2016-01-11 12:53 UTC (permalink / raw) To: Mauro Carvalho Chehab; +Cc: linux-kernel, linux-media, Andrew Morton On Wed, Dec 30, 2015 at 06:56:03PM +0530, Sudip Mukherjee wrote: > The build of m32r allmodconfig fails with the error: > drivers/media/v4l2-core/videobuf2-dma-contig.c:484:2: > error: implicit declaration of function 'dma_get_cache_alignment' > > The build of videobuf2-dma-contig.c depends on HAS_DMA and it is > correctly mentioned in the Kconfig but the symbol VIDEO_STI_BDISP also > selects VIDEOBUF2_DMA_CONTIG, so it is trying to compile > videobuf2-dma-contig.c even though HAS_DMA is not defined. > > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> > --- A gentle ping. m32r allmodconfig still fails with next-20160111. Build log is at: https://travis-ci.org/sudipm-mukherjee/parport/jobs/101536379 regards sudip ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] [media] media: Kconfig: add dependency of HAS_DMA 2016-01-11 12:53 ` Sudip Mukherjee @ 2016-01-12 14:10 ` Sakari Ailus 2016-01-12 16:05 ` Sudip Mukherjee 2016-01-13 14:36 ` Marek Szyprowski 0 siblings, 2 replies; 9+ messages in thread From: Sakari Ailus @ 2016-01-12 14:10 UTC (permalink / raw) To: Sudip Mukherjee Cc: Mauro Carvalho Chehab, linux-kernel, linux-media, Andrew Morton, hverkuil, pawel, m.szyprowski, kyungmin.park On Mon, Jan 11, 2016 at 06:23:11PM +0530, Sudip Mukherjee wrote: > On Wed, Dec 30, 2015 at 06:56:03PM +0530, Sudip Mukherjee wrote: > > The build of m32r allmodconfig fails with the error: > > drivers/media/v4l2-core/videobuf2-dma-contig.c:484:2: > > error: implicit declaration of function 'dma_get_cache_alignment' > > > > The build of videobuf2-dma-contig.c depends on HAS_DMA and it is > > correctly mentioned in the Kconfig but the symbol VIDEO_STI_BDISP also > > selects VIDEOBUF2_DMA_CONTIG, so it is trying to compile > > videobuf2-dma-contig.c even though HAS_DMA is not defined. > > > > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> > > --- > > A gentle ping. m32r allmodconfig still fails with next-20160111. Build > log is at: > https://travis-ci.org/sudipm-mukherjee/parport/jobs/101536379 Hi Sudip, Even though the issue now manifests itself on m32r, the problem is wider than that: dma_get_cache_alignment() is only defined if CONFIG_HAS_DMA is set. I wonder if using videobuf2-dma-contig makes any sense if HAS_DMA is disabled, so perhaps it'd be possible to make it depend on HAS_DMA. Cc others. -- Kind regards, Sakari Ailus e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] [media] media: Kconfig: add dependency of HAS_DMA 2016-01-12 14:10 ` Sakari Ailus @ 2016-01-12 16:05 ` Sudip Mukherjee 2016-01-13 14:36 ` Marek Szyprowski 1 sibling, 0 replies; 9+ messages in thread From: Sudip Mukherjee @ 2016-01-12 16:05 UTC (permalink / raw) To: Sakari Ailus Cc: Mauro Carvalho Chehab, linux-kernel, linux-media, Andrew Morton, hverkuil, pawel, m.szyprowski, kyungmin.park On Tue, Jan 12, 2016 at 04:10:43PM +0200, Sakari Ailus wrote: > On Mon, Jan 11, 2016 at 06:23:11PM +0530, Sudip Mukherjee wrote: > > On Wed, Dec 30, 2015 at 06:56:03PM +0530, Sudip Mukherjee wrote: > > > The build of m32r allmodconfig fails with the error: > > > drivers/media/v4l2-core/videobuf2-dma-contig.c:484:2: > > > error: implicit declaration of function 'dma_get_cache_alignment' > > > > > > The build of videobuf2-dma-contig.c depends on HAS_DMA and it is > > > correctly mentioned in the Kconfig but the symbol VIDEO_STI_BDISP also > > > selects VIDEOBUF2_DMA_CONTIG, so it is trying to compile > > > videobuf2-dma-contig.c even though HAS_DMA is not defined. > > > > > > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> > > > --- > > > > A gentle ping. m32r allmodconfig still fails with next-20160111. Build > > log is at: > > https://travis-ci.org/sudipm-mukherjee/parport/jobs/101536379 > > Hi Sudip, > > Even though the issue now manifests itself on m32r, the problem is wider > than that: dma_get_cache_alignment() is only defined if CONFIG_HAS_DMA is > set. > > I wonder if using videobuf2-dma-contig makes any sense if HAS_DMA is > disabled, so perhaps it'd be possible to make it depend on HAS_DMA. I have checked with all the Kconfig which selects VIDEOBUF2_DMA_CONTIG and all of them does depend on HAS_DMA. This is the only place where it was missing. regards sudip ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] [media] media: Kconfig: add dependency of HAS_DMA 2016-01-12 14:10 ` Sakari Ailus 2016-01-12 16:05 ` Sudip Mukherjee @ 2016-01-13 14:36 ` Marek Szyprowski 2016-01-14 8:46 ` Sakari Ailus 1 sibling, 1 reply; 9+ messages in thread From: Marek Szyprowski @ 2016-01-13 14:36 UTC (permalink / raw) To: Sakari Ailus, Sudip Mukherjee Cc: Mauro Carvalho Chehab, linux-kernel, linux-media, Andrew Morton, hverkuil, pawel, kyungmin.park Hello, On 2016-01-12 15:10, Sakari Ailus wrote: > On Mon, Jan 11, 2016 at 06:23:11PM +0530, Sudip Mukherjee wrote: >> On Wed, Dec 30, 2015 at 06:56:03PM +0530, Sudip Mukherjee wrote: >>> The build of m32r allmodconfig fails with the error: >>> drivers/media/v4l2-core/videobuf2-dma-contig.c:484:2: >>> error: implicit declaration of function 'dma_get_cache_alignment' >>> >>> The build of videobuf2-dma-contig.c depends on HAS_DMA and it is >>> correctly mentioned in the Kconfig but the symbol VIDEO_STI_BDISP also >>> selects VIDEOBUF2_DMA_CONTIG, so it is trying to compile >>> videobuf2-dma-contig.c even though HAS_DMA is not defined. >>> >>> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> >>> --- >> A gentle ping. m32r allmodconfig still fails with next-20160111. Build >> log is at: >> https://travis-ci.org/sudipm-mukherjee/parport/jobs/101536379 > Hi Sudip, > > Even though the issue now manifests itself on m32r, the problem is wider > than that: dma_get_cache_alignment() is only defined if CONFIG_HAS_DMA is > set. > > I wonder if using videobuf2-dma-contig makes any sense if HAS_DMA is > disabled, so perhaps it'd be possible to make it depend on HAS_DMA. VIDEOBUF2_DMA_CONTIG already depends on HAS_DMA, but when driver use select directive for enabling support for VIDEOBUF2_DMA_CONTIG, the dependencies are not checked further. This is known limitation/feature of kconfig system. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] [media] media: Kconfig: add dependency of HAS_DMA 2016-01-13 14:36 ` Marek Szyprowski @ 2016-01-14 8:46 ` Sakari Ailus 2016-02-03 8:01 ` Sudip Mukherjee 0 siblings, 1 reply; 9+ messages in thread From: Sakari Ailus @ 2016-01-14 8:46 UTC (permalink / raw) To: Marek Szyprowski Cc: Sudip Mukherjee, Mauro Carvalho Chehab, linux-kernel, linux-media, Andrew Morton, hverkuil, pawel, kyungmin.park Hi Marek and Sudip, On Wed, Jan 13, 2016 at 03:36:39PM +0100, Marek Szyprowski wrote: > Hello, > > On 2016-01-12 15:10, Sakari Ailus wrote: > >On Mon, Jan 11, 2016 at 06:23:11PM +0530, Sudip Mukherjee wrote: > >>On Wed, Dec 30, 2015 at 06:56:03PM +0530, Sudip Mukherjee wrote: > >>>The build of m32r allmodconfig fails with the error: > >>>drivers/media/v4l2-core/videobuf2-dma-contig.c:484:2: > >>> error: implicit declaration of function 'dma_get_cache_alignment' > >>> > >>>The build of videobuf2-dma-contig.c depends on HAS_DMA and it is > >>>correctly mentioned in the Kconfig but the symbol VIDEO_STI_BDISP also > >>>selects VIDEOBUF2_DMA_CONTIG, so it is trying to compile > >>>videobuf2-dma-contig.c even though HAS_DMA is not defined. > >>> > >>>Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> > >>>--- > >>A gentle ping. m32r allmodconfig still fails with next-20160111. Build > >>log is at: > >>https://travis-ci.org/sudipm-mukherjee/parport/jobs/101536379 > >Hi Sudip, > > > >Even though the issue now manifests itself on m32r, the problem is wider > >than that: dma_get_cache_alignment() is only defined if CONFIG_HAS_DMA is > >set. > > > >I wonder if using videobuf2-dma-contig makes any sense if HAS_DMA is > >disabled, so perhaps it'd be possible to make it depend on HAS_DMA. > > VIDEOBUF2_DMA_CONTIG already depends on HAS_DMA, but when driver use select > directive for enabling support for VIDEOBUF2_DMA_CONTIG, the dependencies > are not checked further. This is known limitation/feature of kconfig system. Thanks for the insight. Sounds like this is the right thing to do then. Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com> -- Kind regards, Sakari Ailus e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] [media] media: Kconfig: add dependency of HAS_DMA 2016-01-14 8:46 ` Sakari Ailus @ 2016-02-03 8:01 ` Sudip Mukherjee 2016-02-03 19:13 ` Sakari Ailus 0 siblings, 1 reply; 9+ messages in thread From: Sudip Mukherjee @ 2016-02-03 8:01 UTC (permalink / raw) To: Sakari Ailus Cc: Marek Szyprowski, Mauro Carvalho Chehab, linux-kernel, linux-media, Andrew Morton, hverkuil, pawel, kyungmin.park Hi Mauro, On Thu, Jan 14, 2016 at 10:46:59AM +0200, Sakari Ailus wrote: > Hi Marek and Sudip, > > On Wed, Jan 13, 2016 at 03:36:39PM +0100, Marek Szyprowski wrote: > > Hello, > > > > On 2016-01-12 15:10, Sakari Ailus wrote: > > >On Mon, Jan 11, 2016 at 06:23:11PM +0530, Sudip Mukherjee wrote: > > >>On Wed, Dec 30, 2015 at 06:56:03PM +0530, Sudip Mukherjee wrote: > > >>>The build of m32r allmodconfig fails with the error: > > >>>drivers/media/v4l2-core/videobuf2-dma-contig.c:484:2: > > >>> error: implicit declaration of function 'dma_get_cache_alignment' > > >>> > > >>>The build of videobuf2-dma-contig.c depends on HAS_DMA and it is > > >>>correctly mentioned in the Kconfig but the symbol VIDEO_STI_BDISP also > > >>>selects VIDEOBUF2_DMA_CONTIG, so it is trying to compile > > >>>videobuf2-dma-contig.c even though HAS_DMA is not defined. > > >>> > > >>>Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> > > >>>--- > > >>A gentle ping. m32r allmodconfig still fails with next-20160111. Build > > >>log is at: > > >>https://travis-ci.org/sudipm-mukherjee/parport/jobs/101536379 > > >Hi Sudip, > > > > > >Even though the issue now manifests itself on m32r, the problem is wider > > >than that: dma_get_cache_alignment() is only defined if CONFIG_HAS_DMA is > > >set. > > > > > >I wonder if using videobuf2-dma-contig makes any sense if HAS_DMA is > > >disabled, so perhaps it'd be possible to make it depend on HAS_DMA. > > > > VIDEOBUF2_DMA_CONTIG already depends on HAS_DMA, but when driver use select > > directive for enabling support for VIDEOBUF2_DMA_CONTIG, the dependencies > > are not checked further. This is known limitation/feature of kconfig system. > > Thanks for the insight. Sounds like this is the right thing to do then. > > Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com> I got an update from patchwork that it has been accepted, but I still do not see it in linux-next or in rc2. m32r allmodconfig build still fails. build log of next-20160203 is at https://travis-ci.org/sudipm-mukherjee/parport/jobs/106657434 regards sudip ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] [media] media: Kconfig: add dependency of HAS_DMA 2016-02-03 8:01 ` Sudip Mukherjee @ 2016-02-03 19:13 ` Sakari Ailus 0 siblings, 0 replies; 9+ messages in thread From: Sakari Ailus @ 2016-02-03 19:13 UTC (permalink / raw) To: Sudip Mukherjee Cc: Marek Szyprowski, Mauro Carvalho Chehab, linux-kernel, linux-media, Andrew Morton, hverkuil, pawel, kyungmin.park Hi Sudip, On Wed, Feb 03, 2016 at 01:31:03PM +0530, Sudip Mukherjee wrote: > Hi Mauro, > > On Thu, Jan 14, 2016 at 10:46:59AM +0200, Sakari Ailus wrote: > > Hi Marek and Sudip, > > > > On Wed, Jan 13, 2016 at 03:36:39PM +0100, Marek Szyprowski wrote: > > > Hello, > > > > > > On 2016-01-12 15:10, Sakari Ailus wrote: > > > >On Mon, Jan 11, 2016 at 06:23:11PM +0530, Sudip Mukherjee wrote: > > > >>On Wed, Dec 30, 2015 at 06:56:03PM +0530, Sudip Mukherjee wrote: > > > >>>The build of m32r allmodconfig fails with the error: > > > >>>drivers/media/v4l2-core/videobuf2-dma-contig.c:484:2: > > > >>> error: implicit declaration of function 'dma_get_cache_alignment' > > > >>> > > > >>>The build of videobuf2-dma-contig.c depends on HAS_DMA and it is > > > >>>correctly mentioned in the Kconfig but the symbol VIDEO_STI_BDISP also > > > >>>selects VIDEOBUF2_DMA_CONTIG, so it is trying to compile > > > >>>videobuf2-dma-contig.c even though HAS_DMA is not defined. > > > >>> > > > >>>Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> > > > >>>--- > > > >>A gentle ping. m32r allmodconfig still fails with next-20160111. Build > > > >>log is at: > > > >>https://travis-ci.org/sudipm-mukherjee/parport/jobs/101536379 > > > >Hi Sudip, > > > > > > > >Even though the issue now manifests itself on m32r, the problem is wider > > > >than that: dma_get_cache_alignment() is only defined if CONFIG_HAS_DMA is > > > >set. > > > > > > > >I wonder if using videobuf2-dma-contig makes any sense if HAS_DMA is > > > >disabled, so perhaps it'd be possible to make it depend on HAS_DMA. > > > > > > VIDEOBUF2_DMA_CONTIG already depends on HAS_DMA, but when driver use select > > > directive for enabling support for VIDEOBUF2_DMA_CONTIG, the dependencies > > > are not checked further. This is known limitation/feature of kconfig system. > > > > Thanks for the insight. Sounds like this is the right thing to do then. > > > > Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com> > > I got an update from patchwork that it has been accepted, but I still do > not see it in linux-next or in rc2. m32r allmodconfig build still fails. > build log of next-20160203 is at > https://travis-ci.org/sudipm-mukherjee/parport/jobs/106657434 Your patch is in the fixes branch of media-tree. It'll end up to mainline eventually (4.5 I presume). -- Sakari Ailus e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] [media] media: Kconfig: add dependency of HAS_DMA 2015-12-30 13:26 [PATCH] [media] media: Kconfig: add dependency of HAS_DMA Sudip Mukherjee 2016-01-11 12:53 ` Sudip Mukherjee @ 2016-01-23 13:55 ` Geert Uytterhoeven 1 sibling, 0 replies; 9+ messages in thread From: Geert Uytterhoeven @ 2016-01-23 13:55 UTC (permalink / raw) To: Sudip Mukherjee Cc: Mauro Carvalho Chehab, linux-kernel, Linux Media Mailing List, Andrew Morton On Wed, Dec 30, 2015 at 2:26 PM, Sudip Mukherjee <sudipm.mukherjee@gmail.com> wrote: > The build of m32r allmodconfig fails with the error: > drivers/media/v4l2-core/videobuf2-dma-contig.c:484:2: > error: implicit declaration of function 'dma_get_cache_alignment' > > The build of videobuf2-dma-contig.c depends on HAS_DMA and it is > correctly mentioned in the Kconfig but the symbol VIDEO_STI_BDISP also > selects VIDEOBUF2_DMA_CONTIG, so it is trying to compile > videobuf2-dma-contig.c even though HAS_DMA is not defined. > > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2016-02-03 19:14 UTC | newest] Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2015-12-30 13:26 [PATCH] [media] media: Kconfig: add dependency of HAS_DMA Sudip Mukherjee 2016-01-11 12:53 ` Sudip Mukherjee 2016-01-12 14:10 ` Sakari Ailus 2016-01-12 16:05 ` Sudip Mukherjee 2016-01-13 14:36 ` Marek Szyprowski 2016-01-14 8:46 ` Sakari Ailus 2016-02-03 8:01 ` Sudip Mukherjee 2016-02-03 19:13 ` Sakari Ailus 2016-01-23 13:55 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).