From: Davidlohr Bueso <dave@stgolabs.net>
To: Waiman Long <Waiman.Long@hpe.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Ding Tianhong <dingtianhong@huawei.com>,
Jason Low <jason.low2@hpe.com>,
"Paul E. McKenney" <paulmck@us.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Will Deacon <Will.Deacon@arm.com>,
Tim Chen <tim.c.chen@linux.intel.com>,
Waiman Long <Waiman.Long@hp.com>
Subject: Re: [PATCH v2 1/4] locking/mutex: Add waiter parameter to mutex_optimistic_spin()
Date: Fri, 12 Feb 2016 14:02:49 -0800 [thread overview]
Message-ID: <20160212220249.GA16417@linux-uzut.site> (raw)
In-Reply-To: <1455298335-53229-2-git-send-email-Waiman.Long@hpe.com>
On Fri, 12 Feb 2016, Waiman Long wrote:
>This patch adds a new waiter parameter to the mutex_optimistic_spin()
>function to prepare it to be used by a waiter-spinner that doesn't
>need to go into the OSQ as there can only be one waiter-spinner which
>is the head of the waiting queue.
>
>Signed-off-by: Waiman Long <Waiman.Long@hp.com>
>---
> kernel/locking/mutex.c | 55 ++++++++++++++++++++++++++++++++---------------
> 1 files changed, 37 insertions(+), 18 deletions(-)
>
>diff --git a/kernel/locking/mutex.c b/kernel/locking/mutex.c
>index 0551c21..3c41448 100644
>--- a/kernel/locking/mutex.c
>+++ b/kernel/locking/mutex.c
>@@ -273,11 +273,15 @@ static inline int mutex_can_spin_on_owner(struct mutex *lock)
>
> /*
> * Atomically try to take the lock when it is available
>+ *
>+ * For waiter-spinner, the count needs to be set to -1 first which will be
>+ * cleared to 0 later on if the list becomes empty. For regular spinner,
>+ * the count will be set to 0.
> */
>-static inline bool mutex_try_to_acquire(struct mutex *lock)
>+static inline bool mutex_try_to_acquire(struct mutex *lock, int waiter)
> {
> return !mutex_is_locked(lock) &&
>- (atomic_cmpxchg_acquire(&lock->count, 1, 0) == 1);
>+ (atomic_cmpxchg_acquire(&lock->count, 1, waiter ? -1 : 0) == 1);
> }
This can be a really hot path, could we get rid of the waiter check and just
introduce mutex_tro_to_acquire_waiter() or such and set the counter to -1 there?
Thanks,
Davidlohr
next prev parent reply other threads:[~2016-02-12 22:03 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-12 17:32 [PATCH v2 0/4] locking/mutex: Enable optimistic spinning of lock waiter Waiman Long
2016-02-12 17:32 ` [PATCH v2 1/4] locking/mutex: Add waiter parameter to mutex_optimistic_spin() Waiman Long
2016-02-12 20:23 ` Peter Zijlstra
2016-02-12 22:14 ` Davidlohr Bueso
2016-02-13 12:10 ` Peter Zijlstra
2016-02-13 18:14 ` Davidlohr Bueso
2016-02-16 2:15 ` Jason Low
2016-02-16 2:22 ` Jason Low
2016-02-16 8:53 ` Peter Zijlstra
2016-02-17 1:40 ` Waiman Long
2016-02-15 22:06 ` Waiman Long
2016-02-12 20:40 ` Peter Zijlstra
2016-02-15 23:55 ` Waiman Long
2016-02-16 3:00 ` Jason Low
2016-02-16 3:30 ` Waiman Long
2016-02-12 22:02 ` Davidlohr Bueso [this message]
2016-02-12 22:09 ` Davidlohr Bueso
2016-02-16 0:03 ` Waiman Long
2016-02-12 17:32 ` [PATCH v2 2/4] locking/mutex: Enable optimistic spinning of woken task in wait queue Waiman Long
2016-02-12 17:32 ` [PATCH v2 3/4] locking/mutex: Avoid missed wakeup of mutex waiter Waiman Long
2016-02-12 17:32 ` [PATCH v2 4/4] sched/fair: Abort wakeup when task is no longer in a sleeping state Waiman Long
2016-02-12 20:18 ` Peter Zijlstra
2016-02-12 21:22 ` Waiman Long
2016-02-13 12:09 ` Peter Zijlstra
2016-02-16 8:51 ` [PATCH v2 0/4] locking/mutex: Enable optimistic spinning of lock waiter Peter Zijlstra
2016-02-17 1:39 ` Waiman Long
2016-03-22 3:19 ` Waiman Long
2016-03-22 9:59 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160212220249.GA16417@linux-uzut.site \
--to=dave@stgolabs.net \
--cc=Waiman.Long@hp.com \
--cc=Waiman.Long@hpe.com \
--cc=Will.Deacon@arm.com \
--cc=dingtianhong@huawei.com \
--cc=jason.low2@hpe.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulmck@us.ibm.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tim.c.chen@linux.intel.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).