* [PATCH V3] i2c: i801: Adding Intel Lewisburg support for iTCO
[not found] <[PATCH V3] i2c: i801: Adding Intel Lewisburg support for iTCO>
@ 2016-02-05 23:22 ` Alexandra Yates
2016-02-10 9:42 ` Jean Delvare
0 siblings, 1 reply; 6+ messages in thread
From: Alexandra Yates @ 2016-02-05 23:22 UTC (permalink / raw)
To: jdelvare, wsa, linux-i2c, linux-kernel; +Cc: Alexandra Yates
Changes log v2 to v3: Clarified commit message. No changes in code.
Starting from Intel Sunrisepoint (Skylake PCH) the iTCO watchdog
resources have been moved to reside under the i801 SMBus host
controller whereas previously they were under the LPC device.
This patch adds Intel lewisburg SMBus support for iTCO device.
It allows to load watchdog dynamically when the hardware is
present. This patch is an addition
to cdc5a3110e7c3ae793f367285789a6bc39c962dc i2c: i801: "add
Intel Lewisburg device IDs".
Signed-off-by: Alexandra Yates <alexandra.yates@linux.intel.com>
---
drivers/i2c/busses/i2c-i801.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
index f62d697..27fa0cb 100644
--- a/drivers/i2c/busses/i2c-i801.c
+++ b/drivers/i2c/busses/i2c-i801.c
@@ -1271,6 +1271,8 @@ static int i801_probe(struct pci_dev *dev, const struct pci_device_id *id)
switch (dev->device) {
case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_H_SMBUS:
case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_SMBUS:
+ case PCI_DEVICE_ID_INTEL_LEWISBURG_SMBUS:
+ case PCI_DEVICE_ID_INTEL_LEWISBURG_SSKU_SMBUS:
case PCI_DEVICE_ID_INTEL_DNV_SMBUS:
priv->features |= FEATURE_I2C_BLOCK_READ;
priv->features |= FEATURE_IRQ;
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH V3] i2c: i801: Adding Intel Lewisburg support for iTCO
2016-02-05 23:22 ` [PATCH V3] i2c: i801: Adding Intel Lewisburg support for iTCO Alexandra Yates
@ 2016-02-10 9:42 ` Jean Delvare
2016-02-12 19:09 ` Wolfram Sang
2016-02-18 1:21 ` Alexandra Yates
0 siblings, 2 replies; 6+ messages in thread
From: Jean Delvare @ 2016-02-10 9:42 UTC (permalink / raw)
To: Alexandra Yates; +Cc: wsa, linux-i2c, linux-kernel
Hi Alexandra,
On Fri, 5 Feb 2016 15:22:44 -0800, Alexandra Yates wrote:
> Changes log v2 to v3: Clarified commit message. No changes in code.
>
> Starting from Intel Sunrisepoint (Skylake PCH) the iTCO watchdog
> resources have been moved to reside under the i801 SMBus host
> controller whereas previously they were under the LPC device.
>
> This patch adds Intel lewisburg SMBus support for iTCO device.
> It allows to load watchdog dynamically when the hardware is
> present. This patch is an addition
> to cdc5a3110e7c3ae793f367285789a6bc39c962dc i2c: i801: "add
> Intel Lewisburg device IDs".
>
> Signed-off-by: Alexandra Yates <alexandra.yates@linux.intel.com>
> ---
> drivers/i2c/busses/i2c-i801.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
> index f62d697..27fa0cb 100644
> --- a/drivers/i2c/busses/i2c-i801.c
> +++ b/drivers/i2c/busses/i2c-i801.c
> @@ -1271,6 +1271,8 @@ static int i801_probe(struct pci_dev *dev, const struct pci_device_id *id)
> switch (dev->device) {
> case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_H_SMBUS:
> case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_SMBUS:
> + case PCI_DEVICE_ID_INTEL_LEWISBURG_SMBUS:
> + case PCI_DEVICE_ID_INTEL_LEWISBURG_SSKU_SMBUS:
> case PCI_DEVICE_ID_INTEL_DNV_SMBUS:
> priv->features |= FEATURE_I2C_BLOCK_READ;
> priv->features |= FEATURE_IRQ;
Reviewed-by: Jean Delvare <jdelvare@suse.de>
Note this checkpatch warning though:
ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 0123456789ab ("commit description")'
#40:
to cdc5a3110e7c3ae793f367285789a6bc39c962dc i2c: i801: "add
It is also common to add a "Fixes:" line with that information so that
patch backporting can be automated. And as I said before I would tag
the patch for stable as well.
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH V3] i2c: i801: Adding Intel Lewisburg support for iTCO
2016-02-10 9:42 ` Jean Delvare
@ 2016-02-12 19:09 ` Wolfram Sang
2016-02-17 19:10 ` Alexandra Yates
2016-02-18 1:21 ` Alexandra Yates
1 sibling, 1 reply; 6+ messages in thread
From: Wolfram Sang @ 2016-02-12 19:09 UTC (permalink / raw)
To: Jean Delvare; +Cc: Alexandra Yates, linux-i2c, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 2130 bytes --]
On Wed, Feb 10, 2016 at 10:42:31AM +0100, Jean Delvare wrote:
> Hi Alexandra,
>
> On Fri, 5 Feb 2016 15:22:44 -0800, Alexandra Yates wrote:
> > Changes log v2 to v3: Clarified commit message. No changes in code.
This line should be below the "---".
> >
> > Starting from Intel Sunrisepoint (Skylake PCH) the iTCO watchdog
> > resources have been moved to reside under the i801 SMBus host
> > controller whereas previously they were under the LPC device.
> >
> > This patch adds Intel lewisburg SMBus support for iTCO device.
> > It allows to load watchdog dynamically when the hardware is
> > present. This patch is an addition
> > to cdc5a3110e7c3ae793f367285789a6bc39c962dc i2c: i801: "add
> > Intel Lewisburg device IDs".
> >
> > Signed-off-by: Alexandra Yates <alexandra.yates@linux.intel.com>
> > ---
> > drivers/i2c/busses/i2c-i801.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
> > index f62d697..27fa0cb 100644
> > --- a/drivers/i2c/busses/i2c-i801.c
> > +++ b/drivers/i2c/busses/i2c-i801.c
> > @@ -1271,6 +1271,8 @@ static int i801_probe(struct pci_dev *dev, const struct pci_device_id *id)
> > switch (dev->device) {
> > case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_H_SMBUS:
> > case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_SMBUS:
> > + case PCI_DEVICE_ID_INTEL_LEWISBURG_SMBUS:
> > + case PCI_DEVICE_ID_INTEL_LEWISBURG_SSKU_SMBUS:
> > case PCI_DEVICE_ID_INTEL_DNV_SMBUS:
> > priv->features |= FEATURE_I2C_BLOCK_READ;
> > priv->features |= FEATURE_IRQ;
>
> Reviewed-by: Jean Delvare <jdelvare@suse.de>
>
> Note this checkpatch warning though:
>
> ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 0123456789ab ("commit description")'
> #40:
> to cdc5a3110e7c3ae793f367285789a6bc39c962dc i2c: i801: "add
>
> It is also common to add a "Fixes:" line with that information so that
> patch backporting can be automated. And as I said before I would tag
> the patch for stable as well.
Can you do this and resend?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH V3] i2c: i801: Adding Intel Lewisburg support for iTCO
2016-02-12 19:09 ` Wolfram Sang
@ 2016-02-17 19:10 ` Alexandra Yates
0 siblings, 0 replies; 6+ messages in thread
From: Alexandra Yates @ 2016-02-17 19:10 UTC (permalink / raw)
To: Wolfram Sang, Jean Delvare; +Cc: linux-i2c, linux-kernel
Hi,
On 02/12/2016 11:09 AM, Wolfram Sang wrote:
> On Wed, Feb 10, 2016 at 10:42:31AM +0100, Jean Delvare wrote:
>> Hi Alexandra,
>>
>> On Fri, 5 Feb 2016 15:22:44 -0800, Alexandra Yates wrote:
>>> Changes log v2 to v3: Clarified commit message. No changes in code.
>
> This line should be below the "---".
>
>>>
>>> Starting from Intel Sunrisepoint (Skylake PCH) the iTCO watchdog
>>> resources have been moved to reside under the i801 SMBus host
>>> controller whereas previously they were under the LPC device.
>>>
>>> This patch adds Intel lewisburg SMBus support for iTCO device.
>>> It allows to load watchdog dynamically when the hardware is
>>> present. This patch is an addition
>>> to cdc5a3110e7c3ae793f367285789a6bc39c962dc i2c: i801: "add
>>> Intel Lewisburg device IDs".
>>>
>>> Signed-off-by: Alexandra Yates <alexandra.yates@linux.intel.com>
>>> ---
>>> drivers/i2c/busses/i2c-i801.c | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
>>> index f62d697..27fa0cb 100644
>>> --- a/drivers/i2c/busses/i2c-i801.c
>>> +++ b/drivers/i2c/busses/i2c-i801.c
>>> @@ -1271,6 +1271,8 @@ static int i801_probe(struct pci_dev *dev, const struct pci_device_id *id)
>>> switch (dev->device) {
>>> case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_H_SMBUS:
>>> case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_SMBUS:
>>> + case PCI_DEVICE_ID_INTEL_LEWISBURG_SMBUS:
>>> + case PCI_DEVICE_ID_INTEL_LEWISBURG_SSKU_SMBUS:
>>> case PCI_DEVICE_ID_INTEL_DNV_SMBUS:
>>> priv->features |= FEATURE_I2C_BLOCK_READ;
>>> priv->features |= FEATURE_IRQ;
>>
>> Reviewed-by: Jean Delvare <jdelvare@suse.de>
>>
>> Note this checkpatch warning though:
>>
>> ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 0123456789ab ("commit description")'
>> #40:
>> to cdc5a3110e7c3ae793f367285789a6bc39c962dc i2c: i801: "add
>>
>> It is also common to add a "Fixes:" line with that information so that
>> patch backporting can be automated. And as I said before I would tag
>> the patch for stable as well.
>
> Can you do this and resend?
>
Thank you guys for the very constructive feedback. I'll be resending
the patches today.
--
Thank you,
<Alexandra>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH V3] i2c: i801: Adding Intel Lewisburg support for iTCO
2016-02-10 9:42 ` Jean Delvare
2016-02-12 19:09 ` Wolfram Sang
@ 2016-02-18 1:21 ` Alexandra Yates
2016-02-18 1:25 ` Wolfram Sang
1 sibling, 1 reply; 6+ messages in thread
From: Alexandra Yates @ 2016-02-18 1:21 UTC (permalink / raw)
To: Jean Delvare; +Cc: wsa, linux-i2c, linux-kernel
Hi Jean,
On 02/10/2016 01:42 AM, Jean Delvare wrote:
> Hi Alexandra,
>
> On Fri, 5 Feb 2016 15:22:44 -0800, Alexandra Yates wrote:
>> Changes log v2 to v3: Clarified commit message. No changes in code.
>>
>> Starting from Intel Sunrisepoint (Skylake PCH) the iTCO watchdog
>> resources have been moved to reside under the i801 SMBus host
>> controller whereas previously they were under the LPC device.
>>
>> This patch adds Intel lewisburg SMBus support for iTCO device.
>> It allows to load watchdog dynamically when the hardware is
>> present. This patch is an addition
>> to cdc5a3110e7c3ae793f367285789a6bc39c962dc i2c: i801: "add
>> Intel Lewisburg device IDs".
>>
>> Signed-off-by: Alexandra Yates <alexandra.yates@linux.intel.com>
>> ---
>> drivers/i2c/busses/i2c-i801.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
>> index f62d697..27fa0cb 100644
>> --- a/drivers/i2c/busses/i2c-i801.c
>> +++ b/drivers/i2c/busses/i2c-i801.c
>> @@ -1271,6 +1271,8 @@ static int i801_probe(struct pci_dev *dev, const struct pci_device_id *id)
>> switch (dev->device) {
>> case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_H_SMBUS:
>> case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_SMBUS:
>> + case PCI_DEVICE_ID_INTEL_LEWISBURG_SMBUS:
>> + case PCI_DEVICE_ID_INTEL_LEWISBURG_SSKU_SMBUS:
>> case PCI_DEVICE_ID_INTEL_DNV_SMBUS:
>> priv->features |= FEATURE_I2C_BLOCK_READ;
>> priv->features |= FEATURE_IRQ;
>
> Reviewed-by: Jean Delvare <jdelvare@suse.de>
>
> Note this checkpatch warning though:
>
> ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 0123456789ab ("commit description")'
> #40:
> to cdc5a3110e7c3ae793f367285789a6bc39c962dc i2c: i801: "add
>
> It is also common to add a "Fixes:" line with that information so that
I'm adding all your recommendations. However, Can you help me
understand what do you mean by tagging the patch for stable? I've been
looking online but I can't find such tag name.
Do you mean CCing the patch to stable mailing list?
> patch backporting can be automated. And as I said before I would tag
> the patch for stable as well.
>
--
Thank you,
<Alexandra>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH V3] i2c: i801: Adding Intel Lewisburg support for iTCO
2016-02-18 1:21 ` Alexandra Yates
@ 2016-02-18 1:25 ` Wolfram Sang
0 siblings, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2016-02-18 1:25 UTC (permalink / raw)
To: Alexandra Yates; +Cc: Jean Delvare, linux-i2c, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 329 bytes --]
> Do you mean CCing the patch to stable mailing list?
Yes, he means that. Although how this is handled depends on the
subsystem. I prefer a hint like "I think this patch is for stable" and
then I'll add the proper cc when committing. This way, I can override
the decision if necessary without noise on the stable mailing list.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-02-18 1:25 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <[PATCH V3] i2c: i801: Adding Intel Lewisburg support for iTCO>
2016-02-05 23:22 ` [PATCH V3] i2c: i801: Adding Intel Lewisburg support for iTCO Alexandra Yates
2016-02-10 9:42 ` Jean Delvare
2016-02-12 19:09 ` Wolfram Sang
2016-02-17 19:10 ` Alexandra Yates
2016-02-18 1:21 ` Alexandra Yates
2016-02-18 1:25 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).