From: Borislav Petkov <bp@alien8.de>
To: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>
Cc: joro@8bytes.org, peterz@infradead.org, mingo@redhat.com,
acme@kernel.org, andihartmann@freenet.de,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org
Subject: Re: [PATCH V4 4/6] perf/amd/iommu: Introduce get_iommu_bnk_cnt_evt_idx
Date: Thu, 18 Feb 2016 12:45:47 +0100 [thread overview]
Message-ID: <20160218114547.GB28866@pd.tnic> (raw)
In-Reply-To: <1455182127-17551-5-git-send-email-Suravee.Suthikulpanit@amd.com>
On Thu, Feb 11, 2016 at 04:15:25PM +0700, Suravee Suthikulpanit wrote:
> Introduce a helper function to calculate bit-index for assigning
> performance counter assignment.
>
> Signed-off-by: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>
> ---
> arch/x86/events/amd/iommu.c | 19 ++++++++++++++-----
> 1 file changed, 14 insertions(+), 5 deletions(-)
>
> diff --git a/arch/x86/events/amd/iommu.c b/arch/x86/events/amd/iommu.c
> index debf22d..812eff2 100644
> --- a/arch/x86/events/amd/iommu.c
> +++ b/arch/x86/events/amd/iommu.c
> @@ -145,18 +145,27 @@ static struct attribute_group amd_iommu_cpumask_group = {
>
> /*---------------------------------------------*/
>
> +static inline
> +int get_iommu_bnk_cnt_evt_idx(struct perf_amd_iommu *perf_iommu,
> + int iommu_index, int bank_index,
> + int cntr_index)
Align args at the opening brace.
> +{
> + int cntrs_per_iommu = perf_iommu->max_banks * perf_iommu->max_counters;
> + int index = (perf_iommu->max_counters * bank_index) + cntr_index;
> +
> + return (cntrs_per_iommu * iommu_index) + index;
> +}
> +
> static int get_next_avail_iommu_bnk_cntr(struct perf_amd_iommu *perf_iommu)
> {
> unsigned long flags;
> int shift, bank, cntr, retval;
> - int max_banks = perf_iommu->max_banks;
> - int max_cntrs = perf_iommu->max_counters;
>
> raw_spin_lock_irqsave(&perf_iommu->lock, flags);
>
> - for (bank = 0, shift = 0; bank < max_banks; bank++) {
> - for (cntr = 0; cntr < max_cntrs; cntr++) {
> - shift = bank + (bank*3) + cntr;
> + for (bank = 0, shift = 0; bank < perf_iommu->max_banks; bank++) {
Please init that shift variable above in the function entry - it
confuses unnecessarily here as if it had anything to do with the loop
stride.
> + for (cntr = 0; cntr < perf_iommu->max_counters; cntr++) {
> + shift = get_iommu_bnk_cnt_evt_idx(perf_iommu, 0, bank, cntr);
\n here
> if (perf_iommu->cntr_assign_mask & (1ULL<<shift)) {
> continue;
> } else {
> --
> 2.5.0
>
>
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
next prev parent reply other threads:[~2016-02-18 11:45 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-11 9:15 [PATCH V4 0/6] perf/amd/iommu: Enable multi-IOMMU support Suravee Suthikulpanit
2016-02-11 9:15 ` [PATCH V4 1/6] perf/amd/iommu: Consolidate and move perf_event_amd_iommu header Suravee Suthikulpanit
2016-02-11 9:15 ` [PATCH V4 2/6] perf/amd/iommu: Modify functions to query max banks and counters Suravee Suthikulpanit
2016-02-18 11:11 ` Borislav Petkov
2016-02-22 4:55 ` Suravee Suthikulpanit
2016-02-11 9:15 ` [PATCH V4 3/6] iommu/amd: Introduce amd_iommu_get_num_iommus() Suravee Suthikulpanit
2016-02-11 9:15 ` [PATCH V4 4/6] perf/amd/iommu: Introduce get_iommu_bnk_cnt_evt_idx Suravee Suthikulpanit
2016-02-18 11:45 ` Borislav Petkov [this message]
2016-02-11 9:15 ` [PATCH V4 5/6] perf/amd/iommu: Enable support for multiple IOMMUs Suravee Suthikulpanit
2016-02-18 13:18 ` Peter Zijlstra
2016-02-22 8:00 ` Suravee Suthikulpanit
2016-02-22 14:07 ` Peter Zijlstra
2016-02-23 5:12 ` Suravee Suthikulpanit
2016-02-23 5:24 ` Alex Williamson
2016-02-23 9:56 ` Suravee Suthikulpanit
2016-02-18 13:21 ` Borislav Petkov
2016-02-11 9:15 ` [PATCH V4 6/6] perf/amd/iommu: Clean up print messages pr_debug Suravee Suthikulpanit
2016-02-18 13:22 ` Borislav Petkov
2016-02-18 2:30 ` [PATCH V4 0/6] perf/amd/iommu: Enable multi-IOMMU support Suravee Suthikulpanit
2016-02-23 11:04 ` Joerg Roedel
2016-02-23 11:27 ` Suravee Suthikulpanit
2016-02-23 11:39 ` Suravee Suthikulpanit
2016-02-23 12:12 ` [PATCH] iommu/amd: Fix boot warning when device 00:00.0 is not iommu Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160218114547.GB28866@pd.tnic \
--to=bp@alien8.de \
--cc=Suravee.Suthikulpanit@amd.com \
--cc=acme@kernel.org \
--cc=andihartmann@freenet.de \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).