From: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>
To: <joro@8bytes.org>, <bp@alien8.de>, <peterz@infradead.org>,
<mingo@redhat.com>, <acme@kernel.org>
Cc: <andihartmann@freenet.de>, <linux-kernel@vger.kernel.org>,
<iommu@lists.linux-foundation.org>
Subject: Re: [PATCH V4 0/6] perf/amd/iommu: Enable multi-IOMMU support
Date: Thu, 18 Feb 2016 09:30:36 +0700 [thread overview]
Message-ID: <56C52CCC.5030303@amd.com> (raw)
In-Reply-To: <1455182127-17551-1-git-send-email-Suravee.Suthikulpanit@amd.com>
Hi All,
I am wondering if there are any other concerns for this patch series.
Thanks,
Suravee
On 2/11/16 16:15, Suravee Suthikulpanit wrote:
> From: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
>
> This patch series modifies the existing perf_event_amd_iommu driver
> to support systems with multiple IOMMUs. It introduces new AMD IOMMU APIs,
> which are used by the AMD IOMMU Perf driver to access performance
> counters in multiple IOMMUs.
>
> In addition, this series should also fix current AMD IOMMU PMU driver
> initialization issue in some existing KV and CZ platform, where it fails
> to write to IOMMU perf counter as reported by Andreas Hartmann here
> (http://comments.gmane.org/gmane.linux.kernel.pci/49147).
>
> Git branch containing this patch series is available here:
>
> https://github.com/ssuthiku/linux.git perf-iommu-v4
>
> Changes from V3 (https://lkml.org/lkml/2016/2/9/845)
> * Rebase the code to tip/master per Boris suggestion
> * Most changes are in patch 5/6:
> * Fix several spelling and styling issues per Boris review comment
> * Remove unnecessary pr_debug in the perf amd iommu driver (per Boris)
> * Rename several function to make it less confusing (per Boris)
> * Properly handle errors when fails to set registers/counters
> on multiple IOMMUs. (per Boris)
>
> Changes from V2 ( https://lkml.org/lkml/2016/1/1/141)
> * Ported to 4.5.0-rc2
> * Add reviewed by Joerg for patch 1 and 2
> * Remove EXPORT_SYMBOL from patch 3 (per Joerg suggestion)
> * Merge patch 4/6 and 6/6 from V2 into 5/5 in V3 and add
> more description in the commit message and in code comment.
> * Patch 5: modify the logic to update counts to get rid off
> un-necessary local64_cmpxchg().
>
> Changes from V1 (https://lkml.org/lkml/2015/12/22/535):
> * Update patch3 and 6 to use amd_iommus_present instead of introducing
> amd_iommu_cnt static variable since they are the same thing
>
> Suravee Suthikulpanit (6):
> perf/amd/iommu: Consolidate and move perf_event_amd_iommu header
> perf/amd/iommu: Modify functions to query max banks and counters
> iommu/amd: Introduce amd_iommu_get_num_iommus()
> perf/amd/iommu: Introduce get_iommu_bnk_cnt_evt_idx
> perf/amd/iommu: Enable support for multiple IOMMUs
> perf/amd/iommu: Declar pr_fmt and remove unnecessary pr_debug
>
> arch/x86/events/amd/iommu.c | 197 ++++++++++++++++++++++------------
> arch/x86/events/amd/iommu.h | 40 -------
> arch/x86/include/asm/perf/amd/iommu.h | 42 ++++++++
> drivers/iommu/amd_iommu_init.c | 136 +++++++++++++++++++----
> drivers/iommu/amd_iommu_proto.h | 7 --
> 5 files changed, 286 insertions(+), 136 deletions(-)
> delete mode 100644 arch/x86/events/amd/iommu.h
> create mode 100644 arch/x86/include/asm/perf/amd/iommu.h
>
next prev parent reply other threads:[~2016-02-18 2:31 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-11 9:15 [PATCH V4 0/6] perf/amd/iommu: Enable multi-IOMMU support Suravee Suthikulpanit
2016-02-11 9:15 ` [PATCH V4 1/6] perf/amd/iommu: Consolidate and move perf_event_amd_iommu header Suravee Suthikulpanit
2016-02-11 9:15 ` [PATCH V4 2/6] perf/amd/iommu: Modify functions to query max banks and counters Suravee Suthikulpanit
2016-02-18 11:11 ` Borislav Petkov
2016-02-22 4:55 ` Suravee Suthikulpanit
2016-02-11 9:15 ` [PATCH V4 3/6] iommu/amd: Introduce amd_iommu_get_num_iommus() Suravee Suthikulpanit
2016-02-11 9:15 ` [PATCH V4 4/6] perf/amd/iommu: Introduce get_iommu_bnk_cnt_evt_idx Suravee Suthikulpanit
2016-02-18 11:45 ` Borislav Petkov
2016-02-11 9:15 ` [PATCH V4 5/6] perf/amd/iommu: Enable support for multiple IOMMUs Suravee Suthikulpanit
2016-02-18 13:18 ` Peter Zijlstra
2016-02-22 8:00 ` Suravee Suthikulpanit
2016-02-22 14:07 ` Peter Zijlstra
2016-02-23 5:12 ` Suravee Suthikulpanit
2016-02-23 5:24 ` Alex Williamson
2016-02-23 9:56 ` Suravee Suthikulpanit
2016-02-18 13:21 ` Borislav Petkov
2016-02-11 9:15 ` [PATCH V4 6/6] perf/amd/iommu: Clean up print messages pr_debug Suravee Suthikulpanit
2016-02-18 13:22 ` Borislav Petkov
2016-02-18 2:30 ` Suravee Suthikulpanit [this message]
2016-02-23 11:04 ` [PATCH V4 0/6] perf/amd/iommu: Enable multi-IOMMU support Joerg Roedel
2016-02-23 11:27 ` Suravee Suthikulpanit
2016-02-23 11:39 ` Suravee Suthikulpanit
2016-02-23 12:12 ` [PATCH] iommu/amd: Fix boot warning when device 00:00.0 is not iommu Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C52CCC.5030303@amd.com \
--to=suravee.suthikulpanit@amd.com \
--cc=acme@kernel.org \
--cc=andihartmann@freenet.de \
--cc=bp@alien8.de \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).