From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
Taeung Song <treeze.taeung@gmail.com>,
linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Lai Jiangshan <jiangshanlai@gmail.com>
Subject: Re: [RFC] Re: [PATCH v3 1/2] tracing/syscalls: Rename variable 'nr' to '__syscall_nr'
Date: Fri, 26 Feb 2016 16:03:35 -0300 [thread overview]
Message-ID: <20160226190335.GW8720@kernel.org> (raw)
In-Reply-To: <20160226132301.3ae065a4@gandalf.local.home>
Em Fri, Feb 26, 2016 at 01:23:01PM -0500, Steven Rostedt escreveu:
> On Fri, 26 Feb 2016 10:57:13 -0300 Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> > If we stand by published ABIs, we should keep it written in stone and
> > state that the first 'nr' means '__syscall_nr' while keeping it as-is,
> > the change for 'perf trace' in that case is to do nothing, it work
> > as-is, we have just to fix the python binding to do that rename.
<SNIP>
> > Perhaps we can live with that, to avoid having three different cases:
> > !nr, nr and __syscall_nr.
>
> We could, do this as well. Want me to add something to event-parse?
You mean do nothing in the kernel? Suits me fine, the fix would be just
on the tools/perf/ code, where it generates the python skeletons, I can
do that, as I guess Taeung is sleep at this point :-)
- Arnaldo
next prev parent reply other threads:[~2016-02-26 19:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-26 13:14 [PATCH v3 1/2] tracing/syscalls: Rename variable 'nr' to '__syscall_nr' Taeung Song
2016-02-26 13:57 ` [RFC] " Arnaldo Carvalho de Melo
2016-02-26 18:23 ` Steven Rostedt
2016-02-26 19:03 ` Arnaldo Carvalho de Melo [this message]
2016-02-27 16:10 ` Taeung Song
2016-02-27 18:34 ` Steven Rostedt
2016-02-28 7:43 ` Taeung Song
2016-03-05 8:13 ` [tip:perf/core] tracing/syscalls: Rename "/format" tracepoint field name "nr" to "__syscall_nr: tip-bot for Taeung Song
2016-02-27 15:13 ` [RFC] Re: [PATCH v3 1/2] tracing/syscalls: Rename variable 'nr' to '__syscall_nr' Peter Zijlstra
2016-02-29 14:21 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160226190335.GW8720@kernel.org \
--to=acme@kernel.org \
--cc=jiangshanlai@gmail.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=treeze.taeung@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).