[PATCH] perf tools: explicitly declare inc_group_count as a void function

[PATCH] perf tools: explicitly declare inc_group_count as a void function

[Colin King]

From: Colin Ian King <colin.king@canonical.com>

The return type is not defined, so it defaults to int, however,
the function is not returning anything, so this is clearly not
correct. Make it a void function.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 tools/perf/util/parse-events.y | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/parse-events.y b/tools/perf/util/parse-events.y
index 85c44ba..5be4a5f 100644
--- a/tools/perf/util/parse-events.y
+++ b/tools/perf/util/parse-events.y
@@ -28,7 +28,7 @@ do { \
 	INIT_LIST_HEAD(list);         \
 } while (0)
 
-static inc_group_count(struct list_head *list,
+static void inc_group_count(struct list_head *list,
 		       struct parse_events_evlist *data)
 {
 	/* Count groups only have more than 1 members */
-- 
2.7.0

Re: [PATCH] perf tools: explicitly declare inc_group_count as a void function

[Jiri Olsa]

On Thu, Mar 03, 2016 at 12:30:14PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The return type is not defined, so it defaults to int, however,
> the function is not returning anything, so this is clearly not
> correct. Make it a void function.

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka

> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  tools/perf/util/parse-events.y | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/parse-events.y b/tools/perf/util/parse-events.y
> index 85c44ba..5be4a5f 100644
> --- a/tools/perf/util/parse-events.y
> +++ b/tools/perf/util/parse-events.y
> @@ -28,7 +28,7 @@ do { \
>  	INIT_LIST_HEAD(list);         \
>  } while (0)
>  
> -static inc_group_count(struct list_head *list,
> +static void inc_group_count(struct list_head *list,
>  		       struct parse_events_evlist *data)
>  {
>  	/* Count groups only have more than 1 members */
> -- 
> 2.7.0
> 

Re: [PATCH] perf tools: explicitly declare inc_group_count as a void function

[Arnaldo Carvalho de Melo]

Em Thu, Mar 03, 2016 at 01:39:39PM +0100, Jiri Olsa escreveu:
> On Thu, Mar 03, 2016 at 12:30:14PM +0000, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> > 
> > The return type is not defined, so it defaults to int, however,
> > the function is not returning anything, so this is clearly not
> > correct. Make it a void function.
> 
> Acked-by: Jiri Olsa <jolsa@kernel.org>

Thanks, applied.

[tip:perf/core] perf tools: Explicitly declare inc_group_count as a void function

[tip-bot for Colin Ian King]

Commit-ID:  07ef7574458369cb0345facc748e964af68a75f4
Gitweb:     http://git.kernel.org/tip/07ef7574458369cb0345facc748e964af68a75f4
Author:     Colin Ian King <colin.king@canonical.com>
AuthorDate: Mon, 7 Mar 2016 16:44:37 -0300
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Tue, 8 Mar 2016 10:11:16 +0100

perf tools: Explicitly declare inc_group_count as a void function

The return type is not defined, so it defaults to int, however, the
function is not returning anything, so this is clearly not correct. Make
it a void function.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: He Kuang <hekuang@huawei.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/r/1457008214-14393-1-git-send-email-colin.king@canonical.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 tools/perf/util/parse-events.y | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/parse-events.y b/tools/perf/util/parse-events.y
index 85c44ba..5be4a5f 100644
--- a/tools/perf/util/parse-events.y
+++ b/tools/perf/util/parse-events.y
@@ -28,7 +28,7 @@ do { \
 	INIT_LIST_HEAD(list);         \
 } while (0)
 
-static inc_group_count(struct list_head *list,
+static void inc_group_count(struct list_head *list,
 		       struct parse_events_evlist *data)
 {
 	/* Count groups only have more than 1 members */