* [patch] libertas: fix an error code in probe
@ 2016-03-08 12:04 Dan Carpenter
2016-03-10 12:57 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2016-03-08 12:04 UTC (permalink / raw)
To: Kalle Valo
Cc: Andreas Kemnade, libertas-dev, linux-wireless, netdev,
linux-kernel, kernel-janitors
We accidentally return success instead of a negative error code.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/wireless/marvell/libertas/main.c b/drivers/net/wireless/marvell/libertas/main.c
index b35b8bc..8541cbe 100644
--- a/drivers/net/wireless/marvell/libertas/main.c
+++ b/drivers/net/wireless/marvell/libertas/main.c
@@ -1118,7 +1118,8 @@ int lbs_start_card(struct lbs_private *priv)
else
pr_info("%s: mesh disabled\n", dev->name);
- if (lbs_cfg_register(priv)) {
+ ret = lbs_cfg_register(priv);
+ if (ret) {
pr_err("cannot register device\n");
goto done;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: libertas: fix an error code in probe
2016-03-08 12:04 [patch] libertas: fix an error code in probe Dan Carpenter
@ 2016-03-10 12:57 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2016-03-10 12:57 UTC (permalink / raw)
To: Dan Carpenter
Cc: Andreas Kemnade, libertas-dev, linux-wireless, netdev,
linux-kernel, kernel-janitors
> We accidentally return success instead of a negative error code.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks, applied to wireless-drivers-next.git.
Kalle Valo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-03-10 12:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-08 12:04 [patch] libertas: fix an error code in probe Dan Carpenter
2016-03-10 12:57 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).