* [PATCH] rtc: hym8563: fix invalid year calculation
@ 2016-03-06 9:43 Alexander Kochetkov
2016-03-10 22:42 ` Alexandre Belloni
0 siblings, 1 reply; 2+ messages in thread
From: Alexander Kochetkov @ 2016-03-06 9:43 UTC (permalink / raw)
To: Alessandro Zummo, Alexandre Belloni
Cc: rtc-linux, linux-kernel, Alexander Kochetkov
Year field must be in BCD format, according to
hym8563 datasheet.
Due to the bug year 2016 became 2010.
Signed-off-by: Alexander Kochetkov <al.kochet@gmail.com>
---
drivers/rtc/rtc-hym8563.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-hym8563.c b/drivers/rtc/rtc-hym8563.c
index 097325d..b1b4746 100644
--- a/drivers/rtc/rtc-hym8563.c
+++ b/drivers/rtc/rtc-hym8563.c
@@ -144,7 +144,7 @@ static int hym8563_rtc_set_time(struct device *dev, struct rtc_time *tm)
* it does not seem to carry it over a subsequent write/read.
* So we'll limit ourself to 100 years, starting at 2000 for now.
*/
- buf[6] = tm->tm_year - 100;
+ buf[6] = bin2bcd(tm->tm_year - 100);
/*
* CTL1 only contains TEST-mode bits apart from stop,
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rtc: hym8563: fix invalid year calculation
2016-03-06 9:43 [PATCH] rtc: hym8563: fix invalid year calculation Alexander Kochetkov
@ 2016-03-10 22:42 ` Alexandre Belloni
0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Belloni @ 2016-03-10 22:42 UTC (permalink / raw)
To: Alexander Kochetkov; +Cc: Alessandro Zummo, rtc-linux, linux-kernel
On 06/03/2016 at 12:43:57 +0300, Alexander Kochetkov wrote :
> Year field must be in BCD format, according to
> hym8563 datasheet.
>
> Due to the bug year 2016 became 2010.
>
> Signed-off-by: Alexander Kochetkov <al.kochet@gmail.com>
> ---
> drivers/rtc/rtc-hym8563.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-03-10 22:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-06 9:43 [PATCH] rtc: hym8563: fix invalid year calculation Alexander Kochetkov
2016-03-10 22:42 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).