[PATCH] AHCI: Remove obsolete Intel Lewisburg SATA RAID device IDs

[PATCH] AHCI: Remove obsolete Intel Lewisburg SATA RAID device IDs

[scott.lawson]

From: Scott Lawson <scott.lawson@intel.com>

These PCI device IDs have been removed from the Intel Lewisburg design
specification. They are no longer needed.

Signed-off-by: Scott Lawson <scott.lawson@intel.com>
---
 drivers/ata/ahci.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index 546a369..97c41b3 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -369,13 +369,9 @@ static const struct pci_device_id ahci_pci_tbl[] = {
 	{ PCI_VDEVICE(INTEL, 0x2822), board_ahci }, /* Lewisburg RAID*/
 	{ PCI_VDEVICE(INTEL, 0x2826), board_ahci }, /* Lewisburg RAID*/
 	{ PCI_VDEVICE(INTEL, 0xa182), board_ahci }, /* Lewisburg AHCI*/
-	{ PCI_VDEVICE(INTEL, 0xa184), board_ahci }, /* Lewisburg RAID*/
 	{ PCI_VDEVICE(INTEL, 0xa186), board_ahci }, /* Lewisburg RAID*/
-	{ PCI_VDEVICE(INTEL, 0xa18e), board_ahci }, /* Lewisburg RAID*/
 	{ PCI_VDEVICE(INTEL, 0xa202), board_ahci }, /* Lewisburg AHCI*/
-	{ PCI_VDEVICE(INTEL, 0xa204), board_ahci }, /* Lewisburg RAID*/
 	{ PCI_VDEVICE(INTEL, 0xa206), board_ahci }, /* Lewisburg RAID*/
-	{ PCI_VDEVICE(INTEL, 0xa20e), board_ahci }, /* Lewisburg RAID*/
 
 	/* JMicron 360/1/3/5/6, match class to avoid IDE function */
 	{ PCI_VENDOR_ID_JMICRON, PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID,
-- 
1.9.1

Re: [PATCH] AHCI: Remove obsolete Intel Lewisburg SATA RAID device IDs

[Christoph Hellwig]

On Fri, Feb 26, 2016 at 10:09:52AM -0800, scott.lawson@intel.com wrote:
> From: Scott Lawson <scott.lawson@intel.com>
> 
> These PCI device IDs have been removed from the Intel Lewisburg design
> specification. They are no longer needed.

Let's keep them just in case..

Re: [PATCH] AHCI: Remove obsolete Intel Lewisburg SATA RAID device IDs

[Tejun Heo]

On Sat, Feb 27, 2016 at 12:51:54AM -0800, Christoph Hellwig wrote:
> On Fri, Feb 26, 2016 at 10:09:52AM -0800, scott.lawson@intel.com wrote:
> > From: Scott Lawson <scott.lawson@intel.com>
> > 
> > These PCI device IDs have been removed from the Intel Lewisburg design
> > specification. They are no longer needed.
> 
> Let's keep them just in case..

Out of curiosity, any specific reasons to do so?

-- 
tejun

Re: [PATCH] AHCI: Remove obsolete Intel Lewisburg SATA RAID device IDs

[Christoph Hellwig]

On Sat, Feb 27, 2016 at 06:18:55AM -0500, Tejun Heo wrote:
> On Sat, Feb 27, 2016 at 12:51:54AM -0800, Christoph Hellwig wrote:
> > On Fri, Feb 26, 2016 at 10:09:52AM -0800, scott.lawson@intel.com wrote:
> > > From: Scott Lawson <scott.lawson@intel.com>
> > > 
> > > These PCI device IDs have been removed from the Intel Lewisburg design
> > > specification. They are no longer needed.
> > 
> > Let's keep them just in case..
> 
> Out of curiosity, any specific reasons to do so?

If it's been added to the driver I'd expect at least prototype hardware
to already be out there.

Re: [PATCH] AHCI: Remove obsolete Intel Lewisburg SATA RAID device IDs

[Tejun Heo]

Hello,

On Sun, Feb 28, 2016 at 05:10:03AM -0800, Christoph Hellwig wrote:
> On Sat, Feb 27, 2016 at 06:18:55AM -0500, Tejun Heo wrote:
> > On Sat, Feb 27, 2016 at 12:51:54AM -0800, Christoph Hellwig wrote:
> > > On Fri, Feb 26, 2016 at 10:09:52AM -0800, scott.lawson@intel.com wrote:
> > > > From: Scott Lawson <scott.lawson@intel.com>
> > > > 
> > > > These PCI device IDs have been removed from the Intel Lewisburg design
> > > > specification. They are no longer needed.
> > > 
> > > Let's keep them just in case..
> > 
> > Out of curiosity, any specific reasons to do so?
> 
> If it's been added to the driver I'd expect at least prototype hardware
> to already be out there.

I see.  Scott, can you please clarify the situation?

Thanks.

-- 
tejun

RE: [PATCH] AHCI: Remove obsolete Intel Lewisburg SATA RAID device IDs

[Lawson, Scott]

Hello:

There shouldn't be any hardware dependencies on these device IDs out there. I've checked with the author of the specification these IDs are published in, and he said that they never corresponded to any existing or planned hardware. (That begs the question of why they appeared in an earlier version of the specification in the first place, but that's something we need work out internally.)

There really is no advantage to keeping them around, and no reasonable "just in case" scenario that they would be useful for.

-Scott Lawson 


-----Original Message-----
From: Tejun Heo [mailto:htejun@gmail.com] On Behalf Of Tejun Heo
Sent: Sunday, February 28, 2016 05:17
To: Christoph Hellwig <hch@infradead.org>
Cc: Lawson, Scott <scott.lawson@intel.com>; linux-ide@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH] AHCI: Remove obsolete Intel Lewisburg SATA RAID device IDs

Hello,

On Sun, Feb 28, 2016 at 05:10:03AM -0800, Christoph Hellwig wrote:
> On Sat, Feb 27, 2016 at 06:18:55AM -0500, Tejun Heo wrote:
> > On Sat, Feb 27, 2016 at 12:51:54AM -0800, Christoph Hellwig wrote:
> > > On Fri, Feb 26, 2016 at 10:09:52AM -0800, scott.lawson@intel.com wrote:
> > > > From: Scott Lawson <scott.lawson@intel.com>
> > > > 
> > > > These PCI device IDs have been removed from the Intel Lewisburg 
> > > > design specification. They are no longer needed.
> > > 
> > > Let's keep them just in case..
> > 
> > Out of curiosity, any specific reasons to do so?
> 
> If it's been added to the driver I'd expect at least prototype 
> hardware to already be out there.

I see.  Scott, can you please clarify the situation?

Thanks.

--
tejun

Re: [PATCH] AHCI: Remove obsolete Intel Lewisburg SATA RAID device IDs

[Tejun Heo]

On Fri, Feb 26, 2016 at 10:09:52AM -0800, scott.lawson@intel.com wrote:
> From: Scott Lawson <scott.lawson@intel.com>
> 
> These PCI device IDs have been removed from the Intel Lewisburg design
> specification. They are no longer needed.
> 
> Signed-off-by: Scott Lawson <scott.lawson@intel.com>

Applied to libata/for-4.6.

Thanks.

-- 
tejun