* [PATCH 2/2] Staging: nvec: fix multiline comment style.
@ 2016-03-10 7:12 Neha Rani
2016-03-11 21:21 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Neha Rani @ 2016-03-10 7:12 UTC (permalink / raw)
To: rneha725; +Cc: devel, linux-kernel
This is a patch in nvec.c file that fixes a multiline comment found by checkpatch.pl tool
Signed-off-by: Neha Rani <rneha725@gmail.com>
---
drivers/staging/nvec/nvec.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
index 4ae44a5..57ad27a 100644
--- a/drivers/staging/nvec/nvec.c
+++ b/drivers/staging/nvec/nvec.c
@@ -508,8 +508,10 @@ static void nvec_rx_completed(struct nvec_chip *nvec)
spin_lock(&nvec->rx_lock);
- /* add the received data to the work list
- and move the ring buffer pointer to the next entry */
+ /**
+ * add the received data to the work list
+ * and move the ring buffer pointer to the next entry
+ */
list_add_tail(&nvec->rx->node, &nvec->rx_data);
spin_unlock(&nvec->rx_lock);
--
2.5.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] Staging: nvec: fix multiline comment style.
2016-03-10 7:12 [PATCH 2/2] Staging: nvec: fix multiline comment style Neha Rani
@ 2016-03-11 21:21 ` Greg KH
[not found] ` <CAJ7rW_CRN+6ko5vhyv4hRW3mZgPwJ4Bba+uLOkqiUD8rsZtWnA@mail.gmail.com>
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2016-03-11 21:21 UTC (permalink / raw)
To: Neha Rani; +Cc: devel, linux-kernel
On Thu, Mar 10, 2016 at 12:42:29PM +0530, Neha Rani wrote:
> This is a patch in nvec.c file that fixes a multiline comment found by checkpatch.pl tool
>
> Signed-off-by: Neha Rani <rneha725@gmail.com>
> ---
> drivers/staging/nvec/nvec.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
> index 4ae44a5..57ad27a 100644
> --- a/drivers/staging/nvec/nvec.c
> +++ b/drivers/staging/nvec/nvec.c
> @@ -508,8 +508,10 @@ static void nvec_rx_completed(struct nvec_chip *nvec)
>
> spin_lock(&nvec->rx_lock);
>
> - /* add the received data to the work list
> - and move the ring buffer pointer to the next entry */
> + /**
One too many '*' characters here, sorry.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] Staging: nvec: fix multiline comment style.
[not found] ` <CAJ7rW_CRN+6ko5vhyv4hRW3mZgPwJ4Bba+uLOkqiUD8rsZtWnA@mail.gmail.com>
@ 2016-03-12 5:50 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2016-03-12 5:50 UTC (permalink / raw)
To: Neha Rani; +Cc: devel, linux-kernel
On Sat, Mar 12, 2016 at 10:32:49AM +0530, Neha Rani wrote:
> But it was warned by checkpatch.pl and after modifying, no warning. How can it
> be wrong?
I'll turn it around and ask you how do you know it is correct? :)
hint, it isn't, read Documentation/CodingStyle please.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-03-12 5:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-10 7:12 [PATCH 2/2] Staging: nvec: fix multiline comment style Neha Rani
2016-03-11 21:21 ` Greg KH
[not found] ` <CAJ7rW_CRN+6ko5vhyv4hRW3mZgPwJ4Bba+uLOkqiUD8rsZtWnA@mail.gmail.com>
2016-03-12 5:50 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).