From: Thierry Reding <treding@nvidia.com>
To: Andy Yan <andy.yan@kernel-upstream.org>
Cc: <arnd@arndb.de>, <javier@osg.samsung.com>, <kgene@kernel.org>,
<k.kozlowski@samsung.com>, <geert+renesas@glider.be>,
<linux-kernel@vger.kernel.org>, <public_timo.s@silentcreek.de>,
<linux@arm.linux.org.uk>, <alexandre.belloni@free-electrons.com>,
<sjoerd.simons@collabora.co.uk>, <olof@lixom.net>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/2] ARM: multi_v7_defconfig: enable CONFIG_REGULATOR_PWM=y
Date: Mon, 14 Mar 2016 13:21:05 +0100 [thread overview]
Message-ID: <20160314122104.GF22912@ulmo.nvidia.com> (raw)
In-Reply-To: <1457787100-9221-1-git-send-email-andy.yan@kernel-upstream.org>
[-- Attachment #1: Type: text/plain, Size: 838 bytes --]
On Sat, Mar 12, 2016 at 08:51:40PM +0800, Andy Yan wrote:
> Some platform like Rockchip rk3066 use pwm as a regulator to modulate
> cpu voltage, so pwm regulator should be enabled at system boot time if
> the system want to run with high frequency.
>
> Signed-off-by: Andy Yan <andy.yan@kernel-upstream.org>
> ---
>
> arch/arm/configs/multi_v7_defconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
This really belongs in patch 1/2. But then the same comments hold true
and I think you'll need to come up with a proper fix that prevents the
switch to a higher frequency if don't have the necessary regulator, or
make the Kconfig symbol bool if all else fails.
If you make the Kconfig symbol bool I'd expect a really good explanation
in the commit message as to why it can't be fixed properly.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-03-14 12:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-12 12:50 [PATCH 1/2] ARM: multi_v7_defconfig: enable CONFIG_PWM_ROCKCHIP=y Andy Yan
2016-03-12 12:51 ` [PATCH 2/2] ARM: multi_v7_defconfig: enable CONFIG_REGULATOR_PWM=y Andy Yan
2016-03-14 12:21 ` Thierry Reding [this message]
2016-03-14 12:18 ` [PATCH 1/2] ARM: multi_v7_defconfig: enable CONFIG_PWM_ROCKCHIP=y Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160314122104.GF22912@ulmo.nvidia.com \
--to=treding@nvidia.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=andy.yan@kernel-upstream.org \
--cc=arnd@arndb.de \
--cc=geert+renesas@glider.be \
--cc=javier@osg.samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=olof@lixom.net \
--cc=public_timo.s@silentcreek.de \
--cc=sjoerd.simons@collabora.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).