From: Al Viro <viro@ZenIV.linux.org.uk>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Benjamin LaHaise <bcrl@kvack.org>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: linux-next: manual merge of the aio tree with the vfs tree
Date: Tue, 15 Mar 2016 05:07:12 +0000 [thread overview]
Message-ID: <20160315050712.GF17997@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20160315043448.GE17997@ZenIV.linux.org.uk>
On Tue, Mar 15, 2016 at 04:34:48AM +0000, Al Viro wrote:
> Incidentally, why the hell has that thing never landed in my mailbox? Not
> directly, not Cc'd, not via fsdevel either.
>
> Ben, what the fuck going on? OK, you don't feel necessary to mention
> that to me (or have me take a look through it). Your business. You also
> don't bother to bring it on fsdevel. Again, your estimates of the
> usefulness of said list and review there are your business. But it looks
> like you also do not bother to check what has landed in the mainline two
> months ago. WTF?
While we are at it, aio.git commit in question is crap anyway. What is the
semantics of that LOOKUP_NONBLOCK thing and what makes you think that
it will *not* block prior to reaching do_last()? LOOKUP_RCU that was
originally there? Sorry, wrong. RCU pathwalk will happily fall back to
non-RCU one if it can do so without restart from scratch. And proceed
to lock directories, hit the disk over nbd over wet string, do automounts,
etc. Anything and everything. IOW, this is complete BS and had been such
for at least ~5 years.
There *is* a reason for code review. Or, at least, asking somebody familiar
with the code you are working with whether some assumption you are making
is true or false. Me, for example, in our conversation regarding earlier parts
of aio.git queue about a week ago. Or at any other point.
Al "Really annoyed" Viro
next prev parent reply other threads:[~2016-03-15 5:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-15 4:06 linux-next: manual merge of the aio tree with the vfs tree Stephen Rothwell
2016-03-15 4:34 ` Al Viro
2016-03-15 4:53 ` Stephen Rothwell
2016-03-15 5:07 ` Al Viro [this message]
2016-03-15 5:19 ` Al Viro
2016-03-15 13:12 ` Benjamin LaHaise
-- strict thread matches above, loose matches on Subject: below --
2017-09-11 1:29 Stephen Rothwell
2016-03-14 4:32 Stephen Rothwell
2016-03-14 4:36 ` Stephen Rothwell
2016-03-14 4:41 ` Stephen Rothwell
2016-03-14 7:35 ` Christoph Hellwig
2016-03-14 15:24 ` Benjamin LaHaise
2016-03-15 5:35 ` Al Viro
2016-03-15 13:24 ` Benjamin LaHaise
2016-03-15 8:37 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160315050712.GF17997@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=bcrl@kvack.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).