From: Benjamin LaHaise <bcrl@kvack.org>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: linux-next: manual merge of the aio tree with the vfs tree
Date: Tue, 15 Mar 2016 09:12:44 -0400 [thread overview]
Message-ID: <20160315131244.GM17923@kvack.org> (raw)
In-Reply-To: <20160315051939.GG17997@ZenIV.linux.org.uk>
On Tue, Mar 15, 2016 at 05:19:39AM +0000, Al Viro wrote:
> On Tue, Mar 15, 2016 at 05:07:12AM +0000, Al Viro wrote:
>
> > There *is* a reason for code review. Or, at least, asking somebody familiar
> > with the code you are working with whether some assumption you are making
> > is true or false. Me, for example, in our conversation regarding earlier parts
> > of aio.git queue about a week ago. Or at any other point.
>
> While we are at it, 150a0b49 ("aio: add support for async openat()") is also
> crap. fs_struct and files_struct is nowhere near enough. And yes, I realize
> that your application probably doesn't step into it. Which means that these
> patches are just fine for your private kernel. _Not_ for mainline.
>
> Reviewed-and-NAKed-by: Al Viro <viro@zeniv.linux.org.uk>
You've had two months to make this comment, so I'm glad you've finally
done so.
-ben
--
"Thought is the essence of where you are now."
next prev parent reply other threads:[~2016-03-15 13:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-15 4:06 linux-next: manual merge of the aio tree with the vfs tree Stephen Rothwell
2016-03-15 4:34 ` Al Viro
2016-03-15 4:53 ` Stephen Rothwell
2016-03-15 5:07 ` Al Viro
2016-03-15 5:19 ` Al Viro
2016-03-15 13:12 ` Benjamin LaHaise [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-09-11 1:29 Stephen Rothwell
2016-03-14 4:32 Stephen Rothwell
2016-03-14 4:36 ` Stephen Rothwell
2016-03-14 4:41 ` Stephen Rothwell
2016-03-14 7:35 ` Christoph Hellwig
2016-03-14 15:24 ` Benjamin LaHaise
2016-03-15 5:35 ` Al Viro
2016-03-15 13:24 ` Benjamin LaHaise
2016-03-15 8:37 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160315131244.GM17923@kvack.org \
--to=bcrl@kvack.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).