* [PATCH] bus: uniphier-system-bus: fix condition of overlap check
@ 2016-04-01 10:32 Kunihiko Hayashi
2016-04-07 13:59 ` Masahiro Yamada
0 siblings, 1 reply; 3+ messages in thread
From: Kunihiko Hayashi @ 2016-04-01 10:32 UTC (permalink / raw)
To: arm; +Cc: linux-arm-kernel, linux-kernel
This patch fixes condition whether the specified address ranges
overlap each other.
Fixes: 4b7f48d395a7 ("bus: uniphier-system-bus: add UniPhier System Bus driver")
Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
---
drivers/bus/uniphier-system-bus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bus/uniphier-system-bus.c b/drivers/bus/uniphier-system-bus.c
index 834a2ae..350b730 100644
--- a/drivers/bus/uniphier-system-bus.c
+++ b/drivers/bus/uniphier-system-bus.c
@@ -108,7 +108,7 @@ static int uniphier_system_bus_check_overlap(
for (i = 0; i < ARRAY_SIZE(priv->bank); i++) {
for (j = i + 1; j < ARRAY_SIZE(priv->bank); j++) {
- if (priv->bank[i].end > priv->bank[j].base ||
+ if (priv->bank[i].end > priv->bank[j].base &&
priv->bank[i].base < priv->bank[j].end) {
dev_err(priv->dev,
"region overlap between bank%d and bank%d\n",
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] bus: uniphier-system-bus: fix condition of overlap check
2016-04-01 10:32 [PATCH] bus: uniphier-system-bus: fix condition of overlap check Kunihiko Hayashi
@ 2016-04-07 13:59 ` Masahiro Yamada
2016-04-12 19:32 ` Olof Johansson
0 siblings, 1 reply; 3+ messages in thread
From: Masahiro Yamada @ 2016-04-07 13:59 UTC (permalink / raw)
To: Kunihiko Hayashi; +Cc: arm, Linux Kernel Mailing List, linux-arm-kernel
2016-04-01 19:32 GMT+09:00 Kunihiko Hayashi <hayashi.kunihiko@socionext.com>:
> This patch fixes condition whether the specified address ranges
> overlap each other.
>
> Fixes: 4b7f48d395a7 ("bus: uniphier-system-bus: add UniPhier System Bus driver")
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> ---
Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Arnd, Olof,
Could you pick up this bug-fix for v4.6, please?
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] bus: uniphier-system-bus: fix condition of overlap check
2016-04-07 13:59 ` Masahiro Yamada
@ 2016-04-12 19:32 ` Olof Johansson
0 siblings, 0 replies; 3+ messages in thread
From: Olof Johansson @ 2016-04-12 19:32 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Kunihiko Hayashi, arm, Linux Kernel Mailing List, linux-arm-kernel
On Thu, Apr 07, 2016 at 10:59:48PM +0900, Masahiro Yamada wrote:
> 2016-04-01 19:32 GMT+09:00 Kunihiko Hayashi <hayashi.kunihiko@socionext.com>:
> > This patch fixes condition whether the specified address ranges
> > overlap each other.
> >
> > Fixes: 4b7f48d395a7 ("bus: uniphier-system-bus: add UniPhier System Bus driver")
> > Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> > ---
>
> Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>
>
> Arnd, Olof,
>
> Could you pick up this bug-fix for v4.6, please?
Applied to fixes.
-Olof
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-04-12 19:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-01 10:32 [PATCH] bus: uniphier-system-bus: fix condition of overlap check Kunihiko Hayashi
2016-04-07 13:59 ` Masahiro Yamada
2016-04-12 19:32 ` Olof Johansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).