From: Andrew Lunn <andrew@lunn.ch>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@savoirfairelinux.com,
"David S. Miller" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Jiri Pirko <jiri@resnulli.us>, Scott Feldman <sfeldma@gmail.com>
Subject: Re: [PATCH net-next 2/3] net: dsa: make the FDB add function return void
Date: Wed, 6 Apr 2016 14:54:21 +0200 [thread overview]
Message-ID: <20160406125421.GF19409@lunn.ch> (raw)
In-Reply-To: <87egajxwb5.fsf@ketchup.mtl.sfl>
On Tue, Apr 05, 2016 at 11:14:54PM -0400, Vivien Didelot wrote:
> Hi Andrew,
>
> Andrew Lunn <andrew@lunn.ch> writes:
>
> >> mutex_lock(&ps->smi_mutex);
> >> - ret = _mv88e6xxx_port_fdb_load(ds, port, fdb->addr, fdb->vid, state);
> >> + if (_mv88e6xxx_port_fdb_load(ds, port, fdb->addr, fdb->vid, state))
> >> + netdev_warn(ds->ports[port], "cannot load address\n");
> >
> > In the SF2 driver you use pr_err, but here netdev_warn. We probably
> > should be consistent if we error or warn. I would use netdev_error,
> > since if this fails we probably have a real hardware problem.
>
> I used pr_err in the SF2 driver to be consistent with the rest of the
> code which only uses pr_err and pr_info.
O.K, good.
> I was thinking about adding ds_err and ds_port_err to print errors for
> ds->master_dev and ds->ports[port], but that might be overkill.
I'm also trying to kill off the use of ds within the mv88e6xxx driver.
> What do you think? Or local to the driver for the moment, like
> mvsw_err maybe?
I would keep it local. Also, for this sort of error, it does not need
to differentiate on port. It is a hardware access error, something is
wrong with the mdio bus/switch. So i would even put the message in the
very low level reg_read/reg_write functions, and no where else.
Andrew
next prev parent reply other threads:[~2016-04-06 12:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-05 15:24 [PATCH net-next 1/3] net: dsa: make the STP state function return void Vivien Didelot
2016-04-05 15:24 ` [PATCH net-next 2/3] net: dsa: make the FDB add " Vivien Didelot
2016-04-05 23:51 ` Andrew Lunn
2016-04-06 3:14 ` Vivien Didelot
2016-04-06 12:54 ` Andrew Lunn [this message]
2016-04-06 14:26 ` Vivien Didelot
2016-04-05 15:24 ` [PATCH net-next 3/3] net: dsa: make the VLAN " Vivien Didelot
2016-04-05 23:47 ` [PATCH net-next 1/3] net: dsa: make the STP state " Andrew Lunn
2016-04-06 3:16 ` Vivien Didelot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160406125421.GF19409@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=jiri@resnulli.us \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sfeldma@gmail.com \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).