* [PATCH] cpufreq: tegra124: No need of setting platform-data
@ 2016-03-29 14:05 Viresh Kumar
2016-04-07 8:21 ` Viresh Kumar
2016-04-07 11:41 ` Thierry Reding
0 siblings, 2 replies; 3+ messages in thread
From: Viresh Kumar @ 2016-03-29 14:05 UTC (permalink / raw)
To: Rafael Wysocki, ttynkkynen, Viresh Kumar, Stephen Warren,
Thierry Reding, Alexandre Courbot
Cc: linaro-kernel, linux-pm, linux-tegra, linux-kernel
All CPUs on Tegra platform share clock/voltage lines and there is
absolutely no need of setting platform data for 'cpufreq-dt' platform
device, as that's the default case.
Stop setting platform data for cpufreq-dt device.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
Only compile tested.
drivers/cpufreq/tegra124-cpufreq.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/cpufreq/tegra124-cpufreq.c b/drivers/cpufreq/tegra124-cpufreq.c
index 20bcceb58ccc..43530254201a 100644
--- a/drivers/cpufreq/tegra124-cpufreq.c
+++ b/drivers/cpufreq/tegra124-cpufreq.c
@@ -14,7 +14,6 @@
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
#include <linux/clk.h>
-#include <linux/cpufreq-dt.h>
#include <linux/err.h>
#include <linux/init.h>
#include <linux/kernel.h>
@@ -69,10 +68,6 @@ static void tegra124_cpu_switch_to_pllx(struct tegra124_cpufreq_priv *priv)
clk_set_parent(priv->cpu_clk, priv->pllx_clk);
}
-static struct cpufreq_dt_platform_data cpufreq_dt_pd = {
- .independent_clocks = false,
-};
-
static int tegra124_cpufreq_probe(struct platform_device *pdev)
{
struct tegra124_cpufreq_priv *priv;
@@ -129,8 +124,6 @@ static int tegra124_cpufreq_probe(struct platform_device *pdev)
cpufreq_dt_devinfo.name = "cpufreq-dt";
cpufreq_dt_devinfo.parent = &pdev->dev;
- cpufreq_dt_devinfo.data = &cpufreq_dt_pd;
- cpufreq_dt_devinfo.size_data = sizeof(cpufreq_dt_pd);
priv->cpufreq_dt_pdev =
platform_device_register_full(&cpufreq_dt_devinfo);
--
2.7.1.410.g6faf27b
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] cpufreq: tegra124: No need of setting platform-data
2016-03-29 14:05 [PATCH] cpufreq: tegra124: No need of setting platform-data Viresh Kumar
@ 2016-04-07 8:21 ` Viresh Kumar
2016-04-07 11:41 ` Thierry Reding
1 sibling, 0 replies; 3+ messages in thread
From: Viresh Kumar @ 2016-04-07 8:21 UTC (permalink / raw)
To: Rafael Wysocki, ttynkkynen, Stephen Warren, Thierry Reding,
Alexandre Courbot
Cc: linaro-kernel, linux-pm, linux-tegra, linux-kernel
On 29-03-16, 19:35, Viresh Kumar wrote:
> All CPUs on Tegra platform share clock/voltage lines and there is
> absolutely no need of setting platform data for 'cpufreq-dt' platform
> device, as that's the default case.
>
> Stop setting platform data for cpufreq-dt device.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> Only compile tested.
>
> drivers/cpufreq/tegra124-cpufreq.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/cpufreq/tegra124-cpufreq.c b/drivers/cpufreq/tegra124-cpufreq.c
> index 20bcceb58ccc..43530254201a 100644
> --- a/drivers/cpufreq/tegra124-cpufreq.c
> +++ b/drivers/cpufreq/tegra124-cpufreq.c
> @@ -14,7 +14,6 @@
> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
>
> #include <linux/clk.h>
> -#include <linux/cpufreq-dt.h>
> #include <linux/err.h>
> #include <linux/init.h>
> #include <linux/kernel.h>
> @@ -69,10 +68,6 @@ static void tegra124_cpu_switch_to_pllx(struct tegra124_cpufreq_priv *priv)
> clk_set_parent(priv->cpu_clk, priv->pllx_clk);
> }
>
> -static struct cpufreq_dt_platform_data cpufreq_dt_pd = {
> - .independent_clocks = false,
> -};
> -
> static int tegra124_cpufreq_probe(struct platform_device *pdev)
> {
> struct tegra124_cpufreq_priv *priv;
> @@ -129,8 +124,6 @@ static int tegra124_cpufreq_probe(struct platform_device *pdev)
>
> cpufreq_dt_devinfo.name = "cpufreq-dt";
> cpufreq_dt_devinfo.parent = &pdev->dev;
> - cpufreq_dt_devinfo.data = &cpufreq_dt_pd;
> - cpufreq_dt_devinfo.size_data = sizeof(cpufreq_dt_pd);
>
> priv->cpufreq_dt_pdev =
> platform_device_register_full(&cpufreq_dt_devinfo);
Ping !!
--
viresh
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] cpufreq: tegra124: No need of setting platform-data
2016-03-29 14:05 [PATCH] cpufreq: tegra124: No need of setting platform-data Viresh Kumar
2016-04-07 8:21 ` Viresh Kumar
@ 2016-04-07 11:41 ` Thierry Reding
1 sibling, 0 replies; 3+ messages in thread
From: Thierry Reding @ 2016-04-07 11:41 UTC (permalink / raw)
To: Viresh Kumar
Cc: Rafael Wysocki, ttynkkynen, Stephen Warren, Alexandre Courbot,
linaro-kernel, linux-pm, linux-tegra, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 631 bytes --]
On Tue, Mar 29, 2016 at 07:35:12PM +0530, Viresh Kumar wrote:
> All CPUs on Tegra platform share clock/voltage lines and there is
> absolutely no need of setting platform data for 'cpufreq-dt' platform
> device, as that's the default case.
>
> Stop setting platform data for cpufreq-dt device.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> Only compile tested.
>
> drivers/cpufreq/tegra124-cpufreq.c | 7 -------
> 1 file changed, 7 deletions(-)
Everything seems to be working fine after this:
Tested-by: Thierry Reding <treding@nvidia.com>
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-04-07 11:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-29 14:05 [PATCH] cpufreq: tegra124: No need of setting platform-data Viresh Kumar
2016-04-07 8:21 ` Viresh Kumar
2016-04-07 11:41 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).