From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: rcochran@linutronix.de
Cc: "Brown, Len" <len.brown@intel.com>,
"Gortmaker, Paul (Wind River)" <paul.gortmaker@windriver.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Len Brown <lenb@kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: Re: [PATCH] drivers/idle: make intel_idle.c driver more explicitly non-modular
Date: Thu, 7 Apr 2016 17:53:55 +0100 [thread overview]
Message-ID: <20160407165355.GA9188@linaro.org> (raw)
In-Reply-To: <20160405073312.GA30124@linutronix.de>
On Tue, Apr 05, 2016 at 09:33:12AM +0200, rcochran@linutronix.de wrote:
> On Tue, Apr 05, 2016 at 05:53:47AM +0000, Brown, Len wrote:
> > > On Tue, Apr 05, 2016 at 04:20:47AM +0000, Brown, Len wrote:
> > > > No, I do not believe that cpuidle should bother
> > > > supporting changing idle drivers at run-time.
> > >
> > > Huh? But you just said, "it would be good to be able to unload it
> > > when it doesn't probe."
> >
> > being able to switch the registered driver at run-time
> > does not require the driver to be modular.
>
> Uh, right, but you don't think that the cpuidle core should allow
> changing drivers. If it doesn't allowing changing drivers, then there
> would be just one choice, compiled in, and thus none of the drivers
> should be modular.
Actually, the modular support has been removed from almost all the cpuidle
drivers and the cpuidle framework is no longer assuming driver could
be unloaded.
The cpuidle drivers are very arch/platform specific and the acpi vs
something is an exception and could be handled differently than
converting to modular again.
I don't see the point on removing a cpuidle driver at runtime to
something else.
Removing the modular dead code in the driver makes sense as this
what have been done in the others drivers.
-- Daniel
next prev parent reply other threads:[~2016-04-07 16:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-27 17:29 [PATCH] drivers/idle: make intel_idle.c driver more explicitly non-modular Paul Gortmaker
2016-04-04 19:55 ` Paul Gortmaker
2016-04-05 3:11 ` rcochran
2016-04-05 4:20 ` Brown, Len
2016-04-05 4:30 ` rcochran
2016-04-05 5:53 ` Brown, Len
2016-04-05 7:33 ` rcochran
2016-04-07 16:53 ` Daniel Lezcano [this message]
2016-04-20 15:25 ` [PATCH v2] " Paul Gortmaker
2016-04-20 18:13 ` Daniel Lezcano
2016-04-21 3:12 ` Paul Gortmaker
2016-04-21 8:04 ` Daniel Lezcano
2016-04-21 12:44 ` Paul Gortmaker
2016-04-21 13:21 ` Daniel Lezcano
2016-04-21 17:42 ` Paul Gortmaker
2016-06-16 5:00 ` Len Brown
2016-04-05 18:22 ` [PATCH] " Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160407165355.GA9188@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=len.brown@intel.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=rcochran@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).