From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: linux-kernel@vger.kernel.org, Len Brown <len.brown@intel.com>,
rcochran@linutronix.de, linux-pm@vger.kernel.org
Subject: Re: [PATCH v2] drivers/idle: make intel_idle.c driver more explicitly non-modular
Date: Thu, 21 Apr 2016 15:21:37 +0200 [thread overview]
Message-ID: <20160421132137.GA18670@linaro.org> (raw)
In-Reply-To: <20160421124454.GJ13379@windriver.com>
On Thu, Apr 21, 2016 at 08:44:55AM -0400, Paul Gortmaker wrote:
> [Re: [PATCH v2] drivers/idle: make intel_idle.c driver more explicitly non-modular] On 21/04/2016 (Thu 10:04) Daniel Lezcano wrote:
>
> > On Wed, Apr 20, 2016 at 11:12:49PM -0400, Paul Gortmaker wrote:
> >
> > [ ... ]
> >
> > > > > We replace module.h with moduleparam.h since the file does declare
> > > > > some module parameters, and leaving them as such is currently the
> > > > > easiest way to remain compatible with existing boot arg use cases.
> > > >
> > > > What about using __setup() ? so module* disappear from the file.
> > >
> > > No, it can't be __setup since moduleparam uses an instance of the
> > > filename as a prefix to the boot arg, and __setup does not. And we
> > > should stay compatible with existing boot arg use cases for people
> > > who have embedded such a setting in their grub config a long time
> > > ago and forgot it. It would take looking at and likely extending the
> > > early_param macro to provide a syntax compatible instance of what
> > > the module_param currently does if I recall correctly -- hence the
> > > above comment in the commit log.
> >
> > -module_param(max_cstate, int, 0444);
> > +static int __init max_cstate_param(char *str)
> > +{
> > + max_cstate = simple_strtol(str, NULL, 0);
> > + return 1;
> > +}
> > +__setup("intel_idle.max_cstate=", max_cstate_param);
>
> Yeah, I recall thinking it would be that easy too, but there was
> something that happens when you manually insert the dot in there that
> breaks processing. I'd have to re-test to remind myself what failed.
Ok.
I quickly tested this code snippet and, except I missed something, it
worked.
That said, I looked around and found that using module_param() for
non-modular is found in several places, so it is common. I don't like to
find references to modular code when the the caller is not supposed to be
modular but that's the situation today.
So I will let Len and you decice what to do ;)
Other than that: Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
next prev parent reply other threads:[~2016-04-21 13:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-27 17:29 [PATCH] drivers/idle: make intel_idle.c driver more explicitly non-modular Paul Gortmaker
2016-04-04 19:55 ` Paul Gortmaker
2016-04-05 3:11 ` rcochran
2016-04-05 4:20 ` Brown, Len
2016-04-05 4:30 ` rcochran
2016-04-05 5:53 ` Brown, Len
2016-04-05 7:33 ` rcochran
2016-04-07 16:53 ` Daniel Lezcano
2016-04-20 15:25 ` [PATCH v2] " Paul Gortmaker
2016-04-20 18:13 ` Daniel Lezcano
2016-04-21 3:12 ` Paul Gortmaker
2016-04-21 8:04 ` Daniel Lezcano
2016-04-21 12:44 ` Paul Gortmaker
2016-04-21 13:21 ` Daniel Lezcano [this message]
2016-04-21 17:42 ` Paul Gortmaker
2016-06-16 5:00 ` Len Brown
2016-04-05 18:22 ` [PATCH] " Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160421132137.GA18670@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=rcochran@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).