* [patch] bnx2i: silence uninitialized variable warnings
@ 2016-04-14 9:40 Dan Carpenter
2016-04-18 5:17 ` Nilesh Javali
2016-04-26 2:03 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2016-04-14 9:40 UTC (permalink / raw)
To: QLogic-Storage-Upstream
Cc: James E.J. Bottomley, Martin K. Petersen, linux-scsi,
linux-kernel, kernel-janitors
Presumably it isn't possible to have empty lists here, but my static
checker doesn't know that and complains that "ep" can be used
uninitialized.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/scsi/bnx2i/bnx2i_iscsi.c b/drivers/scsi/bnx2i/bnx2i_iscsi.c
index 7289437..133901f 100644
--- a/drivers/scsi/bnx2i/bnx2i_iscsi.c
+++ b/drivers/scsi/bnx2i/bnx2i_iscsi.c
@@ -675,7 +675,7 @@ bnx2i_find_ep_in_ofld_list(struct bnx2i_hba *hba, u32 iscsi_cid)
{
struct list_head *list;
struct list_head *tmp;
- struct bnx2i_endpoint *ep;
+ struct bnx2i_endpoint *ep = NULL;
read_lock_bh(&hba->ep_rdwr_lock);
list_for_each_safe(list, tmp, &hba->ep_ofld_list) {
@@ -703,7 +703,7 @@ bnx2i_find_ep_in_destroy_list(struct bnx2i_hba *hba, u32 iscsi_cid)
{
struct list_head *list;
struct list_head *tmp;
- struct bnx2i_endpoint *ep;
+ struct bnx2i_endpoint *ep = NULL;
read_lock_bh(&hba->ep_rdwr_lock);
list_for_each_safe(list, tmp, &hba->ep_destroy_list) {
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [patch] bnx2i: silence uninitialized variable warnings
2016-04-14 9:40 [patch] bnx2i: silence uninitialized variable warnings Dan Carpenter
@ 2016-04-18 5:17 ` Nilesh Javali
2016-04-26 2:03 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Nilesh Javali @ 2016-04-18 5:17 UTC (permalink / raw)
To: Dan Carpenter, Dept-Eng QLogic Storage Upstream
Cc: James E.J. Bottomley, Martin K. Petersen, linux-scsi,
linux-kernel, kernel-janitors
On 14/04/16 3:10 PM, "Dan Carpenter" <dan.carpenter@oracle.com> wrote:
>Presumably it isn't possible to have empty lists here, but my static
>checker doesn't know that and complains that "ep" can be used
>uninitialized.
>
>Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
>diff --git a/drivers/scsi/bnx2i/bnx2i_iscsi.c
>b/drivers/scsi/bnx2i/bnx2i_iscsi.c
>index 7289437..133901f 100644
>--- a/drivers/scsi/bnx2i/bnx2i_iscsi.c
>+++ b/drivers/scsi/bnx2i/bnx2i_iscsi.c
>@@ -675,7 +675,7 @@ bnx2i_find_ep_in_ofld_list(struct bnx2i_hba *hba, u32
>iscsi_cid)
> {
> struct list_head *list;
> struct list_head *tmp;
>- struct bnx2i_endpoint *ep;
>+ struct bnx2i_endpoint *ep = NULL;
>
> read_lock_bh(&hba->ep_rdwr_lock);
> list_for_each_safe(list, tmp, &hba->ep_ofld_list) {
>@@ -703,7 +703,7 @@ bnx2i_find_ep_in_destroy_list(struct bnx2i_hba *hba,
>u32 iscsi_cid)
> {
> struct list_head *list;
> struct list_head *tmp;
>- struct bnx2i_endpoint *ep;
>+ struct bnx2i_endpoint *ep = NULL;
>
> read_lock_bh(&hba->ep_rdwr_lock);
> list_for_each_safe(list, tmp, &hba->ep_destroy_list) {
Acked-by: Nilesh Javali <nilesh.javali@qlogic.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] bnx2i: silence uninitialized variable warnings
2016-04-14 9:40 [patch] bnx2i: silence uninitialized variable warnings Dan Carpenter
2016-04-18 5:17 ` Nilesh Javali
@ 2016-04-26 2:03 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2016-04-26 2:03 UTC (permalink / raw)
To: Dan Carpenter
Cc: QLogic-Storage-Upstream, James E.J. Bottomley,
Martin K. Petersen, linux-scsi, linux-kernel, kernel-janitors
>>>>> "Dan" == Dan Carpenter <dan.carpenter@oracle.com> writes:
Dan> Presumably it isn't possible to have empty lists here, but my
Dan> static checker doesn't know that and complains that "ep" can be
Dan> used uninitialized.
Applied to 4.7/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-04-26 2:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-14 9:40 [patch] bnx2i: silence uninitialized variable warnings Dan Carpenter
2016-04-18 5:17 ` Nilesh Javali
2016-04-26 2:03 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).