* [PATCH] drm/vc4: Add missing render node support
@ 2016-04-20 22:20 Eric Anholt
2016-04-21 7:24 ` Daniel Vetter
0 siblings, 1 reply; 2+ messages in thread
From: Eric Anholt @ 2016-04-20 22:20 UTC (permalink / raw)
To: dri-devel; +Cc: linux-kernel, David Airlie, Eric Anholt
There shouldn't be any other driver support necessary, since none of
the driver-specific ioctls ever required auth, and none of them deal
with modesetting.
Signed-off-by: Eric Anholt <eric@anholt.net>
---
drivers/gpu/drm/vc4/vc4_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c
index 54f9f52fa004..143dd98aa079 100644
--- a/drivers/gpu/drm/vc4/vc4_drv.c
+++ b/drivers/gpu/drm/vc4/vc4_drv.c
@@ -81,6 +81,7 @@ static struct drm_driver vc4_drm_driver = {
DRIVER_ATOMIC |
DRIVER_GEM |
DRIVER_HAVE_IRQ |
+ DRIVER_RENDER |
DRIVER_PRIME),
.lastclose = vc4_lastclose,
.irq_handler = vc4_irq,
--
2.8.0.rc3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/vc4: Add missing render node support
2016-04-20 22:20 [PATCH] drm/vc4: Add missing render node support Eric Anholt
@ 2016-04-21 7:24 ` Daniel Vetter
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Vetter @ 2016-04-21 7:24 UTC (permalink / raw)
To: Eric Anholt; +Cc: dri-devel, linux-kernel
On Wed, Apr 20, 2016 at 03:20:49PM -0700, Eric Anholt wrote:
> There shouldn't be any other driver support necessary, since none of
> the driver-specific ioctls ever required auth, and none of them deal
> with modesetting.
Indeed, somehow I thought you need to mark them all up explicitly. But
that's only the case for DRM_AUTH ioctls.
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Aside: I wonder whether we should go through all the drivers and replace
DRM_AUTH | DRM_RENDER_ALLOW with 0? It looks a bit like drm ioctl flags
are cargo culted ...
-Daniel
>
> Signed-off-by: Eric Anholt <eric@anholt.net>
> ---
> drivers/gpu/drm/vc4/vc4_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c
> index 54f9f52fa004..143dd98aa079 100644
> --- a/drivers/gpu/drm/vc4/vc4_drv.c
> +++ b/drivers/gpu/drm/vc4/vc4_drv.c
> @@ -81,6 +81,7 @@ static struct drm_driver vc4_drm_driver = {
> DRIVER_ATOMIC |
> DRIVER_GEM |
> DRIVER_HAVE_IRQ |
> + DRIVER_RENDER |
> DRIVER_PRIME),
> .lastclose = vc4_lastclose,
> .irq_handler = vc4_irq,
> --
> 2.8.0.rc3
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-04-21 7:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-20 22:20 [PATCH] drm/vc4: Add missing render node support Eric Anholt
2016-04-21 7:24 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).