From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
David Ahern <dsahern@gmail.com>,
Peter Zijlstra <peterz@infradead.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Brendan Gregg <brendan.d.gregg@gmail.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Alexei Starovoitov <ast@kernel.org>,
He Kuang <hekuang@huawei.com>, Jiri Olsa <jolsa@redhat.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Milian Wolff <milian.wolff@kdab.com>,
Namhyung Kim <namhyung@kernel.org>,
Stephane Eranian <eranian@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
Vince Weaver <vincent.weaver@maine.edu>,
Wang Nan <wangnan0@huawei.com>, Zefan Li <lizefan@huawei.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH/RFC v3] perf core: Allow setting up max frame stack depth via sysctl
Date: Mon, 25 Apr 2016 21:47:47 -0300 [thread overview]
Message-ID: <20160426004747.GC16708@kernel.org> (raw)
In-Reply-To: <20160426004358.GA29875@ast-mbp.thefacebook.com>
Em Mon, Apr 25, 2016 at 05:44:00PM -0700, Alexei Starovoitov escreveu:
> On Mon, Apr 25, 2016 at 09:29:28PM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Mon, Apr 25, 2016 at 05:07:26PM -0700, Alexei Starovoitov escreveu:
> > > > + {
> > > > + .procname = "perf_event_max_stack",
> > > > + .data = NULL, /* filled in by handler */
> > > > + .maxlen = sizeof(sysctl_perf_event_max_stack),
> > > > + .mode = 0644,
> > > > + .proc_handler = perf_event_max_stack_handler,
> > > > + .extra1 = &zero,
> > > > + },
> >
> > > you need to define a max value otherwise perf_callchain_entry__sizeof
> > > will overflow. Sure it's root only facility, but still not nice.
> > > 1M? Anything above 1M stack frames would be insane anyway.
> > > The rest looks good. Thanks!
> >
> > Something else? ;-)
>
> all looks good to me. Thanks a bunch!
Thanks for checking!
> > Because we only allocate the callchain percpu data structures when there
> > is a user, which allows for changing the max easily, its just a matter
> > of having no callchain users at that point.
> >
> > Reported-and-Tested-by: Brendan Gregg <brendan.d.gregg@gmail.com>
> > Acked-by: Alexei Starovoitov <ast@kernel.org>
>
> yep :)
> hopefully Brendan can give it another spin.
Agreed, and I'm calling it a day anyway, Brendan, please consider
retesting, thanks,
- Arnaldo
next prev parent reply other threads:[~2016-04-26 0:47 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-20 22:47 [PATCH/RFC] perf core: Allow setting up max frame stack depth via sysctl Arnaldo Carvalho de Melo
2016-04-20 23:04 ` Alexei Starovoitov
2016-04-22 20:52 ` [PATCH/RFC v2] " Arnaldo Carvalho de Melo
2016-04-22 21:37 ` Alexei Starovoitov
2016-04-22 22:05 ` David Ahern
2016-04-22 22:18 ` Alexei Starovoitov
2016-04-25 16:14 ` Arnaldo Carvalho de Melo
2016-04-25 16:27 ` Arnaldo Carvalho de Melo
2016-04-25 19:22 ` Arnaldo Carvalho de Melo
2016-04-25 20:06 ` Alexei Starovoitov
2016-04-25 20:17 ` Arnaldo Carvalho de Melo
2016-04-25 21:59 ` Alexei Starovoitov
2016-04-25 23:41 ` Arnaldo Carvalho de Melo
2016-04-26 0:07 ` Alexei Starovoitov
2016-04-26 0:29 ` [PATCH/RFC v3] " Arnaldo Carvalho de Melo
2016-04-26 0:44 ` Alexei Starovoitov
2016-04-26 0:47 ` Arnaldo Carvalho de Melo [this message]
2016-04-26 0:49 ` Brendan Gregg
2016-04-26 16:33 ` Arnaldo Carvalho de Melo
2016-04-26 16:45 ` David Ahern
2016-04-27 13:20 ` Arnaldo Carvalho de Melo
2016-04-26 20:02 ` Brendan Gregg
2016-04-26 21:05 ` Arnaldo Carvalho de Melo
2016-04-26 21:55 ` Peter Zijlstra
2016-04-27 12:53 ` Arnaldo Carvalho de Melo
2016-04-26 21:58 ` Brendan Gregg
2016-04-26 22:10 ` Peter Zijlstra
2016-04-27 12:56 ` Arnaldo Carvalho de Melo
2016-04-26 21:58 ` Frederic Weisbecker
2016-04-27 12:53 ` Arnaldo Carvalho de Melo
2016-04-27 16:09 ` Frederic Weisbecker
2016-04-27 16:27 ` David Ahern
2016-04-27 15:39 ` [tip:perf/core] " tip-bot for Arnaldo Carvalho de Melo
2016-04-20 23:10 ` [PATCH/RFC] " David Ahern
2016-04-21 0:18 ` Arnaldo Carvalho de Melo
2016-04-21 10:48 ` Peter Zijlstra
2016-04-21 15:17 ` Arnaldo Carvalho de Melo
2016-04-21 15:42 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160426004747.GC16708@kernel.org \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexei.starovoitov@gmail.com \
--cc=arnaldo.melo@gmail.com \
--cc=ast@kernel.org \
--cc=brendan.d.gregg@gmail.com \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=hekuang@huawei.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=mhiramat@kernel.org \
--cc=milian.wolff@kdab.com \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=vincent.weaver@maine.edu \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).