* [PATCH 1/4] f2fs: fix to clear private data in page
@ 2016-04-28 15:13 Chao Yu
2016-04-28 23:29 ` Jaegeuk Kim
0 siblings, 1 reply; 4+ messages in thread
From: Chao Yu @ 2016-04-28 15:13 UTC (permalink / raw)
To: Jaegeuk Kim; +Cc: linux-f2fs-devel, linux-kernel
From: Chao Yu <yuchao0@huawei.com>
Private data in page should be removed during ->releasepage or
->invalidatepage, otherwise garbage data would be remained in that page.
Signed-off-by: Chao Yu <yuchao0@huawei.com>
---
fs/f2fs/data.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index 38ce5d6..888f178 100644
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -1723,6 +1723,7 @@ void f2fs_invalidate_page(struct page *page, unsigned int
offset,
if (IS_ATOMIC_WRITTEN_PAGE(page))
return;
+ set_page_private(page, 0);
ClearPagePrivate(page);
}
@@ -1736,6 +1737,7 @@ int f2fs_release_page(struct page *page, gfp_t wait)
if (IS_ATOMIC_WRITTEN_PAGE(page))
return 0;
+ set_page_private(page, 0);
ClearPagePrivate(page);
return 1;
}
--
2.7.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/4] f2fs: fix to clear private data in page
2016-04-28 15:13 [PATCH 1/4] f2fs: fix to clear private data in page Chao Yu
@ 2016-04-28 23:29 ` Jaegeuk Kim
2016-04-29 11:19 ` Chao Yu
0 siblings, 1 reply; 4+ messages in thread
From: Jaegeuk Kim @ 2016-04-28 23:29 UTC (permalink / raw)
To: Chao Yu; +Cc: linux-f2fs-devel, linux-kernel
Hi Chao,
Could you check your email setting?
All the patches are corrupted, as git am says.
Thanks,
On Thu, Apr 28, 2016 at 11:13:48PM +0800, Chao Yu wrote:
> From: Chao Yu <yuchao0@huawei.com>
>
> Private data in page should be removed during ->releasepage or
> ->invalidatepage, otherwise garbage data would be remained in that page.
>
> Signed-off-by: Chao Yu <yuchao0@huawei.com>
> ---
> fs/f2fs/data.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
> index 38ce5d6..888f178 100644
> --- a/fs/f2fs/data.c
> +++ b/fs/f2fs/data.c
> @@ -1723,6 +1723,7 @@ void f2fs_invalidate_page(struct page *page, unsigned int
> offset,
> if (IS_ATOMIC_WRITTEN_PAGE(page))
> return;
>
> + set_page_private(page, 0);
> ClearPagePrivate(page);
> }
>
> @@ -1736,6 +1737,7 @@ int f2fs_release_page(struct page *page, gfp_t wait)
> if (IS_ATOMIC_WRITTEN_PAGE(page))
> return 0;
>
> + set_page_private(page, 0);
> ClearPagePrivate(page);
> return 1;
> }
> --
> 2.7.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/4] f2fs: fix to clear private data in page
2016-04-28 23:29 ` Jaegeuk Kim
@ 2016-04-29 11:19 ` Chao Yu
0 siblings, 0 replies; 4+ messages in thread
From: Chao Yu @ 2016-04-29 11:19 UTC (permalink / raw)
To: Jaegeuk Kim; +Cc: linux-f2fs-devel, linux-kernel
Hi Jaegeuk,
On 2016/4/29 7:29, Jaegeuk Kim wrote:
> Hi Chao,
>
> Could you check your email setting?
> All the patches are corrupted, as git am says.
My bad, I use thunderbird for sending patches, but yesterday I upgrade it to
version 45.0, it forces wrapping long line for email content, so the patches
become corrupted to git-am.
Later, I will resend them.
Thanks,
>
> Thanks,
>
> On Thu, Apr 28, 2016 at 11:13:48PM +0800, Chao Yu wrote:
>> From: Chao Yu <yuchao0@huawei.com>
>>
>> Private data in page should be removed during ->releasepage or
>> ->invalidatepage, otherwise garbage data would be remained in that page.
>>
>> Signed-off-by: Chao Yu <yuchao0@huawei.com>
>> ---
>> fs/f2fs/data.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
>> index 38ce5d6..888f178 100644
>> --- a/fs/f2fs/data.c
>> +++ b/fs/f2fs/data.c
>> @@ -1723,6 +1723,7 @@ void f2fs_invalidate_page(struct page *page, unsigned int
>> offset,
>> if (IS_ATOMIC_WRITTEN_PAGE(page))
>> return;
>>
>> + set_page_private(page, 0);
>> ClearPagePrivate(page);
>> }
>>
>> @@ -1736,6 +1737,7 @@ int f2fs_release_page(struct page *page, gfp_t wait)
>> if (IS_ATOMIC_WRITTEN_PAGE(page))
>> return 0;
>>
>> + set_page_private(page, 0);
>> ClearPagePrivate(page);
>> return 1;
>> }
>> --
>> 2.7.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/4] f2fs: fix to clear private data in page
@ 2016-04-29 12:09 Chao Yu
0 siblings, 0 replies; 4+ messages in thread
From: Chao Yu @ 2016-04-29 12:09 UTC (permalink / raw)
To: jaegeuk; +Cc: linux-f2fs-devel, linux-kernel, Chao Yu
From: Chao Yu <yuchao0@huawei.com>
Private data in page should be removed during ->releasepage or
->invalidatepage, otherwise garbage data would be remained in that page.
Signed-off-by: Chao Yu <yuchao0@huawei.com>
---
fs/f2fs/data.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index 38ce5d6..888f178 100644
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -1723,6 +1723,7 @@ void f2fs_invalidate_page(struct page *page, unsigned int offset,
if (IS_ATOMIC_WRITTEN_PAGE(page))
return;
+ set_page_private(page, 0);
ClearPagePrivate(page);
}
@@ -1736,6 +1737,7 @@ int f2fs_release_page(struct page *page, gfp_t wait)
if (IS_ATOMIC_WRITTEN_PAGE(page))
return 0;
+ set_page_private(page, 0);
ClearPagePrivate(page);
return 1;
}
--
2.7.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-04-29 12:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-28 15:13 [PATCH 1/4] f2fs: fix to clear private data in page Chao Yu
2016-04-28 23:29 ` Jaegeuk Kim
2016-04-29 11:19 ` Chao Yu
2016-04-29 12:09 Chao Yu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).