From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
To: Hillf Danton <hillf.zj@alibaba-inc.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 01/13] staging/android: remove redundant comments on sync_merge_data
Date: Fri, 29 Apr 2016 10:30:23 -0300 [thread overview]
Message-ID: <20160429133023.GC2524@joana> (raw)
In-Reply-To: <00d801d1a1ec$3f573a50$be05aef0$@alibaba-inc.com>
Hi Hillf,
2016-04-29 Hillf Danton <hillf.zj@alibaba-inc.com>:
> >
> > From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> >
> > struct sync_merge_data already have documentation on top of the
> > struct definition. No need to duplicate it.
> >
> > Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> > Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> > ---
> > drivers/staging/android/uapi/sync.h | 10 +++++-----
> > 1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/staging/android/uapi/sync.h b/drivers/staging/android/uapi/sync.h
> > index 7de5d6a..413303d 100644
> > --- a/drivers/staging/android/uapi/sync.h
> > +++ b/drivers/staging/android/uapi/sync.h
> > @@ -23,9 +23,9 @@
> > * @pad: padding for 64-bit alignment, should always be zero
> > */
> > struct sync_merge_data {
> > - char name[32]; /* name of new fence */
> > - __s32 fd2; /* fd of second fence */
> > - __s32 fence; /* fd on newly created fence */
> > + char name[32];
> > + __s32 fd2;
> > + __s32 fence;
> > __u32 flags;
> > __u32 pad;
> > };
> > @@ -33,8 +33,8 @@ struct sync_merge_data {
> > /**
> > * struct sync_fence_info - detailed fence information
> > * @obj_name: name of parent sync_timeline
> > - * @driver_name: name of driver implementing the parent
> > - * @status: status of the fence 0:active 1:signaled <0:error
> > +* @driver_name: name of driver implementing the parent
> > +* @status: status of the fence 0:active 1:signaled <0:error
>
> Would you please specify why this hunk is needed, with
> fence info not mentioned in commit message?
This shouldn't be here. Probably some leftover from a rebase that I
didn't notice. Thanks for pointing it out. I'll update this patch.
Gustavo
next prev parent reply other threads:[~2016-04-29 13:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <00d201d1a1eb$86be73f0$943b5bd0$@alibaba-inc.com>
2016-04-29 7:53 ` [PATCH v2 01/13] staging/android: remove redundant comments on sync_merge_data Hillf Danton
2016-04-29 13:30 ` Gustavo Padovan [this message]
2016-04-28 13:46 [PATCH v2 00/13] De-stage Sync File Framework Gustavo Padovan
2016-04-28 13:46 ` [PATCH v2 01/13] staging/android: remove redundant comments on sync_merge_data Gustavo Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160429133023.GC2524@joana \
--to=gustavo.padovan@collabora.co.uk \
--cc=hillf.zj@alibaba-inc.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).