* [PATCH v2] rtlwifi: Fix logic error in enter/exit power-save mode
@ 2016-05-02 16:38 Wang YanQing
2016-05-02 17:00 ` Larry Finger
2016-05-11 18:44 ` [v2] " Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Wang YanQing @ 2016-05-02 16:38 UTC (permalink / raw)
To: Larry.Finger; +Cc: kvalo, chaoming_li, linux-wireless, netdev, linux-kernel
In commit a269913c52ad ("rtlwifi: Rework rtl_lps_leave() and
rtl_lps_enter() to use work queue"), the tests for enter/exit
power-save mode were inverted. With this change applied, the
wifi connection becomes much more stable.
Fixes: a269913c52ad ("rtlwifi: Rework rtl_lps_leave() and rtl_lps_enter() to use work queue")
Signed-off-by: Wang YanQing <udknight@gmail.com>
CC: Stable <stable@vger.kernel.org> [3.10+]
---
Hi, Larry!
Because commit a269913c52ad is the first commit bring this problem,
so maybe use above commit message is ok, right? And stable kernels
3.10-3.18 don't have commit fd09ff958777, but have a269913c52ad.
Thanks for suggestion concerning to good subject and commit message
writing, it is harder than coding sometimes:)
Changes:
v1-v2:
1: Fix subject and commit message.
drivers/net/wireless/realtek/rtlwifi/base.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/base.c b/drivers/net/wireless/realtek/rtlwifi/base.c
index c74eb13..264466f 100644
--- a/drivers/net/wireless/realtek/rtlwifi/base.c
+++ b/drivers/net/wireless/realtek/rtlwifi/base.c
@@ -1660,9 +1660,9 @@ void rtl_watchdog_wq_callback(void *data)
if (((rtlpriv->link_info.num_rx_inperiod +
rtlpriv->link_info.num_tx_inperiod) > 8) ||
(rtlpriv->link_info.num_rx_inperiod > 2))
- rtl_lps_enter(hw);
- else
rtl_lps_leave(hw);
+ else
+ rtl_lps_enter(hw);
}
rtlpriv->link_info.num_rx_inperiod = 0;
--
1.8.5.6.2.g3d8a54e.dirty
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] rtlwifi: Fix logic error in enter/exit power-save mode
2016-05-02 16:38 [PATCH v2] rtlwifi: Fix logic error in enter/exit power-save mode Wang YanQing
@ 2016-05-02 17:00 ` Larry Finger
2016-05-11 18:44 ` [v2] " Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Larry Finger @ 2016-05-02 17:00 UTC (permalink / raw)
To: Wang YanQing, kvalo, chaoming_li, linux-wireless, netdev, linux-kernel
On 05/02/2016 11:38 AM, Wang YanQing wrote:
> In commit a269913c52ad ("rtlwifi: Rework rtl_lps_leave() and
> rtl_lps_enter() to use work queue"), the tests for enter/exit
> power-save mode were inverted. With this change applied, the
> wifi connection becomes much more stable.
>
> Fixes: a269913c52ad ("rtlwifi: Rework rtl_lps_leave() and rtl_lps_enter() to use work queue")
> Signed-off-by: Wang YanQing <udknight@gmail.com>
> CC: Stable <stable@vger.kernel.org> [3.10+]
> ---
> Hi, Larry!
>
> Because commit a269913c52ad is the first commit bring this problem,
> so maybe use above commit message is ok, right? And stable kernels
> 3.10-3.18 don't have commit fd09ff958777, but have a269913c52ad.
>
> Thanks for suggestion concerning to good subject and commit message
> writing, it is harder than coding sometimes:)
>
> Changes:
> v1-v2:
> 1: Fix subject and commit message.
Yes, I agree that the commit message is hard.
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Thanks,
Larry
>
> drivers/net/wireless/realtek/rtlwifi/base.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/base.c b/drivers/net/wireless/realtek/rtlwifi/base.c
> index c74eb13..264466f 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/base.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/base.c
> @@ -1660,9 +1660,9 @@ void rtl_watchdog_wq_callback(void *data)
> if (((rtlpriv->link_info.num_rx_inperiod +
> rtlpriv->link_info.num_tx_inperiod) > 8) ||
> (rtlpriv->link_info.num_rx_inperiod > 2))
> - rtl_lps_enter(hw);
> - else
> rtl_lps_leave(hw);
> + else
> + rtl_lps_enter(hw);
> }
>
> rtlpriv->link_info.num_rx_inperiod = 0;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [v2] rtlwifi: Fix logic error in enter/exit power-save mode
2016-05-02 16:38 [PATCH v2] rtlwifi: Fix logic error in enter/exit power-save mode Wang YanQing
2016-05-02 17:00 ` Larry Finger
@ 2016-05-11 18:44 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2016-05-11 18:44 UTC (permalink / raw)
To: wang yanqing
Cc: Larry.Finger, chaoming_li, linux-wireless, netdev, linux-kernel
wang yanqing <udknight@gmail.com> wrote:
> In commit a269913c52ad ("rtlwifi: Rework rtl_lps_leave() and
> rtl_lps_enter() to use work queue"), the tests for enter/exit
> power-save mode were inverted. With this change applied, the
> wifi connection becomes much more stable.
>
> Fixes: a269913c52ad ("rtlwifi: Rework rtl_lps_leave() and rtl_lps_enter() to use work queue")
> Signed-off-by: Wang YanQing <udknight@gmail.com>
> CC: Stable <stable@vger.kernel.org> [3.10+]
> Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Thanks, 1 patch applied to wireless-drivers-next.git:
873ffe154ae0 rtlwifi: Fix logic error in enter/exit power-save mode
--
Sent by pwcli
https://patchwork.kernel.org/patch/8993841/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-05-11 18:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-02 16:38 [PATCH v2] rtlwifi: Fix logic error in enter/exit power-save mode Wang YanQing
2016-05-02 17:00 ` Larry Finger
2016-05-11 18:44 ` [v2] " Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).