From: Daniel Vetter <daniel@ffwll.ch>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: "Noralf Trønnes" <noralf@tronnes.org>,
treding@nvidia.com, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 4/4] drm/panel: Add helper for simple panel connector
Date: Fri, 6 May 2016 16:08:16 +0200 [thread overview]
Message-ID: <20160506140816.GD27098@phenom.ffwll.local> (raw)
In-Reply-To: <20160506140347.GB4641@ulmo.ba.sec>
On Fri, May 06, 2016 at 04:03:47PM +0200, Thierry Reding wrote:
> On Thu, May 05, 2016 at 03:24:34PM +0200, Noralf Trønnes wrote:
> > Add function to create a simple connector for a panel.
>
> I'm not sure I see the usefulness of this. Typically you'd attach a
> panel to an encoder/connector, in which case you already have the
> connector.
>
> Perhaps it would become more obvious why we need this if you posted
> patches that show where this is used?
The other helpers give you a simple drm pipeline with plane, crtc &
encoder all baked into on drm_simple_pipeline structure. The only thing
variable you have to hook up to that is the drm_connector. And I think for
dead-simple panels avoiding the basic boilerplate in that does indeed make
some sense.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2016-05-06 14:08 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-05 13:24 [PATCH 0/4] drm: Add various helpers for simple drivers Noralf Trønnes
2016-05-05 13:24 ` [PATCH 1/4] drm/fb-cma-helper: Add function drm_fb_cma_create_with_funcs() Noralf Trønnes
2016-05-05 16:27 ` Daniel Vetter
2016-05-06 13:01 ` Noralf Trønnes
2016-05-06 13:13 ` Daniel Vetter
2016-05-05 13:24 ` [PATCH 2/4] drm: Make drm_encoder_helper_funcs optional Noralf Trønnes
2016-05-05 16:23 ` Daniel Vetter
2016-05-09 19:19 ` Noralf Trønnes
2016-05-10 6:53 ` Daniel Vetter
2016-05-05 13:24 ` [PATCH 3/4] drm: Add helper for simple display pipeline Noralf Trønnes
2016-05-05 16:45 ` Daniel Vetter
2016-05-09 14:46 ` Daniel Vetter
2016-05-09 18:37 ` Noralf Trønnes
2016-05-10 6:59 ` Daniel Vetter
2016-05-10 22:36 ` Daniel Vetter
2016-05-05 13:24 ` [PATCH 4/4] drm/panel: Add helper for simple panel connector Noralf Trønnes
2016-05-05 17:03 ` Daniel Vetter
2016-05-06 13:39 ` Noralf Trønnes
2016-05-06 14:01 ` Thierry Reding
2016-05-06 14:07 ` Daniel Vetter
2016-05-06 14:03 ` Thierry Reding
2016-05-06 14:08 ` Daniel Vetter [this message]
2016-05-06 14:15 ` Thierry Reding
2016-05-06 14:34 ` Noralf Trønnes
2016-05-06 14:41 ` Daniel Vetter
2016-05-06 14:43 ` Thierry Reding
2016-05-06 19:45 ` Noralf Trønnes
2016-05-07 9:59 ` Daniel Vetter
2016-05-07 12:46 ` Noralf Trønnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160506140816.GD27098@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=noralf@tronnes.org \
--cc=thierry.reding@gmail.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).