* [PATCH] fix a kernel infoleak in x25 module
@ 2016-05-08 16:10 Kangjie Lu
2016-05-10 2:47 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Kangjie Lu @ 2016-05-08 16:10 UTC (permalink / raw)
To: andrew.hendry
Cc: davem, linux-x25, netdev, linux-kernel, taesoo, insu, csong84,
Kangjie Lu
Stack object "dte_facilities" is allocated in x25_rx_call_request(),
which is supposed to be initialized in x25_negotiate_facilities.
However, 5 fields (8 bytes in total) are not initialized. This
object is then copied to userland via copy_to_user, thus infoleak
occurs.
Signed-off-by: Kangjie Lu <kjlu@gatech.edu>
---
net/x25/x25_facilities.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/x25/x25_facilities.c b/net/x25/x25_facilities.c
index 2844031..a1c30c6 100644
--- a/net/x25/x25_facilities.c
+++ b/net/x25/x25_facilities.c
@@ -278,6 +278,7 @@ int x25_negotiate_facilities(struct sk_buff *skb, struct sock *sk,
memset(&theirs, 0, sizeof(theirs));
memcpy(new, ours, sizeof(*new));
+ memset(dte, 0, sizeof(*dte));
len = x25_parse_facilities(skb, &theirs, dte, &x25->vc_facil_mask);
if (len < 0)
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fix a kernel infoleak in x25 module
2016-05-08 16:10 [PATCH] fix a kernel infoleak in x25 module Kangjie Lu
@ 2016-05-10 2:47 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2016-05-10 2:47 UTC (permalink / raw)
To: kangjielu
Cc: andrew.hendry, linux-x25, netdev, linux-kernel, taesoo, insu,
csong84, kjlu
From: Kangjie Lu <kangjielu@gmail.com>
Date: Sun, 8 May 2016 12:10:14 -0400
> Stack object "dte_facilities" is allocated in x25_rx_call_request(),
> which is supposed to be initialized in x25_negotiate_facilities.
> However, 5 fields (8 bytes in total) are not initialized. This
> object is then copied to userland via copy_to_user, thus infoleak
> occurs.
>
> Signed-off-by: Kangjie Lu <kjlu@gatech.edu>
Applied and queued up for -stable thanks.
Please start formatting your Subject lines properly, I've been fixing
all of them up by hand.
You should specify a subsystem name prefix, then a ":" character, then
a space, then a description of your change. For example, for this
patch an appropriate Subject would have been:
[PATCH] x25: Fix a kernel infoleak in x25_negotiate_facilities().
Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-05-10 2:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-08 16:10 [PATCH] fix a kernel infoleak in x25 module Kangjie Lu
2016-05-10 2:47 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).