* [PATCH] mfd: vexpress: add !ARCH_USES_GETTIMEOFFSET dependency
@ 2016-04-27 17:49 Arnd Bergmann
2016-04-30 11:47 ` Linus Walleij
2016-05-09 14:40 ` Lee Jones
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2016-04-27 17:49 UTC (permalink / raw)
To: Lee Jones; +Cc: Linus Walleij, Arnd Bergmann, linux-kernel
The MFD_VEXPRESS_SYSREG driver selects CLKSRC_MMIO, which in turn
conflicts with ARCH_USES_GETTIMEOFFSET, causing a harmless Kconfig
warning when it is set:
warning: (ARCH_MVEBU && ARCH_DIGICOLOR && ARCH_GEMINI && ARCH_KEYSTONE && ARCH_MOXART && ARCH_MXS && PLAT_SPEAR && ARCH_SUNXI && ARCH_TEGRA && ARCH_U300 && PLAT_ORION && ARCH_CLPS711X && ARCH_EP93XX && ARCH_NETX && ARCH_IXP4XX && ARCH_KS8695 && ARCH_W90X900 && ARCH_PXA && ARCH_SA1100 && ARCH_OMAP1 && ARCH_BCM_IPROC && ARCH_INTEGRATOR_AP && ARCH_OMAP2PLUS && MFD_VEXPRESS_SYSREG) selects CLKSRC_MMIO which has unmet direct dependencies (!ARCH_USES_GETTIMEOFFSET)
This was apparently hidden by the fact that no ARM platform that
still sets ARCH_USES_GETTIMEOFFSET has gpiolib support, and we
already have a dependency on GPIOLIB that I added a while ago.
However, after 296ad4acb8ef ("gpio: remove deps on
ARCH_[WANT_OPTIONAL|REQUIRE]_GPIOLIB"), any platform can enable
CONFIG_GPIOLIB, and that lets us enable MFD_VEXPRESS_SYSREG
as well.
This adds an explicit dependency on !ARCH_USES_GETTIMEOFFSET
to guarantee that we can enable the CLKSRC_MMIO driver without
getting warnings.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/mfd/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 4b6d60f65429..461c0c4ff8d8 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -1569,7 +1569,7 @@ endmenu
config MFD_VEXPRESS_SYSREG
bool "Versatile Express System Registers"
- depends on VEXPRESS_CONFIG && GPIOLIB
+ depends on VEXPRESS_CONFIG && GPIOLIB && !ARCH_USES_GETTIMEOFFSET
default y
select CLKSRC_MMIO
select GPIO_GENERIC_PLATFORM
--
2.7.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mfd: vexpress: add !ARCH_USES_GETTIMEOFFSET dependency
2016-04-27 17:49 [PATCH] mfd: vexpress: add !ARCH_USES_GETTIMEOFFSET dependency Arnd Bergmann
@ 2016-04-30 11:47 ` Linus Walleij
2016-05-09 14:40 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2016-04-30 11:47 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: Lee Jones, linux-kernel
On Wed, Apr 27, 2016 at 7:49 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> The MFD_VEXPRESS_SYSREG driver selects CLKSRC_MMIO, which in turn
> conflicts with ARCH_USES_GETTIMEOFFSET, causing a harmless Kconfig
> warning when it is set:
>
> warning: (ARCH_MVEBU && ARCH_DIGICOLOR && ARCH_GEMINI && ARCH_KEYSTONE && ARCH_MOXART && ARCH_MXS && PLAT_SPEAR && ARCH_SUNXI && ARCH_TEGRA && ARCH_U300 && PLAT_ORION && ARCH_CLPS711X && ARCH_EP93XX && ARCH_NETX && ARCH_IXP4XX && ARCH_KS8695 && ARCH_W90X900 && ARCH_PXA && ARCH_SA1100 && ARCH_OMAP1 && ARCH_BCM_IPROC && ARCH_INTEGRATOR_AP && ARCH_OMAP2PLUS && MFD_VEXPRESS_SYSREG) selects CLKSRC_MMIO which has unmet direct dependencies (!ARCH_USES_GETTIMEOFFSET)
>
> This was apparently hidden by the fact that no ARM platform that
> still sets ARCH_USES_GETTIMEOFFSET has gpiolib support, and we
> already have a dependency on GPIOLIB that I added a while ago.
>
> However, after 296ad4acb8ef ("gpio: remove deps on
> ARCH_[WANT_OPTIONAL|REQUIRE]_GPIOLIB"), any platform can enable
> CONFIG_GPIOLIB, and that lets us enable MFD_VEXPRESS_SYSREG
> as well.
>
> This adds an explicit dependency on !ARCH_USES_GETTIMEOFFSET
> to guarantee that we can enable the CLKSRC_MMIO driver without
> getting warnings.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
OMG that was complex, thanks for explaining.
I am officially impress by your Kconfig ninja skills.
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Lee, please pick this up?
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mfd: vexpress: add !ARCH_USES_GETTIMEOFFSET dependency
2016-04-27 17:49 [PATCH] mfd: vexpress: add !ARCH_USES_GETTIMEOFFSET dependency Arnd Bergmann
2016-04-30 11:47 ` Linus Walleij
@ 2016-05-09 14:40 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2016-05-09 14:40 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: Linus Walleij, linux-kernel
On Wed, 27 Apr 2016, Arnd Bergmann wrote:
> The MFD_VEXPRESS_SYSREG driver selects CLKSRC_MMIO, which in turn
> conflicts with ARCH_USES_GETTIMEOFFSET, causing a harmless Kconfig
> warning when it is set:
>
> warning: (ARCH_MVEBU && ARCH_DIGICOLOR && ARCH_GEMINI && ARCH_KEYSTONE && ARCH_MOXART && ARCH_MXS && PLAT_SPEAR && ARCH_SUNXI && ARCH_TEGRA && ARCH_U300 && PLAT_ORION && ARCH_CLPS711X && ARCH_EP93XX && ARCH_NETX && ARCH_IXP4XX && ARCH_KS8695 && ARCH_W90X900 && ARCH_PXA && ARCH_SA1100 && ARCH_OMAP1 && ARCH_BCM_IPROC && ARCH_INTEGRATOR_AP && ARCH_OMAP2PLUS && MFD_VEXPRESS_SYSREG) selects CLKSRC_MMIO which has unmet direct dependencies (!ARCH_USES_GETTIMEOFFSET)
>
> This was apparently hidden by the fact that no ARM platform that
> still sets ARCH_USES_GETTIMEOFFSET has gpiolib support, and we
> already have a dependency on GPIOLIB that I added a while ago.
>
> However, after 296ad4acb8ef ("gpio: remove deps on
> ARCH_[WANT_OPTIONAL|REQUIRE]_GPIOLIB"), any platform can enable
> CONFIG_GPIOLIB, and that lets us enable MFD_VEXPRESS_SYSREG
> as well.
>
> This adds an explicit dependency on !ARCH_USES_GETTIMEOFFSET
> to guarantee that we can enable the CLKSRC_MMIO driver without
> getting warnings.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/mfd/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 4b6d60f65429..461c0c4ff8d8 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -1569,7 +1569,7 @@ endmenu
>
> config MFD_VEXPRESS_SYSREG
> bool "Versatile Express System Registers"
> - depends on VEXPRESS_CONFIG && GPIOLIB
> + depends on VEXPRESS_CONFIG && GPIOLIB && !ARCH_USES_GETTIMEOFFSET
> default y
> select CLKSRC_MMIO
> select GPIO_GENERIC_PLATFORM
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-05-09 14:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-27 17:49 [PATCH] mfd: vexpress: add !ARCH_USES_GETTIMEOFFSET dependency Arnd Bergmann
2016-04-30 11:47 ` Linus Walleij
2016-05-09 14:40 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).