From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Andi Kleen <andi@firstfloor.org>,
peterz@infradead.org, jolsa@kernel.org,
linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 06/10] perf, tools, stat: Avoid fractional digits for integer scales
Date: Wed, 11 May 2016 13:43:29 -0300 [thread overview]
Message-ID: <20160511164329.GF20258@kernel.org> (raw)
In-Reply-To: <20160511130031.GA1032@krava>
Em Wed, May 11, 2016 at 03:00:31PM +0200, Jiri Olsa escreveu:
> On Sat, May 07, 2016 at 12:24:25PM -0700, Andi Kleen wrote:
> > > > if (csv_output) {
> > > > - fmt = sc != 1.0 ? "%.2f%s" : "%.0f%s";
> > > > + fmt = floor(sc) != sc ? "%.2f%s" : "%.0f%s";
> > > > } else {
> > > > if (big_num)
> > > > - fmt = sc != 1.0 ? "%'18.2f%s" : "%'18.0f%s";
> > > > + fmt = floor(sc) != sc ? "%'18.2f%s" : "%'18.0f%s";
> > > > else
> > > > - fmt = sc != 1.0 ? "%18.2f%s" : "%18.0f%s";
> > > > + fmt = floor(sc) != sc ? "%18.2f%s" : "%18.0f%s";
> > >
> > > how about the rest of the code? we display % also in print_running
> > > and print_noise_pct functions and maybe some place else
> >
> > For those it doesn't matter. In fact it's probably better there
> > to always show the fractions.
> >
> > It is just confusing for metrics.
>
> ok, let's try and see, we can always follow up
> with the rest if there's a need
>
> Acked-by: Jiri Olsa <jolsa@kernel.org>
Missed this one, applied.
- Arnaldo
next prev parent reply other threads:[~2016-05-11 16:43 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-05 23:03 Add top down metrics to perf stat Andi Kleen
2016-05-05 23:03 ` [PATCH 01/10] x86: Add topology_max_smt_threads() Andi Kleen
2016-05-06 10:13 ` Peter Zijlstra
2016-05-06 10:47 ` Thomas Gleixner
2016-05-06 17:24 ` [UPDATED PATCH " Andi Kleen
2016-05-07 8:11 ` Thomas Gleixner
2016-05-12 8:07 ` Ingo Molnar
2016-05-05 23:03 ` [PATCH 02/10] x86, perf: Support sysfs files depending on SMT status Andi Kleen
2016-05-09 9:42 ` Peter Zijlstra
2016-05-09 14:27 ` Andi Kleen
2016-05-09 14:34 ` Peter Zijlstra
2016-05-12 8:05 ` Ingo Molnar
2016-05-05 23:04 ` [PATCH 03/10] x86, perf: Add Top Down events to Intel Core Andi Kleen
2016-05-11 13:23 ` Jiri Olsa
2016-05-11 13:29 ` Peter Zijlstra
2016-05-12 8:10 ` Ingo Molnar
2016-05-05 23:04 ` [PATCH 04/10] x86, perf: Add Top Down events to Intel Atom Andi Kleen
2016-05-05 23:04 ` [PATCH 05/10] x86, perf: Use new topology_max_smt_threads() in HT leak workaround Andi Kleen
2016-05-05 23:04 ` [PATCH 06/10] perf, tools, stat: Avoid fractional digits for integer scales Andi Kleen
2016-05-07 19:10 ` Jiri Olsa
2016-05-07 19:24 ` Andi Kleen
2016-05-11 13:00 ` Jiri Olsa
2016-05-11 16:43 ` Arnaldo Carvalho de Melo [this message]
2016-05-20 6:42 ` [tip:perf/urgent] perf " tip-bot for Andi Kleen
2016-05-05 23:04 ` [PATCH 07/10] perf, tools, stat: Scale values by unit before metrics Andi Kleen
2016-05-07 19:14 ` Jiri Olsa
2016-05-10 20:30 ` [tip:perf/core] perf " tip-bot for Andi Kleen
2016-05-05 23:04 ` [PATCH 08/10] perf, tools, stat: Basic support for TopDown in perf stat Andi Kleen
2016-05-05 23:04 ` [PATCH 09/10] perf, tools, stat: Add computation of TopDown formulas Andi Kleen
2016-05-05 23:04 ` [PATCH 10/10] perf, tools, stat: Add extra output of counter values with -vv Andi Kleen
2016-05-12 8:03 ` Jiri Olsa
2016-05-20 0:05 ` Andi Kleen
2016-05-12 7:47 ` Add top down metrics to perf stat Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160511164329.GF20258@kernel.org \
--to=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).