* [PATCH 0/2] net: pxa168_eth: improve performance
@ 2016-05-13 11:57 Jisheng Zhang
2016-05-13 11:57 ` [PATCH 1/2] net: pxa168_eth: use {readl|writel}_relaxed instead of readl/writel Jisheng Zhang
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Jisheng Zhang @ 2016-05-13 11:57 UTC (permalink / raw)
To: davem; +Cc: netdev, linux-kernel, linux-arm-kernel, Jisheng Zhang
This series is to improve the pxa168_eth driver performance by using
{readl|writel}_relaxed or appropriate memory barriers.
Jisheng Zhang (2):
net: pxa168_eth: use {readl|writel}_relaxed instead of readl/writel
net: pxa168_eth: Use dma_wmb/rmb where appropriate
drivers/net/ethernet/marvell/pxa168_eth.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
--
2.8.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/2] net: pxa168_eth: use {readl|writel}_relaxed instead of readl/writel
2016-05-13 11:57 [PATCH 0/2] net: pxa168_eth: improve performance Jisheng Zhang
@ 2016-05-13 11:57 ` Jisheng Zhang
2016-05-13 11:57 ` [PATCH 2/2] net: pxa168_eth: Use dma_wmb/rmb where appropriate Jisheng Zhang
2016-05-16 17:40 ` [PATCH 0/2] net: pxa168_eth: improve performance David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Jisheng Zhang @ 2016-05-13 11:57 UTC (permalink / raw)
To: davem; +Cc: netdev, linux-kernel, linux-arm-kernel, Jisheng Zhang
Since appropriate memory barriers are already there, use the relaxed
version to improve performance a bit.
Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
---
drivers/net/ethernet/marvell/pxa168_eth.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/marvell/pxa168_eth.c b/drivers/net/ethernet/marvell/pxa168_eth.c
index c442f6a..db774e3 100644
--- a/drivers/net/ethernet/marvell/pxa168_eth.c
+++ b/drivers/net/ethernet/marvell/pxa168_eth.c
@@ -286,12 +286,12 @@ static int pxa168_eth_stop(struct net_device *dev);
static inline u32 rdl(struct pxa168_eth_private *pep, int offset)
{
- return readl(pep->base + offset);
+ return readl_relaxed(pep->base + offset);
}
static inline void wrl(struct pxa168_eth_private *pep, int offset, u32 data)
{
- writel(data, pep->base + offset);
+ writel_relaxed(data, pep->base + offset);
}
static void abort_dma(struct pxa168_eth_private *pep)
--
2.8.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] net: pxa168_eth: Use dma_wmb/rmb where appropriate
2016-05-13 11:57 [PATCH 0/2] net: pxa168_eth: improve performance Jisheng Zhang
2016-05-13 11:57 ` [PATCH 1/2] net: pxa168_eth: use {readl|writel}_relaxed instead of readl/writel Jisheng Zhang
@ 2016-05-13 11:57 ` Jisheng Zhang
2016-05-16 17:40 ` [PATCH 0/2] net: pxa168_eth: improve performance David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Jisheng Zhang @ 2016-05-13 11:57 UTC (permalink / raw)
To: davem; +Cc: netdev, linux-kernel, linux-arm-kernel, Jisheng Zhang
Update the pxa168_eth driver to use the dma_rmb/wmb calls instead of the
full barriers in order to improve performance: reduced 97ns/39ns on
average in tx/rx path on Marvell BG4CT platform.
Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
---
drivers/net/ethernet/marvell/pxa168_eth.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/marvell/pxa168_eth.c b/drivers/net/ethernet/marvell/pxa168_eth.c
index db774e3..728a115 100644
--- a/drivers/net/ethernet/marvell/pxa168_eth.c
+++ b/drivers/net/ethernet/marvell/pxa168_eth.c
@@ -342,9 +342,9 @@ static void rxq_refill(struct net_device *dev)
pep->rx_skb[used_rx_desc] = skb;
/* Return the descriptor to DMA ownership */
- wmb();
+ dma_wmb();
p_used_rx_desc->cmd_sts = BUF_OWNED_BY_DMA | RX_EN_INT;
- wmb();
+ dma_wmb();
/* Move the used descriptor pointer to the next descriptor */
pep->rx_used_desc_q = (used_rx_desc + 1) % pep->rx_ring_size;
@@ -794,7 +794,7 @@ static int rxq_process(struct net_device *dev, int budget)
rx_used_desc = pep->rx_used_desc_q;
rx_desc = &pep->p_rx_desc_area[rx_curr_desc];
cmd_sts = rx_desc->cmd_sts;
- rmb();
+ dma_rmb();
if (cmd_sts & (BUF_OWNED_BY_DMA))
break;
skb = pep->rx_skb[rx_curr_desc];
@@ -1289,7 +1289,7 @@ static int pxa168_eth_start_xmit(struct sk_buff *skb, struct net_device *dev)
skb_tx_timestamp(skb);
- wmb();
+ dma_wmb();
desc->cmd_sts = BUF_OWNED_BY_DMA | TX_GEN_CRC | TX_FIRST_DESC |
TX_ZERO_PADDING | TX_LAST_DESC | TX_EN_INT;
wmb();
--
2.8.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 0/2] net: pxa168_eth: improve performance
2016-05-13 11:57 [PATCH 0/2] net: pxa168_eth: improve performance Jisheng Zhang
2016-05-13 11:57 ` [PATCH 1/2] net: pxa168_eth: use {readl|writel}_relaxed instead of readl/writel Jisheng Zhang
2016-05-13 11:57 ` [PATCH 2/2] net: pxa168_eth: Use dma_wmb/rmb where appropriate Jisheng Zhang
@ 2016-05-16 17:40 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2016-05-16 17:40 UTC (permalink / raw)
To: jszhang; +Cc: netdev, linux-kernel, linux-arm-kernel
From: Jisheng Zhang <jszhang@marvell.com>
Date: Fri, 13 May 2016 19:57:28 +0800
> This series is to improve the pxa168_eth driver performance by using
> {readl|writel}_relaxed or appropriate memory barriers.
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-05-16 17:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-13 11:57 [PATCH 0/2] net: pxa168_eth: improve performance Jisheng Zhang
2016-05-13 11:57 ` [PATCH 1/2] net: pxa168_eth: use {readl|writel}_relaxed instead of readl/writel Jisheng Zhang
2016-05-13 11:57 ` [PATCH 2/2] net: pxa168_eth: Use dma_wmb/rmb where appropriate Jisheng Zhang
2016-05-16 17:40 ` [PATCH 0/2] net: pxa168_eth: improve performance David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).