[PATCH] coccicheck: Fix missing 0 index in kill loop

[PATCH] coccicheck: Fix missing 0 index in kill loop

[Kees Cook]

By default, "seq" counts from 1, but processes were starting counting
from 0, so when interrupted, coccicheck would leave the 0th process
running.

Signed-off-by: Kees Cook <keescook@chromium.org>
---
 scripts/coccicheck | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/coccicheck b/scripts/coccicheck
index b2d758188f2f..dd85a455b2ba 100755
--- a/scripts/coccicheck
+++ b/scripts/coccicheck
@@ -98,7 +98,7 @@ run_cmd() {
 }
 
 kill_running() {
-	for i in $(seq $(( NPROC - 1 )) ); do
+	for i in $(seq 0 $(( NPROC - 1 )) ); do
 		if [ $VERBOSE -eq 2 ] ; then
 			echo "Killing ${SPATCH_PID[$i]}"
 		fi
-- 
2.6.3


-- 
Kees Cook
Chrome OS & Brillo Security

Re: [PATCH] coccicheck: Fix missing 0 index in kill loop

[Nicolas Palix (LIG)]

[-- Attachment #1: Type: text/plain, Size: 855 bytes --]

Le 16/05/16 14:55, Kees Cook a écrit :
> By default, "seq" counts from 1, but processes were starting counting
> from 0, so when interrupted, coccicheck would leave the 0th process
> running.
> 
> Signed-off-by: Kees Cook <keescook@chromium.org>

Acked-by: Nicolas Palix <nicolas.palix@imag.fr>


> ---
>  scripts/coccicheck | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/coccicheck b/scripts/coccicheck
> index b2d758188f2f..dd85a455b2ba 100755
> --- a/scripts/coccicheck
> +++ b/scripts/coccicheck
> @@ -98,7 +98,7 @@ run_cmd() {
>  }
>  
>  kill_running() {
> -	for i in $(seq $(( NPROC - 1 )) ); do
> +	for i in $(seq 0 $(( NPROC - 1 )) ); do
>  		if [ $VERBOSE -eq 2 ] ; then
>  			echo "Killing ${SPATCH_PID[$i]}"
>  		fi
> 


-- 
Nicolas Palix
http://lig-membres.imag.fr/palix/


[-- Attachment #2: Signature cryptographique S/MIME --]
[-- Type: application/pkcs7-signature, Size: 2959 bytes --]

Re: [PATCH] coccicheck: Fix missing 0 index in kill loop

[Julia Lawall]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 977 bytes --]



On Tue, 17 May 2016, Nicolas Palix (LIG) wrote:

> Le 16/05/16 14:55, Kees Cook a écrit :
> > By default, "seq" counts from 1, but processes were starting counting
> > from 0, so when interrupted, coccicheck would leave the 0th process
> > running.
> >
> > Signed-off-by: Kees Cook <keescook@chromium.org>
>
> Acked-by: Nicolas Palix <nicolas.palix@imag.fr>

Acked-by: Julia Lawall <julia.lawall@lip6.fr>

>
>
> > ---
> >  scripts/coccicheck | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/scripts/coccicheck b/scripts/coccicheck
> > index b2d758188f2f..dd85a455b2ba 100755
> > --- a/scripts/coccicheck
> > +++ b/scripts/coccicheck
> > @@ -98,7 +98,7 @@ run_cmd() {
> >  }
> >
> >  kill_running() {
> > -	for i in $(seq $(( NPROC - 1 )) ); do
> > +	for i in $(seq 0 $(( NPROC - 1 )) ); do
> >  		if [ $VERBOSE -eq 2 ] ; then
> >  			echo "Killing ${SPATCH_PID[$i]}"
> >  		fi
> >
>
>
> --
> Nicolas Palix
> http://lig-membres.imag.fr/palix/
>
>

Re: [PATCH] coccicheck: Fix missing 0 index in kill loop

[Michal Marek]

Dne 17.5.2016 v 16:33 Julia Lawall napsal(a):
> 
> 
> On Tue, 17 May 2016, Nicolas Palix (LIG) wrote:
> 
>> Le 16/05/16 14:55, Kees Cook a écrit :
>>> By default, "seq" counts from 1, but processes were starting counting
>>> from 0, so when interrupted, coccicheck would leave the 0th process
>>> running.
>>>
>>> Signed-off-by: Kees Cook <keescook@chromium.org>
>>
>> Acked-by: Nicolas Palix <nicolas.palix@imag.fr>
> 
> Acked-by: Julia Lawall <julia.lawall@lip6.fr>

Applied to kbuild.git#misc.

Michal