From: Calvin Owens <calvinowens@fb.com>
To: Richard Weinberger <richard.weinberger@gmail.com>
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
David Howells <dhowells@redhat.com>,
Pranith Kumar <bobby.prani@gmail.com>,
David Woodhouse <David.Woodhouse@intel.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Petr Mladek <pmladek@suse.com>, Tejun Heo <tj@kernel.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Vasily Averin <vvs@virtuozzo.com>,
Thierry Reding <treding@nvidia.com>,
Geliang Tang <geliangtang@163.com>,
Ivan Delalande <colona@arista.com>,
LKML <linux-kernel@vger.kernel.org>, <kernel-team@fb.com>
Subject: Re: [RFC][PATCH] printk: Add option to append kernel version to the dict
Date: Mon, 16 May 2016 14:41:03 -0700 [thread overview]
Message-ID: <20160516214103.GB2018262@devbig337.prn1.facebook.com> (raw)
In-Reply-To: <CAFLxGvxRn1ZSseSX2bh6D1czhZdPXD2hc4ZZtNEjbbsWhaHUMQ@mail.gmail.com>
On Sunday 05/15 at 00:19 +0200, Richard Weinberger wrote:
> On Fri, May 13, 2016 at 10:58 PM, Calvin Owens <calvinowens@fb.com> wrote:
> > We use netconsole to collect kernel logs from all the servers at
> > Facebook. We use this patch internally so each logline has a record of
> > which kernel version emitted it.
> >
> > At first glance, this might seem lazy: as you would expect, we have a
> > database which records which kernel version a host is currently running.
> > But there are a lot of situations where that database cannot be current:
> > early-ish boot crashes are probably the best example, but even beyond
> > that there are lots of varieties of kernel brokenness that can prevent
> > the database from being updated. Doing it explicitly this way ensures
> > that we always know exactly what version emitted a given message.
> >
> > Doing it in printk() itself rather than extended netconsole ends up
> > being much simpler, and has the advantage that future extended console
> > implementations will be able to benefit from this as well.
> >
> > Signed-off-by: Calvin Owens <calvinowens@fb.com>
> > ---
> > init/Kconfig | 8 ++++++++
> > kernel/printk/printk.c | 14 ++++++++++++++
> > 2 files changed, 22 insertions(+)
>
> I don't think adding a new config option is appropriate.
> How about adding a log format string tunable to netconsole?
Like a generic way to append arbitrary key/val to the dict? It would still
need to be configured via the kernel cmdline or at compile time: I can't
rely getting to userspace.
I had steered away from something more general like that because it
didn't seem worth the trobule, but I can certainly go that route: what
sort of format specifiers would we want? I only care about UTS_RELEASE,
but I suppose UTS_NODENAME and UTS_VERSION might be handy in some cases?
Thanks,
Calvin
> --
> Thanks,
> //richard
next prev parent reply other threads:[~2016-05-16 21:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-13 20:58 [RFC][PATCH] printk: Add option to append kernel version to the dict Calvin Owens
2016-05-14 22:19 ` Richard Weinberger
2016-05-16 21:41 ` Calvin Owens [this message]
2016-05-15 6:36 ` Sergey Senozhatsky
2016-05-16 22:02 ` Calvin Owens
2016-05-17 14:42 ` Sergey Senozhatsky
2016-05-17 13:51 ` Tejun Heo
2016-05-17 15:43 ` Sergey Senozhatsky
2016-05-17 16:05 ` Tejun Heo
2016-05-17 9:24 ` Petr Mladek
2016-05-17 10:08 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160516214103.GB2018262@devbig337.prn1.facebook.com \
--to=calvinowens@fb.com \
--cc=David.Woodhouse@intel.com \
--cc=akpm@linux-foundation.org \
--cc=ard.biesheuvel@linaro.org \
--cc=bobby.prani@gmail.com \
--cc=colona@arista.com \
--cc=dhowells@redhat.com \
--cc=geliangtang@163.com \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=pmladek@suse.com \
--cc=richard.weinberger@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=tj@kernel.org \
--cc=treding@nvidia.com \
--cc=vvs@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).