From: Calvin Owens <calvinowens@fb.com>
To: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
David Howells <dhowells@redhat.com>,
Pranith Kumar <bobby.prani@gmail.com>,
David Woodhouse <David.Woodhouse@intel.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Petr Mladek <pmladek@suse.com>, Tejun Heo <tj@kernel.org>,
Vasily Averin <vvs@virtuozzo.com>,
Thierry Reding <treding@nvidia.com>,
Geliang Tang <geliangtang@163.com>,
Ivan Delalande <colona@arista.com>,
<linux-kernel@vger.kernel.org>, <kernel-team@fb.com>
Subject: Re: [RFC][PATCH] printk: Add option to append kernel version to the dict
Date: Mon, 16 May 2016 15:02:52 -0700 [thread overview]
Message-ID: <20160516220252.GA2281534@devbig337.prn1.facebook.com> (raw)
In-Reply-To: <20160515063643.GA817@swordfish>
On Sunday 05/15 at 15:36 +0900, Sergey Senozhatsky wrote:
> Hello,
>
> On (05/13/16 13:58), Calvin Owens wrote:
> [..]
> > +#if defined(CONFIG_PRINTK_APPEND_UNAME)
> > +static ssize_t msg_print_ext_uname(char *buf, size_t size)
> > +{
> > + return scnprintf(buf, size, " UNAME=%s\n", init_utsname()->release);
> > +}
> > +#else
> > +static ssize_t msg_print_ext_uname(char *buf, size_t size)
> > +{
> > + return 0;
> > +}
> > +#endif
> > +
> > /* /dev/kmsg - userspace message inject/listen interface */
> > struct devkmsg_user {
> > u64 seq;
> > @@ -2305,6 +2317,8 @@ skip:
> > sizeof(ext_text) - ext_len,
> > log_dict(msg), msg->dict_len,
> > log_text(msg), msg->text_len);
> > + ext_len += msg_print_ext_uname(ext_text + ext_len,
> > + sizeof(ext_text) - ext_len);
> > }
>
> what if there is no place left for init_utsname() after
> msg_print_ext_header() + msg_print_ext_body()?
It ends up being truncated, like either of the preceeding calls would.
> do you need init_utsname in every message? or just in WARN/ERR ones?
I need it added to anything which netconsole actually emits: so I could
filter based on loglevel here if you like.
Thanks,
Calvin
>
> -ss
next prev parent reply other threads:[~2016-05-16 22:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-13 20:58 [RFC][PATCH] printk: Add option to append kernel version to the dict Calvin Owens
2016-05-14 22:19 ` Richard Weinberger
2016-05-16 21:41 ` Calvin Owens
2016-05-15 6:36 ` Sergey Senozhatsky
2016-05-16 22:02 ` Calvin Owens [this message]
2016-05-17 14:42 ` Sergey Senozhatsky
2016-05-17 13:51 ` Tejun Heo
2016-05-17 15:43 ` Sergey Senozhatsky
2016-05-17 16:05 ` Tejun Heo
2016-05-17 9:24 ` Petr Mladek
2016-05-17 10:08 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160516220252.GA2281534@devbig337.prn1.facebook.com \
--to=calvinowens@fb.com \
--cc=David.Woodhouse@intel.com \
--cc=akpm@linux-foundation.org \
--cc=ard.biesheuvel@linaro.org \
--cc=bobby.prani@gmail.com \
--cc=colona@arista.com \
--cc=dhowells@redhat.com \
--cc=geliangtang@163.com \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=pmladek@suse.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=tj@kernel.org \
--cc=treding@nvidia.com \
--cc=vvs@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).