From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
catalin.marinas@arm.com, dennis.chen@arm.com,
jiangshanlai@gmail.com, josh@joshtriplett.org,
linux-kernel@vger.kernel.org, mathieu.desnoyers@efficios.com,
rostedt@goodmis.org, steve.capper@arm.com, will.deacon@arm.com
Subject: Re: [PATCHv2] rcu: tree: correctly handle sparse possible CPUs
Date: Wed, 18 May 2016 11:41:55 -0700 [thread overview]
Message-ID: <20160518184155.GB3528@linux.vnet.ibm.com> (raw)
In-Reply-To: <20160518181509.GA8664@svinekod>
On Wed, May 18, 2016 at 07:15:09PM +0100, Mark Rutland wrote:
> On Wed, May 18, 2016 at 02:02:36PM +0200, Arnd Bergmann wrote:
> > It's the missing "possible_" that Mark mentioned in his reply on Friday.
>
> Actually, that was this morning. My VM on my laptop had a stale date due to
> suspend/resume of the host. :/
>
> I should be back at a real computer by Friday, and can respin the patch to fix
> the issue Andrey pointed out.
>
> Thanks for the fixup, and sorry for the confusion!
>
> Mark.
>
> > Please fold the fixup below into the patch if you want to get it to build.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de
Thank you both!
Looking forward to the respin that covers the various issues that have
been located.
Thanx, Paul
> > diff --git a/kernel/rcu/tree_plugin.h b/kernel/rcu/tree_plugin.h
> > index fd6b0f701bed..bb137b0ef6f3 100644
> > --- a/kernel/rcu/tree_plugin.h
> > +++ b/kernel/rcu/tree_plugin.h
> > @@ -1165,7 +1165,7 @@ static void rcu_boost_kthread_setaffinity(struct rcu_node *rnp, int outgoingcpu)
> > return;
> > if (!zalloc_cpumask_var(&cm, GFP_KERNEL))
> > return;
> > - for_each_leaf_node_cpu_bit(rnp, cpu, bit)
> > + for_each_leaf_node_possible_cpu_bit(rnp, cpu, bit)
> > if ((mask & bit) && cpu != outgoingcpu)
> > cpumask_set_cpu(cpu, cm);
> > if (cpumask_weight(cm) == 0)
> >
>
next prev parent reply other threads:[~2016-05-18 18:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-16 16:48 [PATCH] rcu: tree: correctly handle sparse possible CPUs Mark Rutland
2016-05-16 19:19 ` Paul E. McKenney
2016-05-17 10:22 ` [PATCHv2] " Mark Rutland
2016-05-17 19:01 ` Paul E. McKenney
2016-05-13 1:27 ` Mark Rutland
2016-05-18 0:12 ` Paul E. McKenney
2016-05-18 12:02 ` Arnd Bergmann
2016-05-18 18:15 ` Mark Rutland
2016-05-18 18:41 ` Paul E. McKenney [this message]
2016-05-20 10:30 ` kbuild test robot
2016-05-18 15:15 ` [PATCH] " Andrey Ryabinin
2016-05-18 18:01 ` Paul E. McKenney
2016-05-18 18:30 ` Mark Rutland
2016-05-18 18:44 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160518184155.GB3528@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=dennis.chen@arm.com \
--cc=jiangshanlai@gmail.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=rostedt@goodmis.org \
--cc=steve.capper@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).