* [PATCH 1/1] net: irda: avoid null pointer dereference
@ 2016-05-17 22:06 Heinrich Schuchardt
2016-05-19 18:31 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Heinrich Schuchardt @ 2016-05-17 22:06 UTC (permalink / raw)
To: Samuel Ortiz; +Cc: netdev, linux-kernel, Heinrich Schuchardt
Only dereference variable self after checking it is not NULL.
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
drivers/net/irda/nsc-ircc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/irda/nsc-ircc.c b/drivers/net/irda/nsc-ircc.c
index 9ef13d8..aaecc3b 100644
--- a/drivers/net/irda/nsc-ircc.c
+++ b/drivers/net/irda/nsc-ircc.c
@@ -1253,7 +1253,7 @@ static void nsc_ircc_change_dongle_speed(int iobase, int speed, int dongle_id)
*/
static __u8 nsc_ircc_change_speed(struct nsc_ircc_cb *self, __u32 speed)
{
- struct net_device *dev = self->netdev;
+ struct net_device *dev;
__u8 mcr = MCR_SIR;
int iobase;
__u8 bank;
@@ -1263,6 +1263,7 @@ static __u8 nsc_ircc_change_speed(struct nsc_ircc_cb *self, __u32 speed)
IRDA_ASSERT(self != NULL, return 0;);
+ dev = self->netdev;
iobase = self->io.fir_base;
/* Update accounting for new speed */
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] net: irda: avoid null pointer dereference
2016-05-17 22:06 [PATCH 1/1] net: irda: avoid null pointer dereference Heinrich Schuchardt
@ 2016-05-19 18:31 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2016-05-19 18:31 UTC (permalink / raw)
To: xypron.glpk; +Cc: samuel, netdev, linux-kernel
From: Heinrich Schuchardt <xypron.glpk@gmx.de>
Date: Wed, 18 May 2016 00:06:02 +0200
> Only dereference variable self after checking it is not NULL.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-05-19 18:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-17 22:06 [PATCH 1/1] net: irda: avoid null pointer dereference Heinrich Schuchardt
2016-05-19 18:31 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).