From: Rob Herring <robh@kernel.org>
To: Sanchayan Maity <maitysanchayan@gmail.com>
Cc: arnd@arndb.de, shawnguo@kernel.org, stefan@agner.ch,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/4] soc: Add SoC driver for Freescale Vybrid platform
Date: Mon, 23 May 2016 16:18:13 -0500 [thread overview]
Message-ID: <20160523211813.GA30237@rob-hp-laptop> (raw)
In-Reply-To: <ffef165d05f71a1b19437171d8fdb4bc78f6b1e3.1463737502.git.maitysanchayan@gmail.com>
On Fri, May 20, 2016 at 03:32:05PM +0530, Sanchayan Maity wrote:
> This adds a SoC driver to be used by Freescale Vybrid SoC's.
> Driver utilises syscon and nvmem consumer API's to get the
> various register values needed and expose the SoC specific
> properties via sysfs.
>
> A sample output from Colibri Vybrid VF61 is below:
>
> root@colibri-vf:~# cd /sys/bus/soc/devices/soc0
> root@colibri-vf:/sys/bus/soc/devices/soc0# ls
> family machine power revision soc_id subsystem uevent
> root@colibri-vf:/sys/bus/soc/devices/soc0# cat family
> Freescale Vybrid VF610
> root@colibri-vf:/sys/bus/soc/devices/soc0# cat machine
> Freescale Vybrid
> root@colibri-vf:/sys/bus/soc/devices/soc0# cat revision
> 00000013
> root@colibri-vf:/sys/bus/soc/devices/soc0# cat soc_id
> df6472a6130f29d4
>
> Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com>
> ---
> .../bindings/arm/freescale/fsl,vf610-soc.txt | 20 +++
> drivers/soc/Kconfig | 1 +
> drivers/soc/fsl/Kconfig | 10 ++
> drivers/soc/fsl/Makefile | 1 +
> drivers/soc/fsl/soc-vf610.c | 198 +++++++++++++++++++++
> 5 files changed, 230 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/arm/freescale/fsl,vf610-soc.txt
> create mode 100644 drivers/soc/fsl/Kconfig
> create mode 100644 drivers/soc/fsl/soc-vf610.c
>
> diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,vf610-soc.txt b/Documentation/devicetree/bindings/arm/freescale/fsl,vf610-soc.txt
> new file mode 100644
> index 0000000..338905d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,vf610-soc.txt
> @@ -0,0 +1,20 @@
> +Vybrid System-on-Chip
> +---------------------
> +
> +Required properties:
> +
> +- compatible: "fsl,vf610-soc"
> +- rom-revision: phandle to the on-chip ROM node
> +- mscm: phandle to the MSCM CPU configuration node
> +- nvmem-cells: phandles to two OCOTP child nodes ocotp_cfg0 and ocotp_cfg1
> +- nvmem-cell-names: should contain string names "cfg0" and "cfg1"
I still have similar concerns as the discussion on the last version.
This version only proves that you aren't describing h/w, but rather just
a collection of data that some driver wants.
A driver can just as easily look-up all the nodes directly that these
phandles point to.
And as long as we have inconsistent use of soc_device, I don't want to
see any compatible strings related to it.
Rob
next prev parent reply other threads:[~2016-05-23 21:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-20 10:02 [PATCH v3 0/4] Implement SoC driver for Vybrid Sanchayan Maity
2016-05-20 10:02 ` [PATCH v3 1/4] ARM: dts: vfxxx: Add device tree node for OCOTP Sanchayan Maity
2016-05-20 10:02 ` [PATCH v3 2/4] ARM: dts: vfxxx: Add On-Chip ROM node for Vybrid Sanchayan Maity
2016-05-20 10:02 ` [PATCH v3 3/4] ARM: dts: vfxxx: Add device tree node required by Vybrid SoC driver Sanchayan Maity
2016-05-20 10:02 ` [PATCH v3 4/4] soc: Add SoC driver for Freescale Vybrid platform Sanchayan Maity
2016-05-23 21:18 ` Rob Herring [this message]
2016-05-24 4:14 ` maitysanchayan
2016-05-24 17:09 ` Rob Herring
2016-05-25 15:18 ` Arnd Bergmann
2016-05-27 6:33 ` maitysanchayan
2016-05-27 8:31 ` Arnd Bergmann
2016-05-27 10:08 ` maitysanchayan
2016-05-27 17:28 ` Stefan Agner
2016-05-27 17:56 ` maitysanchayan
2016-06-09 10:38 ` maitysanchayan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160523211813.GA30237@rob-hp-laptop \
--to=robh@kernel.org \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maitysanchayan@gmail.com \
--cc=shawnguo@kernel.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).