From: maitysanchayan@gmail.com
To: Rob Herring <robh@kernel.org>
Cc: arnd@arndb.de, shawnguo@kernel.org, stefan@agner.ch,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/4] soc: Add SoC driver for Freescale Vybrid platform
Date: Tue, 24 May 2016 09:44:47 +0530 [thread overview]
Message-ID: <20160524041447.GA2884@Sanchayan-Arch.localdomain> (raw)
In-Reply-To: <20160523211813.GA30237@rob-hp-laptop>
Hello Rob,
On 16-05-23 16:18:13, Rob Herring wrote:
> On Fri, May 20, 2016 at 03:32:05PM +0530, Sanchayan Maity wrote:
> > This adds a SoC driver to be used by Freescale Vybrid SoC's.
> > Driver utilises syscon and nvmem consumer API's to get the
> > various register values needed and expose the SoC specific
> > properties via sysfs.
> >
> > A sample output from Colibri Vybrid VF61 is below:
> >
> > root@colibri-vf:~# cd /sys/bus/soc/devices/soc0
> > root@colibri-vf:/sys/bus/soc/devices/soc0# ls
> > family machine power revision soc_id subsystem uevent
> > root@colibri-vf:/sys/bus/soc/devices/soc0# cat family
> > Freescale Vybrid VF610
> > root@colibri-vf:/sys/bus/soc/devices/soc0# cat machine
> > Freescale Vybrid
> > root@colibri-vf:/sys/bus/soc/devices/soc0# cat revision
> > 00000013
> > root@colibri-vf:/sys/bus/soc/devices/soc0# cat soc_id
> > df6472a6130f29d4
> >
> > Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com>
> > ---
> > .../bindings/arm/freescale/fsl,vf610-soc.txt | 20 +++
> > drivers/soc/Kconfig | 1 +
> > drivers/soc/fsl/Kconfig | 10 ++
> > drivers/soc/fsl/Makefile | 1 +
> > drivers/soc/fsl/soc-vf610.c | 198 +++++++++++++++++++++
> > 5 files changed, 230 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/arm/freescale/fsl,vf610-soc.txt
> > create mode 100644 drivers/soc/fsl/Kconfig
> > create mode 100644 drivers/soc/fsl/soc-vf610.c
> >
> > diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,vf610-soc.txt b/Documentation/devicetree/bindings/arm/freescale/fsl,vf610-soc.txt
> > new file mode 100644
> > index 0000000..338905d
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,vf610-soc.txt
> > @@ -0,0 +1,20 @@
> > +Vybrid System-on-Chip
> > +---------------------
> > +
> > +Required properties:
> > +
> > +- compatible: "fsl,vf610-soc"
> > +- rom-revision: phandle to the on-chip ROM node
> > +- mscm: phandle to the MSCM CPU configuration node
> > +- nvmem-cells: phandles to two OCOTP child nodes ocotp_cfg0 and ocotp_cfg1
> > +- nvmem-cell-names: should contain string names "cfg0" and "cfg1"
>
> I still have similar concerns as the discussion on the last version.
> This version only proves that you aren't describing h/w, but rather just
> a collection of data that some driver wants.
>
> A driver can just as easily look-up all the nodes directly that these
> phandles point to.
Agreed, that we can look up all the nodes directly that these phandles
refer to but I would still need a DT entry to bind to. While I could
bind to existing nodes like mscm cpucfg but that doesn't seem right.
The very first approach that we had taken was to integrate this functionality
in mach-vf610.c code under mach-imx
http://www.spinics.net/lists/devicetree/msg80654.html
and then it was recommended to migrate this to drivers/soc where we did use
phandles or direct look up via compatible strings
http://www.spinics.net/lists/arm-kernel/msg420847.html
and
http://lkml.iu.edu/hypermail/linux/kernel/1506.0/03787.html
There hasn't been a consensus since v1.
>
> And as long as we have inconsistent use of soc_device, I don't want to
> see any compatible strings related to it.
>
Regards,
Sanchayan.
next prev parent reply other threads:[~2016-05-24 4:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-20 10:02 [PATCH v3 0/4] Implement SoC driver for Vybrid Sanchayan Maity
2016-05-20 10:02 ` [PATCH v3 1/4] ARM: dts: vfxxx: Add device tree node for OCOTP Sanchayan Maity
2016-05-20 10:02 ` [PATCH v3 2/4] ARM: dts: vfxxx: Add On-Chip ROM node for Vybrid Sanchayan Maity
2016-05-20 10:02 ` [PATCH v3 3/4] ARM: dts: vfxxx: Add device tree node required by Vybrid SoC driver Sanchayan Maity
2016-05-20 10:02 ` [PATCH v3 4/4] soc: Add SoC driver for Freescale Vybrid platform Sanchayan Maity
2016-05-23 21:18 ` Rob Herring
2016-05-24 4:14 ` maitysanchayan [this message]
2016-05-24 17:09 ` Rob Herring
2016-05-25 15:18 ` Arnd Bergmann
2016-05-27 6:33 ` maitysanchayan
2016-05-27 8:31 ` Arnd Bergmann
2016-05-27 10:08 ` maitysanchayan
2016-05-27 17:28 ` Stefan Agner
2016-05-27 17:56 ` maitysanchayan
2016-06-09 10:38 ` maitysanchayan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160524041447.GA2884@Sanchayan-Arch.localdomain \
--to=maitysanchayan@gmail.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=shawnguo@kernel.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).