linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Pali Rohár" <pali.rohar@gmail.com>
To: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>, sre@kernel.org
Cc: dbaryshkov@gmail.com, dwmw2@infradead.org,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Pavel Machek <pavel@ucw.cz>
Subject: Re: [PATCH] power_suply: isp1704_charger: Fix isp1704_write() definition
Date: Tue, 24 May 2016 17:32:06 +0200	[thread overview]
Message-ID: <20160524153206.GU29844@pali> (raw)
In-Reply-To: <20160519091304.GK29844@pali>

On Thursday 19 May 2016 11:13:04 Pali Rohár wrote:
> On Saturday 09 January 2016 23:42:30 Pali Rohár wrote:
> > On Friday 01 January 2016 12:26:21 Pali Rohár wrote:
> > > On Friday 01 January 2016 12:03:29 Ivaylo Dimitrov wrote:
> > > > All calls to isp1704_write() are using parameter sequence of
> > > > isp1704_write(isp, reg, val) but the function is defined as
> > > > isp1704_write(isp, val, reg). Fix isp1704_write function definition
> > > > so that the driver to be functional.
> > > > 
> > > > Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
> > > 
> > > Reviewed-by: Pali Rohár <pali.rohar@gmail.com>
> > > 
> > > This problem is there since inclusion of driver itself. No idea why
> > > that driver could work... I remember that it detected correctly type
> > > of charger.
> > > 
> > > I will test this patch on real N900 HW in one or two weeks to check
> > > how it behave after patching...
> > 
> > Tested-by: Pali Rohár <pali.rohar@gmail.com>
> > 
> > Please send this patch to all stable kernels.
> 
> Hi! I still think that this patch should go to stable kernels. Because
> without it driver does not work... Will somebody send it to stable?

So no objections, I sent it to stable@vger.kernel.org.

-- 
Pali Rohár
pali.rohar@gmail.com

      reply	other threads:[~2016-05-24 15:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-01 11:03 [PATCH] power_suply: isp1704_charger: Fix isp1704_write() definition Ivaylo Dimitrov
2016-01-01 11:26 ` Pali Rohár
2016-01-01 11:33   ` Ivaylo Dimitrov
2016-01-02 15:48     ` Pali Rohár
2016-01-09 22:42   ` Pali Rohár
2016-05-19  9:13     ` Pali Rohár
2016-05-24 15:32       ` Pali Rohár [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160524153206.GU29844@pali \
    --to=pali.rohar@gmail.com \
    --cc=dbaryshkov@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=ivo.g.dimitrov.75@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).