linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
To: "Pali Rohár" <pali.rohar@gmail.com>
Cc: sre@kernel.org, dbaryshkov@gmail.com, dwmw2@infradead.org,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] power_suply: isp1704_charger: Fix isp1704_write() definition
Date: Fri, 1 Jan 2016 13:33:03 +0200	[thread overview]
Message-ID: <568663EF.9070502@gmail.com> (raw)
In-Reply-To: <201601011226.21552@pali>

Hi Pali,

On  1.01.2016 13:26, Pali Rohár wrote:
> On Friday 01 January 2016 12:03:29 Ivaylo Dimitrov wrote:
>> All calls to isp1704_write() are using parameter sequence of
>> isp1704_write(isp, reg, val) but the function is defined as
>> isp1704_write(isp, val, reg). Fix isp1704_write function definition
>> so that the driver to be functional.
>>
>> Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
>
> Reviewed-by: Pali Rohár <pali.rohar@gmail.com>
>
> This problem is there since inclusion of driver itself. No idea why that
> driver could work... I remember that it detected correctly type of
> charger.
>
> I will test this patch on real N900 HW in one or two weeks to check how
> it behave after patching...
>

Well, I  tested in on real HW, wall charger as well as USB were 
correctly detected. No idea what else needs to be tested, but I guess if 
you guide me, I can test whatever is needed.

Ivo

  reply	other threads:[~2016-01-01 11:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-01 11:03 [PATCH] power_suply: isp1704_charger: Fix isp1704_write() definition Ivaylo Dimitrov
2016-01-01 11:26 ` Pali Rohár
2016-01-01 11:33   ` Ivaylo Dimitrov [this message]
2016-01-02 15:48     ` Pali Rohár
2016-01-09 22:42   ` Pali Rohár
2016-05-19  9:13     ` Pali Rohár
2016-05-24 15:32       ` Pali Rohár

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=568663EF.9070502@gmail.com \
    --to=ivo.g.dimitrov.75@gmail.com \
    --cc=dbaryshkov@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=pali.rohar@gmail.com \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).